Skip to contentSkip to conversation

arm64: dts: beacon-renesom-baseboard: Remove LVDS Panel

PATCH Superseded Adam Ford 3 participants 3 messages Mar 19 – Mar 25

Subsystems (2)
Device tree bindings Arm/RISC-V/Renesas architecture

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 arm64: dts: beacon-renesom-baseboard: Remove LVDS Panel

The LVDS Panel was never shipped from Beacon, and there are device tree errors, so rather than trying to fix them, remove it instead.

Signed-off-by Adam Ford <[email protected]>
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +0 -44
index d55f2d7066ad..dcc98e8424f7 100644
@@ -101,38 +101,6 @@ led3 {
 		};
 	};
 
-	lvds {
-		compatible = "panel-lvds";
-		power-supply = <&reg_lcd_reset>;
-		width-mm = <223>;
-		height-mm = <125>;
-		backlight = <&backlight_lvds>;
-		data-mapping = "vesa-24";
-
-		panel-timing {
-			/* 800x480@60Hz */
-			clock-frequency = <30000000>;
-			hactive = <800>;
-			vactive = <480>;
-			hsync-len = <48>;
-			hfront-porch = <40>;
-			hback-porch = <40>;
-			vfront-porch = <13>;
-			vback-porch = <29>;
-			vsync-len = <1>;
-			hsync-active = <1>;
-			vsync-active = <3>;
-			de-active = <1>;
-			pixelclk-active = <0>;
-		};
-
-		port {
-			panel_in: endpoint {
-				remote-endpoint = <&lvds0_out>;
-			};
-		};
-	};
-
 	rgb {
 		/* Different LCD with compatible timings */
 		compatible = "rocktech,rk070er9427";

@@ -480,18 +448,6 @@ gpio_exp1: gpio@70 {
 	};
 };
 
-&lvds0 {
-	status = "okay";
-
-	ports {
-		port@1 {
-			lvds0_out: endpoint {
-				remote-endpoint = <&panel_in>;
-			};
-		};
-	};
-};
-
 &msiof1 {
 	pinctrl-0 = <&msiof1_pins>;
 	pinctrl-names = "default";
Signature · 1 line
2.51.0
#2 lore raw
In reply to Adam Ford

Hi Adam,

Quoted 4 lines · Adam Ford

The LVDS Panel was never shipped from Beacon, and there are device tree errors, so rather than trying to fix them, remove it instead.

Signed-off-by Adam Ford <[email protected]>

Thanks for your patch!

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi led3 { · line 106

Quoted 9 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +0 -3
@@ -101,38 +101,6 @@ led3 {
                };
        };
 
-       lvds {
-               compatible = "panel-lvds";
-               power-supply = <&reg_lcd_reset>;

Shouldn't you remove the reg_lcd_reset...

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi led3 { · line 109

Quoted 3 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +0 -3
-               width-mm = <223>;
-               height-mm = <125>;
-               backlight = <&backlight_lvds>;

... and backlight_lvds nodes, too?

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds