Skip to contentSkip to conversation

iommu: fix a reference count leak in iommu_sva_bind_device()

PATCH Superseded [email protected] 2 participants 2 messages Mar 19 Stable branch

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu: fix a reference count leak in iommu_sva_bind_device()

From: Vasant Karasulli <[email protected]>

From: Vasant Karasulli <[email protected]>

commit b34289505180 ("iommu: disable SVA when CONFIG_X86 is set") disables SVA to mitigate a security vulnerability.

Due the current placement of the condition check, function returns after iommu_group_get() without a corresponding iommu_group_put(). So move the condition check above.

This is a stable-only fix applicable to linux-5.15.y.

Fixes b34289505("iommu: disable SVA when CONFIG_X86 is set")
---
 drivers/iommu/iommu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iommu/iommu.c +3 -3
index 964170f90597..25119d75537c 100644
@@ -3061,6 +3061,9 @@ iommu_sva_bind_device(struct device *dev, struct mm_struct *mm, void *drvdata)
 	struct iommu_sva *handle = ERR_PTR(-EINVAL);
 	const struct iommu_ops *ops = dev->bus->iommu_ops;
 
+	if (IS_ENABLED(CONFIG_X86))
+		return ERR_PTR(-EOPNOTSUPP);
+
 	if (!ops || !ops->sva_bind)
 		return ERR_PTR(-ENODEV);
 
@@ -3068,9 +3071,6 @@ iommu_sva_bind_device(struct device *dev, struct mm_struct *mm, void *drvdata)
 	if (!group)
 		return ERR_PTR(-ENODEV);
 
-	if (IS_ENABLED(CONFIG_X86))
-		return ERR_PTR(-EOPNOTSUPP);
-
 	/* Ensure device count and domain don't change while we're binding */
 	mutex_lock(&group->mutex);
 

base-commit: 3330a8d33e086f76608bb4e80a3dc569d04a8814

Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 3 lines · On Thu, Mar 19, 2026 at 03:25:44PM +0100, [email protected] wrote:

From: Vasant Karasulli <[email protected]>

From: Vasant Karasulli <[email protected]>

Two from lines?

Quoted 3 lines

commit b34289505180 ("iommu: disable SVA when CONFIG_X86 is set") disables SVA to mitigate a security vulnerability.

Trailing whitespace :(

Quoted 8 lines

Due the current placement of the condition check, function returns after iommu_group_get() without a corresponding iommu_group_put(). So move the condition check above.

This is a stable-only fix applicable to linux-5.15.y.

Fixes b34289505("iommu: disable SVA when CONFIG_X86 is set")

This needs an extra space, and the proper number of digits

Quoted 2 lines

No blank line between the two.

thanks,

greg k-h