staging: rtl8723bs: initialize le_tmp64 in rtw_BIP_verify()
PATCH 1/1 staging: rtl8723bs: initialize le_tmp64 in rtw_BIP_verify()
Initialize le_tmp64 to zero in rtw_BIP_verify() to prevent using uninitialized data.
Smatch warns that only 6 bytes are copied to this 8-byte (u64) variable, leaving the last two bytes uninitialized:
drivers/staging/rtl8723bs/core/rtw_security.c:1308 rtw_BIP_verify()
warn: not copying enough bytes for '&le_tmp64' (8 vs 6 bytes)
Initializing the variable at the start of the function fixes this warning and ensures predictable behavior.
--- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_security.c +1 -1
@@ -1291,7 +1291,7 @@ u32 rtw_BIP_verify(struct adapter *padapter, u8 *precvframe)u8 mic[16 ];struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;__le16 le_tmp; -__le64 le_tmp64; +__le64 le_tmp64 =0 ; ori_len = pattrib->pkt_len -WLAN_HDR_A3_LEN +BIP_AAD_SIZE ;BIP_AAD =kzalloc (ori_len,GFP_KERNEL );
Signature · 1 line
2.34.1
Quoted 9 lines · Lin YuChen
Initialize
le_tmp64to zero inrtw_BIP_verify()to prevent using uninitialized data.Smatch warns that only 6 bytes are copied to this 8-byte (u64) variable, leaving the last two bytes uninitialized:
drivers/staging/rtl8723bs/core/rtw_security.c:1308rtw_BIP_verify()
warn: not copying enough bytes for '&le_tmp64' (8 vs 6 bytes)
Quoted 7 lines
Initializing the variable at the start of the function fixes this warning and ensures predictable behavior.
Reported-by Dan Carpenter <[email protected]>Signed-off-by Lin YuChen <[email protected]>---
Add a Fixes tag? Otherwise, it looks good.
regards,
dan carpenter