Skip to contentSkip to conversation

staging: axis-fifo: remove redundant comments for mutex fields

PATCH In review Zile Xiong 2 participants 2 messages Mar 20 Staging

lore
Share & tools
lore

Zile Xiong

author
#0 lore raw

PATCH 1/1 staging: axis-fifo: remove redundant comments for mutex fields

Remove redundant comments for read_lock and write_lock, as the field names already clearly describe their purpose.

---
 drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +2 -2
index 3aa2aa870ea9..ad98d5eb7751 100644
@@ -75,9 +75,9 @@ struct axis_fifo {
 	u32 has_tx_fifo;
 
 	wait_queue_head_t read_queue;
-	struct mutex read_lock; /* lock for reading */
+	struct mutex read_lock;
 	wait_queue_head_t write_queue;
-	struct mutex write_lock; /* lock for writing */
+	struct mutex write_lock;
 
 	struct device *dt_device;
 	struct miscdevice miscdev;
Signature · 1 line
2.39.5
#1 lore raw
Quoted 4 lines · Zile Xiong

Remove redundant comments for read_lock and write_lock, as the field names already clearly describe their purpose.

You're not wrong, but this introduces a checkpatch warning so we can't accept it either.

regards,
dan carpenter