Skip to contentSkip to conversation

MIPS: Alchemy: Remove unused forward declaration

PATCH RESEND Applied Andy Shevchenko 2 participants 2 messages Mar 20 – Apr 13

Subsystems (2)

v2 of 3 Applied Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 MIPS: Alchemy: Remove unused forward declaration

The 'struct gpio' is not used in the code, remove unneeded forward declaration. This seems to be a leftover for a 5 years.

---

v2 (resend): Cc'ed to GPIO maintainers and ML
v2: collected tags (Thomas)

Bart, it was agreed to take this patch via GPIO tree (that's why we have an Ack), can you apply it, please?

 arch/mips/include/asm/mach-au1x00/gpio-au1000.h | 2 --
 arch/mips/include/asm/mach-au1x00/gpio-au1300.h | 1 -
 2 files changed, 3 deletions(-)
arch/mips/include/asm/mach-au1x00/gpio-au1000.h +0 -2
index d820b481ac56..e6306f6820e6 100644
@@ -40,8 +40,6 @@
 #define AU1000_GPIO2_INTENABLE	0x10
 #define AU1000_GPIO2_ENABLE	0x14
 
-struct gpio;
-
 static inline int au1000_gpio1_to_irq(int gpio)
 {
 	return MAKE_IRQ(1, gpio - ALCHEMY_GPIO1_BASE);
arch/mips/include/asm/mach-au1x00/gpio-au1300.h +0 -1
index 43d44f384f97..b12f37262cfa 100644
@@ -12,7 +12,6 @@
 #include <asm/io.h>
 #include <asm/mach-au1x00/au1000.h>
 
-struct gpio;
 struct gpio_chip;
 
 /* with the current GPIC design, up to 128 GPIOs are possible.
Signature · 1 line
2.50.1
maintainer Applied
#1 lore raw
Quoted 44 lines · Andy Shevchenko

The 'struct gpio' is not used in the code, remove unneeded forward declaration. This seems to be a leftover for a 5 years.

---

v2 (resend): Cc'ed to GPIO maintainers and ML
v2: collected tags (Thomas)

Bart, it was agreed to take this patch via GPIO tree (that's why we have an Ack), can you apply it, please?

 arch/mips/include/asm/mach-au1x00/gpio-au1000.h | 2 --
 arch/mips/include/asm/mach-au1x00/gpio-au1300.h | 1 -
 2 files changed, 3 deletions(-)
arch/mips/include/asm/mach-au1x00/gpio-au1000.h +0 -2
index d820b481ac56..e6306f6820e6 100644
@@ -40,8 +40,6 @@
 #define AU1000_GPIO2_INTENABLE	0x10
 #define AU1000_GPIO2_ENABLE	0x14
 
-struct gpio;
-
 static inline int au1000_gpio1_to_irq(int gpio)
 {
 	return MAKE_IRQ(1, gpio - ALCHEMY_GPIO1_BASE);
arch/mips/include/asm/mach-au1x00/gpio-au1300.h +0 -1
index 43d44f384f97..b12f37262cfa 100644
@@ -12,7 +12,6 @@
 #include <asm/io.h>
 #include <asm/mach-au1x00/au1000.h>
 
-struct gpio;
 struct gpio_chip;
 
 /* with the current GPIC design, up to 128 GPIOs are possible.
Signature · 1 line
2.50.1

applied to mips-next

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]