gn: upgrade to latest revision
cover gn: upgrade to latest revision
The latest revision of gn is needed to build Chromium 145 for whinlatter. Nothing else.
See https://github.com/OSSystems/meta-browser/pull/963
Please merge these into whinlatter.
Thanks in advance,
Zoltán Böszörményi
PATCH 1/4 gn: upgrade to latest revision
From: Khem Raj <[email protected]>
--- meta/recipes-devtools/gn/gn_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gn/gn_git.bb +1 -1
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native" UPSTREAM_CHECK_COMMITS = "1" SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main" -SRCREV = "81b24e01531ecf0eff12ec9359a555ec3944ec4e" +SRCREV = "092f4f0d612e5982728c8b872c2e69cf3d04b21f" PV = "0+git" BB_GIT_SHALLOW = ""
Signature · 1 line
2.53.0
PATCH 2/4 gn: upgrade to latest revision
In reply to Zoltán BöszörményiFrom: Alexander Kanavin <[email protected]>
--- meta/recipes-devtools/gn/gn_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gn/gn_git.bb +1 -1
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native" UPSTREAM_CHECK_COMMITS = "1" SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main" -SRCREV = "092f4f0d612e5982728c8b872c2e69cf3d04b21f" +SRCREV = "64d35867ca0a1088f13de8f4ccaf1a5687d7f1ce" PV = "0+git" BB_GIT_SHALLOW = ""
Signature · 1 line
2.53.0
PATCH 3/4 gn: upgrade to latest revision
In reply to Zoltán BöszörményiFrom: Khem Raj <[email protected]>
--- meta/recipes-devtools/gn/gn_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gn/gn_git.bb +1 -1
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native" UPSTREAM_CHECK_COMMITS = "1" SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main" -SRCREV = "64d35867ca0a1088f13de8f4ccaf1a5687d7f1ce" +SRCREV = "103f8b437f5e791e0aef9d5c372521a5d675fabb" PV = "0+git" BB_GIT_SHALLOW = ""
Signature · 1 line
2.53.0
PATCH 4/4 gn: upgrade to latest revision
In reply to Zoltán BöszörményiFrom: Hongxu Jia <[email protected]>
--- meta/recipes-devtools/gn/gn_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gn/gn_git.bb +1 -1
@@ -7,7 +7,7 @@ DEPENDS += "ninja-native" UPSTREAM_CHECK_COMMITS = "1" SRC_URI = "git://gn.googlesource.com/gn;protocol=https;branch=main" -SRCREV = "103f8b437f5e791e0aef9d5c372521a5d675fabb" +SRCREV = "9d19a7870add65151ff91bcc26252bb7521065cf" PV = "0+git" BB_GIT_SHALLOW = ""
Signature · 1 line
2.53.0
Quoted 7 lines · Zoltan Boszormenyi via lists.openembedded.org
The latest revision of gn is needed to build Chromium 145 for whinlatter. Nothing else.
See https://github.com/OSSystems/meta-browser/pull/963
Please merge these into whinlatter.
Hello,
Sorry but general upgrades like this are not acceptable for stable.
Is there a verifiable stability promise from gn upstream that would somehow make that acceptable? Note that I'm not familiar with it.
Regards,
Quoted 3 lines
Thanks in advance,
Zoltán Böszörményi
Signature · 2 lines
Yoann Congal Smile ECS
2026. 03. 21. 10:19 keltezéssel, Yoann Congal írta:
Quoted 10 lines · Zoltan Boszormenyi via lists.openembedded.org
Quoted 6 lines
The latest revision of gn is needed to build Chromium 145 for whinlatter. Nothing else.
See https://github.com/OSSystems/meta-browser/pull/963
Please merge these into whinlatter.
Hello,
Sorry but general upgrades like this are not acceptable for stable.
I can keep the gn_git.bbappend in the meta-browser PR.
But then it's not better when every layer shipped their version before moving it to core.
Quoted 2 lines
Is there a verifiable stability promise from gn upstream that would somehow make that acceptable? Note that I'm not familiar with it.
Chromium updates carry a lot of CVE fixes, too. gn is just a build tool for it and other projects.
Quoted 14 lines · Böszörményi Zoltán
2026. 03. 21. 10:19 keltezéssel, Yoann Congal írta:
Quoted 10 lines · Zoltan Boszormenyi via lists.openembedded.org
Quoted 6 lines
The latest revision of gn is needed to build Chromium 145 for whinlatter. Nothing else.
See https://github.com/OSSystems/meta-browser/pull/963
Please merge these into whinlatter.
Hello,
Sorry but general upgrades like this are not acceptable for stable.
I can keep the gn_git.bbappend in the meta-browser PR.
Quoted 8 lines
But then it's not better when every layer shipped their version before moving it to core.
Quoted 2 lines
Is there a verifiable stability promise from gn upstream that would somehow make that acceptable? Note that I'm not familiar with it.
Chromium updates carry a lot of CVE fixes, too. gn is just a build tool for it and other projects.
Yes I understand.
But this upgrade has feature changes in it (see below) and those are generaly unacceptable on the risk breaking existing code and our stability promise.
Your whole series upgrade gn by 43 commits. I saw these ones that are problematic just by reading the commit title:
$ git log --oneline 81b24e01531ecf0eff12ec9359a555ec3944ec4e..9d19a7870add65151ff91bcc26252bb7521065cf 7498ca2e Add validation support to gn analyze/desc/path/refs 3c0f5be7 Add pcm files to the deps of phony target bd3356ac Add `validations` dependency type to targets 1d89b984 Add conductor setup files 4e0818fd Add a sha256 hash implementation and use it for string_hash 0eb071f6 Add a `module_name` flag to source_set. bf891ce4 Refactor module name to be dynamic. 8450d601 Optimize vector creation in compile_commands_writer.cc. 6e0b557d Run 'tools/run_formatter.sh' ab6f8b21 Implement `string_hash` function. d92aee22 Support weak_libraries 4619125b Do not add .inputdeps paths to --ninja-outputs-file fb3b73df Make clang modules output -fmodule-file=foo=<pcm>. e7f32021 Add --file_relation to gn refs command 20a6b6d6 Optimize vector initialization and preallocation in desc_builder.cc. a0c5124a Add `reserve` statement when vector size is known beforehand. 092f4f0d Refactor container update by preferring the range insert.
If you want a shared repo with an upgraded gn for LTS, what do you think about creating a mixin layer?
https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#LTS_%E2%80%9CMixin%E2%80%9D_repositories
https://git.yoctoproject.org/meta-lts-mixins
For whinlatter (stable but not a LTS) which have more or less a month of support left, the bbappend in your layer is, IMHO, the realistic solution.
Regards,
Signature · 2 lines
Yoann Congal Smile ECS
2026. 03. 21. 19:45 keltezéssel, Yoann Congal írta:
Quoted 28 lines · Böszörményi Zoltán
Quoted 13 lines
2026. 03. 21. 10:19 keltezéssel, Yoann Congal írta:
Quoted 10 lines · Zoltan Boszormenyi via lists.openembedded.org
Quoted 6 lines
The latest revision of gn is needed to build Chromium 145 for whinlatter. Nothing else.
See https://github.com/OSSystems/meta-browser/pull/963
Please merge these into whinlatter.
Hello,
Sorry but general upgrades like this are not acceptable for stable.
I can keep the gn_git.bbappend in the meta-browser PR.
Quoted 7 lines
But then it's not better when every layer shipped their version before moving it to core.
Quoted 2 lines
Is there a verifiable stability promise from gn upstream that would somehow make that acceptable? Note that I'm not familiar with it.
Chromium updates carry a lot of CVE fixes, too. gn is just a build tool for it and other projects.
Yes I understand.
But this upgrade has feature changes in it (see below) and those are generaly unacceptable on the risk breaking existing code and our stability promise.Your whole series upgrade gn by 43 commits. I saw these ones that are problematic just by reading the commit title:
Quoted 11 lines
$ git log --oneline 81b24e01531ecf0eff12ec9359a555ec3944ec4e..9d19a7870add65151ff91bcc26252bb7521065cf 7498ca2e Add validation support to gn analyze/desc/path/refs 3c0f5be7 Add pcm files to the deps of phony target bd3356ac Add `validations` dependency type to targets 1d89b984 Add conductor setup files 4e0818fd Add a sha256 hash implementation and use it for string_hash 0eb071f6 Add a `module_name` flag to source_set. bf891ce4 Refactor module name to be dynamic. 8450d601 Optimize vector creation in compile_commands_writer.cc. 6e0b557d Run 'tools/run_formatter.sh' ab6f8b21 Implement `string_hash` function.
At least this one is needed by Chromium 145. Its do_configure failed due to missing function.
Quoted 8 lines
d92aee22Supportweak_libraries4619125bDo not add .inputdeps paths to --ninja-outputs-filefb3b73dfMake clang modules output -fmodule-file=foo=<pcm>.e7f32021Add --file_relation to gn refs command20a6b6d6Optimize vector initialization and preallocation in desc_builder.cc.a0c5124aAddreservestatement when vector size is known beforehand.092f4f0dRefactor container update by preferring the range insert.
Quoted 8 lines
If you want a shared repo with an upgraded gn for LTS, what do you think about creating a mixin layer?
https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#LTS_%E2%80%9CMixin%E2%80%9D_repositories
https://git.yoctoproject.org/meta-lts-mixinsFor whinlatter (stable but not a LTS) which have more or less a month of support left, the bbappend in your layer is, IMHO, the realistic solution.
meta-browser is not my layer, I just create PRs for it. Thanks, anyway.
cc-ed the maintainer of meta-browser.
Maybe it would be best to branch off whinlatter and cherry-pick new versions and add the gn bbappend there later.