linker_lists.h: drop never used ll_start, ll_end macros
PATCH 1/1 linker_lists.h: drop never used ll_start, ll_end macros
These macros have AFAICT never been used at all. It's also far from clear what purpose it could serve - for one thing, what _type would one pass, other than void perhaps? The example using "struct my_sub_cmd" seems misplaced, as how could one know that the first linker list consists of those, and moreover, how would one know how many there are?
The linker list concept is fragile enough on its own, there is no need to have unused functionality lying around that may or may not bitrot and certainly will confuse readers of linker_lists.h.
--- include/linker_lists.h | 50 ------------------------------------------ 1 file changed, 50 deletions(-)
include/linker_lists.h +0 -50
@@ -288,56 +288,6 @@#define ll_entry_ref (_type, _name, _list) \ ((_type *)&_u_boot_list_2_##_list##_2_##_name) -/** -* ll_start() - Point to first entry of first linker-generated array -* @_type: Data type of the entry -* -* This function returns ``(_type *)`` pointer to the very first entry of -* the very first linker-generated array. -* -* Since this macro defines the start of the linker-generated arrays, -* its leftmost index must be 1. -* -* Example: -* -* :: -* -* struct my_sub_cmd *msc = ll_start(struct my_sub_cmd); -*/ -#define ll_start (_type) \ -({ \ - static char start[0] __aligned(4) __attribute__((unused)) \ - __section("__u_boot_list_1"); \ - _type * tmp = (_type *)&start; \ - asm("":"+r"(tmp)); \ - tmp; \ -}) - -/** -* ll_end() - Point after last entry of last linker-generated array -* @_type: Data type of the entry -* -* This function returns ``(_type *)`` pointer after the very last entry of -* the very last linker-generated array. -* -* Since this macro defines the end of the linker-generated arrays, -* its leftmost index must be 3. -* -* Example: -* -* :: -* -* struct my_sub_cmd *msc = ll_end(struct my_sub_cmd); -*/ -#define ll_end (_type) \ -({ \ - static char end[0] __aligned(4) __attribute__((unused)) \ - __section("__u_boot_list_3"); \ - _type * tmp = (_type *)&end; \ - asm("":"+r"(tmp)); \ - tmp; \ -}) -#endif /* __ASSEMBLY__ */ #endif /* __LINKER_LISTS_H__ */
Signature · 1 line
2.53.0
Quoted 10 lines · Rasmus Villemoes
linker_lists.h: drop never usedll_start,ll_endmacroslinker_lists.h: drop never usedll_start,ll_endmacrosThese macros have AFAICT never been used at all. It's also far from clear what purpose it could serve - for one thing, what
_typewould one pass, other than void perhaps? The example using "structmy_sub_cmd" seems misplaced, as how could one know that the first linker list consists of those, and moreover, how would one know how many there are?
Quoted 8 lines
The linker list concept is fragile enough on its own, there is no need to have unused functionality lying around that may or may not bitrot and certainly will confuse readers of
linker_lists.h.Signed-off-by Rasmus Villemoes <[email protected]>
include/linker_lists.h| 50 --------------------------------------------------1 file changed, 50 deletions(-)
Quoted 8 lines · Rasmus Villemoes
These macros have AFAICT never been used at all. It's also far from clear what purpose it could serve - for one thing, what
_typewould one pass, other than void perhaps? The example using "structmy_sub_cmd" seems misplaced, as how could one know that the first linker list consists of those, and moreover, how would one know how many there are?[...]
Applied to u-boot/master, thanks!
[1/1] linker_lists.h: drop never used ll_start, ll_end macros
commit: e2138cf1e6088f12ffa874e87cc8f4b198378635
Signature · 1 line
Tom