Skip to contentSkip to conversation

arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions

PATCH Applied Val Packett 4 participants 4 messages Mar 23 – Mar 26

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Val Packett

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions

Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm for I2S output.

Signed-off-by Val Packett <[email protected]>

---
Similar to ff9c117c32bc6ace7 which just landed, this is for the other MI2S interface on there. It is the Senary MI2S, so actually using it requires the series from [1] and then more changes on top, but I have sound working on my device with it, so let's get this DT chunk in first / at the same time as the other prereqs land as well.

[1]: https://lore.kernel.org/all/[email protected]/

Thanks,
~val

---
 arch/arm64/boot/dts/qcom/kodiak.dtsi | 52 ++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
arch/arm64/boot/dts/qcom/kodiak.dtsi +52 -0
index 343da1b18095..f393d1c22223 100644
@@ -3088,6 +3088,58 @@ data-pins {
 				};
 			};
 
+			lpass_i2s2_active: i2s2-active-state {
+				clk-pins {
+					pins = "gpio10";
+					function = "i2s2_clk";
+					drive-strength = <8>;
+					bias-disable;
+					output-high;
+				};
+
+				ws-pins {
+					pins = "gpio11";
+					function = "i2s2_ws";
+					drive-strength = <8>;
+					bias-disable;
+					output-high;
+				};
+
+				data-pins {
+					pins = "gpio12", "gpio13";
+					function = "i2s2_data";
+					drive-strength = <8>;
+					bias-disable;
+					output-high;
+				};
+			};
+
+			lpass_i2s2_sleep: i2s2-sleep-state {
+				clk-pins {
+					pins = "gpio10";
+					function = "i2s2_clk";
+					drive-strength = <2>;
+					bias-pull-down;
+					input-enable;
+				};
+
+				ws-pins {
+					pins = "gpio11";
+					function = "i2s2_ws";
+					drive-strength = <2>;
+					bias-pull-down;
+					input-enable;
+				};
+
+				data-pins {
+					pins = "gpio12", "gpio13";
+					function = "i2s2_data";
+					drive-strength = <2>;
+					bias-pull-down;
+					input-enable;
+				};
+			};
+
 			lpass_rx_swr_clk: rx-swr-clk-state {
 				pins = "gpio3";
 				function = "swr_rx_clk";
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Val Packett

Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm for I2S output.

Signed-off-by Val Packett <[email protected]>

---
Similar to ff9c117c32bc6ace7 which just landed, this is for the other MI2S interface on there. It is the Senary MI2S, so actually using it requires the series from [1] and then more changes on top, but I have sound working on my device with it, so let's get this DT chunk in first / at the same time as the other prereqs land as well.

Quoted 8 lines

[1]: https://lore.kernel.org/all/[email protected]/

Thanks,
~val

---
 arch/arm64/boot/dts/qcom/kodiak.dtsi | 52 ++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes
Dmitry
Reviewed-by on v1 1/1
#2 lore raw
In reply to Val Packett
Quoted 11 lines · Val Packett

Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm for I2S output.

Signed-off-by Val Packett <[email protected]>

---
Similar to ff9c117c32bc6ace7 which just landed, this is for the other MI2S interface on there. It is the Senary MI2S, so actually using it requires the series from [1] and then more changes on top, but I have sound working on my device with it, so let's get this DT chunk in first / at the same time as the other prereqs land as well.

Quoted 4 lines

[1]: https://lore.kernel.org/all/[email protected]/

Thanks,
~val

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

maintainer Applied
#3 lore raw
In reply to Val Packett
Quoted 4 lines · Val Packett

Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm for I2S output.

Applied, thanks!

[1/1] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions

      commit: 5e25296941545e4739bbdec8084185b1a945381f

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>