Skip to contentSkip to conversation

generic/730: skip test if DAX mount option is enabled

PATCH In review Disha Goel 3 participants 3 messages Mar 23 – Apr 1

lore
Share & tools
lore

Disha Goel

author
#0 lore raw

PATCH v2 1/1 generic/730: skip test if DAX mount option is enabled

The generic/730 test utilizes the scsi_debug driver to create a synthetic SCSI block device. Since scsi_debug does not support DAX capabilities, attempting to mount it with "-o dax" results in failures (specifically on ext4).

Since this test is not DAX-related, exclude it when DAX is specified in MOUNT_OPTIONS to avoid compatibility issues with scsi_debug.

---
Changelog v1 -> v2:
Use _exclude_scratch_mount_option instead of an ext4-specific check.

Link to v1:
https://lore.kernel.org/all/[email protected]/

---
 tests/generic/730 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/730 +1 -1
index 6b5d3196..47073f42 100755
@@ -19,7 +19,7 @@ _cleanup()
 
 . ./common/filter
 . ./common/scsi_debug
-
+_exclude_scratch_mount_option "dax"
 
 # We don't actually use the test device, but we need a block based fs
 _require_test
Signature · 1 line
2.45.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 5 lines · Disha Goel

The generic/730 test utilizes the scsi_debug driver to create a synthetic SCSI block device. Since scsi_debug does not support DAX capabilities, attempting to mount it with "-o dax" results in failures (specifically on ext4).

Quoted 8 lines

Since this test is not DAX-related, exclude it when DAX is specified in MOUNT_OPTIONS to avoid compatibility issues with scsi_debug.

---
Changelog v1 -> v2:
Use _exclude_scratch_mount_option instead of an ext4-specific check.

This version is good to me, although g/730 doesn't have _require_scratch :)

Quoted 24 lines

Link to v1:
https://lore.kernel.org/all/[email protected]/

---
 tests/generic/730 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/730 +1 -1
index 6b5d3196..47073f42 100755
@@ -19,7 +19,7 @@ _cleanup()
 
 . ./common/filter
 . ./common/scsi_debug
-
+_exclude_scratch_mount_option "dax"
 
 # We don't actually use the test device, but we need a block based fs
 _require_test
Signature · 1 line
2.45.1
Reviewed-by on v2 1/1
#2 lore raw
In reply to Disha Goel
Quoted 25 lines · Disha Goel

The generic/730 test utilizes the scsi_debug driver to create a synthetic SCSI block device. Since scsi_debug does not support DAX capabilities, attempting to mount it with "-o dax" results in failures (specifically on ext4).

Since this test is not DAX-related, exclude it when DAX is specified in MOUNT_OPTIONS to avoid compatibility issues with scsi_debug.

---
Changelog v1 -> v2:
Use _exclude_scratch_mount_option instead of an ext4-specific check.

Link to v1:
https://lore.kernel.org/all/[email protected]/

---
 tests/generic/730 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/730 +0 -0
index 6b5d3196..47073f42 100755

tests/generic/730 _cleanup() · line 25

Quoted 8 lines
tests/generic/730 +1 -1
@@ -19,7 +19,7 @@ _cleanup()
 
 . ./common/filter
 . ./common/scsi_debug
-
+_exclude_scratch_mount_option "dax"
 
 # We don't actually use the test device, but we need a block based fs
 _require_test

Looks good Disha, feel free to add

Regards,
Ojaswin

Quoted 3 lines
Signature · 1 line
2.45.1