Skip to contentSkip to conversation

input: Correct dependencies for CROS_EC_KEYB

PATCH In review Tom Rini 1 participant 2 messages Mar 23 – Apr 7 Input drivers

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 input: Correct dependencies for CROS_EC_KEYB

The CROS_EC_KEYB functionality can only work with CROS_EC enabled, so express this dependency in Kconfig, for all build phases.

---
 drivers/input/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/input/Kconfig +3 -3
index 5bf122c55051..df8fbf1551de 100644
@@ -64,7 +64,7 @@ config CPCAP_POWER_BUTTON
 
 config CROS_EC_KEYB
 	bool "Enable Chrome OS EC keyboard support"
-	depends on INPUT
+	depends on INPUT && CROS_EC
 	help
 	  Most ARM Chromebooks use an EC to provide access to the keyboard.
 	  Messages are used to request key scans from the EC and these are
@@ -72,7 +72,7 @@ config CROS_EC_KEYB
 
 config SPL_CROS_EC_KEYB
 	bool "Enable Chrome OS EC keyboard support in SPL"
-	depends on SPL_INPUT
+	depends on SPL_INPUT && SPL_CROS_EC
 	help
 	  Most ARM Chromebooks use an EC to provide access to the keyboard.
 	  Messages are used to request key scans from the EC and these are
@@ -80,7 +80,7 @@ config SPL_CROS_EC_KEYB
 
 config TPL_CROS_EC_KEYB
 	bool "Enable Chrome OS EC keyboard support in TPL"
-	depends on TPL_INPUT
+	depends on TPL_INPUT && TPL_CROS_EC
 	help
 	  Most ARM Chromebooks use an EC to provide access to the keyboard.
 	  Messages are used to request key scans from the EC and these are
Signature · 1 line
2.43.0
author
#1 lore raw
Quoted 4 lines · Tom Rini

The CROS_EC_KEYB functionality can only work with CROS_EC enabled, so express this dependency in Kconfig, for all build phases.

Applied to u-boot/master, thanks!

[1/1] input: Correct dependencies for CROS_EC_KEYB

      commit: ff031c34210f3c573dbb84196dadf0c4f2017aca
Signature · 1 line
Tom