iio: adc: ti-ads8688: use read_avail for available attributes
PATCH 1/1 iio: adc: ti-ads8688: use read_avail for available attributes
Convert the in_voltage_scale_available and in_voltage_offset_available attributes from legacy IIO_DEVICE_ATTR with custom show functions to the IIO framework's read_avail callback. This uses the framework's built-in support for _available attributes, removing the need for manual sysfs formatting.
Precompute the available scale values at probe time since they depend on the reference voltage which does not change after initialization.
--- drivers/iio/adc/ti-ads8688.c | 73 +++++++++++++++++++----------------- 1 file changed, 38 insertions(+), 35 deletions(-)
drivers/iio/adc/ti-ads8688.c +38 -35
@@ -6,7 +6,6 @@#include <linux/device.h> #include <linux/kernel.h> #include <linux/slab.h> -#include <linux/sysfs.h> #include <linux/spi/spi.h> #include <linux/regulator/consumer.h> #include <linux/err.h>
@@ -17,7 +16,6 @@#include <linux/iio/buffer.h> #include <linux/iio/trigger_consumer.h> #include <linux/iio/triggered_buffer.h> -#include <linux/iio/sysfs.h> #define ADS8688_CMD_REG (x) (x << 8)#define ADS8688_CMD_REG_NOOP 0x00
@@ -66,6 +64,7 @@ struct ads8688_state {const struct ads8688_chip_info *chip_info;struct spi_device *spi;unsigned int vref_mv; +int scale_avail[3 ][2 ];enum ads8688_range range[8 ];union {__be32 d32;
@@ -114,37 +113,9 @@ static const struct ads8688_ranges ads8688_range_def[5] = { } }; -static ssize_t ads8688_show_scales (struct device *dev, -struct device_attribute *attr,char *buf) -{ -struct ads8688_state *st =iio_priv (dev_to_iio_dev (dev)); - -return sprintf (buf,"0.%09u 0.%09u 0.%09u\n" , - ads8688_range_def[0 ].scale * st->vref_mv, - ads8688_range_def[1 ].scale * st->vref_mv, - ads8688_range_def[2 ].scale * st->vref_mv); -} - -static ssize_t ads8688_show_offsets (struct device *dev, -struct device_attribute *attr,char *buf) -{ -return sprintf (buf,"%d %d\n" , ads8688_range_def[0 ].offset, - ads8688_range_def[3 ].offset); -} - -static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, - ads8688_show_scales, NULL, 0); -static IIO_DEVICE_ATTR(in_voltage_offset_available, S_IRUGO, - ads8688_show_offsets, NULL, 0); - -static struct attribute *ads8688_attributes[] = { - &iio_dev_attr_in_voltage_scale_available.dev_attr.attr, - &iio_dev_attr_in_voltage_offset_available.dev_attr.attr, -NULL , -}; - -static const struct attribute_group ads8688_attribute_group = { - .attrs = ads8688_attributes, +static const int ads8688_offset_avail[] = { + -(1 << (ADS8688_REALBITS -1 )), +0 , };#define ADS8688_CHAN (index) \
@@ -155,6 +126,9 @@ static const struct attribute_group ads8688_attribute_group = { .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) \ |BIT (IIO_CHAN_INFO_SCALE ) \ | BIT(IIO_CHAN_INFO_OFFSET), \ + .info_mask_shared_by_type_available = \ +BIT (IIO_CHAN_INFO_SCALE ) \ + | BIT(IIO_CHAN_INFO_OFFSET), \ .scan_index = index, \ .scan_type = { \ .sign = 'u', \
@@ -369,11 +343,34 @@ static int ads8688_write_raw_get_fmt(struct iio_dev *indio_dev,return -EINVAL ; } +static int ads8688_read_avail (struct iio_dev *indio_dev, +struct iio_chan_spec const *chan, +const int **vals,int *type,int *length, +long mask) +{ +struct ads8688_state *st =iio_priv (indio_dev); + +switch (mask) { +case IIO_CHAN_INFO_SCALE : + *vals = (const int *)st->scale_avail; + *type =IIO_VAL_INT_PLUS_NANO ; + *length =ARRAY_SIZE (st->scale_avail) *2 ; +return IIO_AVAIL_LIST ; +case IIO_CHAN_INFO_OFFSET : + *vals = ads8688_offset_avail; + *type =IIO_VAL_INT ; + *length =ARRAY_SIZE (ads8688_offset_avail); +return IIO_AVAIL_LIST ; +default : +return -EINVAL ; + } +} +static const struct iio_info ads8688_info = { .read_raw = &ads8688_read_raw, + .read_avail = &ads8688_read_avail, .write_raw = &ads8688_write_raw, .write_raw_get_fmt = &ads8688_write_raw_get_fmt, - .attrs = &ads8688_attribute_group, };static irqreturn_t ads8688_trigger_handler (int irq,void *p)
@@ -412,7 +409,7 @@ static int ads8688_probe(struct spi_device *spi) {struct ads8688_state *st;struct iio_dev *indio_dev; -int ret; +int ret, i; indio_dev =devm_iio_device_alloc (&spi->dev,sizeof (*st));if (indio_dev ==NULL )
@@ -426,6 +423,12 @@ static int ads8688_probe(struct spi_device *spi) st->vref_mv = ret == -ENODEV ?ADS8688_VREF_MV : ret /1000 ; +for (i =0 ; i <ARRAY_SIZE (st->scale_avail); i++) { + st->scale_avail[i][0 ] =0 ; + st->scale_avail[i][1 ] = ads8688_range_def[i].scale * + st->vref_mv; + } + st->chip_info = &ads8688_chip_info_tbl[spi_get_device_id (spi)->driver_data]; spi->mode =SPI_MODE_1 ;
Signature · 1 line
2.33.0
Quoted 11 lines · Gabriel Rondon
Convert the
in_voltage_scale_availableandin_voltage_offset_availableattributes from legacyIIO_DEVICE_ATTRwith custom show functions to the IIO framework'sread_availcallback. This uses the framework's built-in support for_availableattributes, removing the need for manual sysfs formatting.Precompute the available scale values at probe time since they depend on the reference voltage which does not change after initialization.
Signed-off-by Gabriel Rondon <[email protected]>---
Hi Grabriel,
Thanks for your patch, just some minor nits from me. Anyways:
Quoted 119 lines
drivers/iio/adc/ti-ads8688.c | 73 +++++++++++++++++++-----------------
1 file changed, 38 insertions(+), 35 deletions(-)drivers/iio/adc/ti-ads8688.c +0
-2@@ -6,7 +6,6 @@ #include <linux/device.h> #include <linux/kernel.h> #include <linux/slab.h> -#include <linux/sysfs.h> #include <linux/spi/spi.h> #include <linux/regulator/consumer.h> #include <linux/err.h>@@ -17,7 +16,6 @@ #include <linux/iio/buffer.h> #include <linux/iio/trigger_consumer.h> #include <linux/iio/triggered_buffer.h> -#include <linux/iio/sysfs.h>
#defineADS8688_CMD_REG(x)(x << 8)
#defineADS8688_CMD_REG_NOOP0x00drivers/iio/adc/ti-ads8688.c +1
-0@@ -66,6 +64,7 @@ struct ads8688_state { const struct ads8688_chip_info *chip_info; struct spi_device *spi; unsigned int vref_mv; +int scale_avail[3 ][2 ]; enum ads8688_range range[8]; union { __be32 d32;@@ -114,37 +113,9 @@ static const struct ads8688_ranges ads8688_range_def[5] = { } };drivers/iio/adc/ti-ads8688.c +3
-31-static ssize_t ads8688_show_scales (struct device *dev, - struct device_attribute *attr, char *buf) -{ -struct ads8688_state *st =iio_priv (dev_to_iio_dev (dev)); - -return sprintf (buf,"0.%09u 0.%09u 0.%09u\n" , - ads8688_range_def[0].scale * st->vref_mv, - ads8688_range_def[1].scale * st->vref_mv, - ads8688_range_def[2].scale * st->vref_mv); -} - -static ssize_t ads8688_show_offsets (struct device *dev, - struct device_attribute *attr, char *buf) -{ -return sprintf (buf,"%d %d\n" , ads8688_range_def[0 ].offset, - ads8688_range_def[3].offset); -} - -static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, - ads8688_show_scales, NULL, 0); -static IIO_DEVICE_ATTR(in_voltage_offset_available, S_IRUGO, - ads8688_show_offsets, NULL, 0); - -static struct attribute *ads8688_attributes[] = { - &iio_dev_attr_in_voltage_scale_available.dev_attr.attr, - &iio_dev_attr_in_voltage_offset_available.dev_attr.attr, -NULL , -}; - -static const struct attribute_group ads8688_attribute_group = { - .attrs = ads8688_attributes, +static const int ads8688_offset_avail[] = { + -(1 << (ADS8688_REALBITS -1 )), +0 ,};
#defineADS8688_CHAN(index)\drivers/iio/adc/ti-ads8688.c +3
-0@@ -155,6 +126,9 @@ static const struct attribute_group ads8688_attribute_group = { .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) \ | BIT(IIO_CHAN_INFO_SCALE) \ | BIT(IIO_CHAN_INFO_OFFSET), \ + .info_mask_shared_by_type_available = \ + BIT(IIO_CHAN_INFO_SCALE) \ + | BIT(IIO_CHAN_INFO_OFFSET), \ .scan_index = index, \ .scan_type = { \ .sign = 'u', \@@ -369,11 +343,34 @@ static int ads8688_write_raw_get_fmt(struct iio_dev *indio_dev, return -EINVAL; }drivers/iio/adc/ti-ads8688.c +23
-0+static int ads8688_read_avail (struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ +struct ads8688_state *st =iio_priv (indio_dev); + +switch (mask) { +case IIO_CHAN_INFO_SCALE : + *vals = (const int *)st->scale_avail; + *type =IIO_VAL_INT_PLUS_NANO ; + *length =ARRAY_SIZE (st->scale_avail) *2 ; +return IIO_AVAIL_LIST ; +case IIO_CHAN_INFO_OFFSET : + *vals = ads8688_offset_avail; + *type =IIO_VAL_INT ; + *length =ARRAY_SIZE (ads8688_offset_avail); +return IIO_AVAIL_LIST ; +default : +return -EINVAL ; + } +} +static const struct
iio_infoads8688_info= {
.read_raw =&ads8688_read_raw,drivers/iio/adc/ti-ads8688.c +1
-0+ .read_avail = &ads8688_read_avail,.write_raw =
&ads8688_write_raw, .write_raw_get_fmt =&ads8688_write_raw_get_fmt,drivers/iio/adc/ti-ads8688.c +0
-1- .attrs = &ads8688_attribute_group,};
staticirqreturn_tads8688_trigger_handler(int irq, void *p)
drivers/iio/adc/ti-ads8688.c static int ads8688_probe(struct spi_device *spi) · line 412
Quoted 5 lines
drivers/iio/adc/ti-ads8688.c +1
-1@@ -412,7 +409,7 @@ static int ads8688_probe(struct spi_device *spi) { struct ads8688_state *st; struct iio_dev *indio_dev; -int ret; +int ret, i;
These days you could just declare i in the for() loop and make it unsigned int.
drivers/iio/adc/ti-ads8688.c static int ads8688_probe(struct spi_device *spi) · line 430
Quoted 12 lines
indio_dev=devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (indio_dev== NULL)drivers/iio/adc/ti-ads8688.c +0
-0@@ -426,6 +423,12 @@ static int ads8688_probe(struct spi_device *spi)
st->vref_mv= ret ==-ENODEV?ADS8688_VREF_MV: ret / 1000;drivers/iio/adc/ti-ads8688.c +5
-0+for (i =0 ; i <ARRAY_SIZE (st->scale_avail); i++) { + st->scale_avail[i][0 ] =0 ; + st->scale_avail[i][1 ] = ads8688_range_def[i].scale * + st->vref_mv; + }
Even though the above crosses the column preferred limit, I don't think the line break hurts readability.
- Nuno Sá
Quoted 1 line
Quoted 8 lines · Gabriel Rondon
Convert the
in_voltage_scale_availableandin_voltage_offset_availableattributes from legacyIIO_DEVICE_ATTRwith custom show functions to the IIO framework'sread_availcallback. This uses the framework's built-in support for_availableattributes, removing the need for manual sysfs formatting.Precompute the available scale values at probe time since they depend on the reference voltage which does not change after initialization.
...
drivers/iio/adc/ti-ads8688.c static const struct ads8688_ranges ads8688_range_def[5] = { · line 117
Quoted 2 lines
drivers/iio/adc/ti-ads8688.c +2
-0+static const int ads8688_offset_avail[] = { + -(1 << (ADS8688_REALBITS -1 )),
This is fragile code (however it probably won't be exposed IRL) if ADS8688_REALBITS == 32 this is UB in accordance with C standard.
Also the trick with -BIT(x) is harder to read than simple GENMASK(). If ADS8688_REALBITS == 1, this becomes -1 (all ones), is it correct?
drivers/iio/adc/ti-ads8688.c static const struct ads8688_ranges ads8688_range_def[5] = { · line 118
Quoted 1 line
drivers/iio/adc/ti-ads8688.c +1
-0+ 0,
Do not add trailing comma to a terminator.
Quoted 1 line
};
...
drivers/iio/adc/ti-ads8688.c static const struct attribute_group ads8688_attribute_group = { · line 131
Quoted 8 lines
static const struct
attribute_groupads8688_attribute_group= {drivers/iio/adc/ti-ads8688.c +3
-0.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) \ |BIT (IIO_CHAN_INFO_SCALE ) \ | BIT(IIO_CHAN_INFO_OFFSET), \ + .info_mask_shared_by_type_available = \ +BIT (IIO_CHAN_INFO_SCALE ) \ + | BIT(IIO_CHAN_INFO_OFFSET), \
This is actually slightly different style to what is put in the above. Ideally should be unified, but probably matter for another change (if even needed).
Quoted 5 lines
drivers/iio/adc/ti-ads8688.c +0
-0.scan_index = index, \ .scan_type = { \ .sign = 'u', \ }
...
drivers/iio/adc/ti-ads8688.c static int ads8688_probe(struct spi_device *spi) · line 412
Quoted 2 lines
drivers/iio/adc/ti-ads8688.c +1
-1-int ret; +int ret, i;
Why is 'i' signed?
...
drivers/iio/adc/ti-ads8688.c static int ads8688_probe(struct spi_device *spi) · line 426
Quoted 1 line
drivers/iio/adc/ti-ads8688.c +1
-0+for (i =0 ; i <ARRAY_SIZE (st->scale_avail); i++) {
for (unsigned int i = 0; i < ARRAY_SIZE(st->scale_avail); i++) {should be good.
drivers/iio/adc/ti-ads8688.c static int ads8688_probe(struct spi_device *spi) · line 429
Quoted 4 lines
drivers/iio/adc/ti-ads8688.c +3
-0+ st->scale_avail[i][0 ] =0 ; + st->scale_avail[i][1 ] = ads8688_range_def[i].scale * + st->vref_mv;
I would leave this on a single line (it's only 81 characters).
Quoted 1 line
(quoted diff) +1
-0+ }
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
This is fragile code (however it probably won't be exposed IRL) if
ADS8688_REALBITS== 32 this is UB in accordance with C standard.Also the trick with -BIT(x) is harder to read than simple
GENMASK().
Good point. Will rework the expression in v2.
Quoted 1 line
Do not add trailing comma to a terminator.
Will fix.
Quoted 2 lines
This is actually slightly different style to what is put in the above. Ideally should be unified, but probably matter for another change
Agreed, will leave for a separate change.
Quoted 1 line
Why is 'i' signed?
Will declare as unsigned int in the for loop.
Quoted 1 line
I would leave this on a single line (it's only 81 characters).
Will do.
Thanks for the review.
Gabriel
Quoted 1 line · Nuno Sá
Reviewed-by Nuno Sá <[email protected]>
Thanks for the review.
Quoted 2 lines
These days you could just declare i in the
for()loop and make it unsigned int.
Will do.
Gabriel
Quoted 147 lines · Nuno Sá
Quoted 11 lines · Gabriel Rondon
Convert the
in_voltage_scale_availableandin_voltage_offset_availableattributes from legacyIIO_DEVICE_ATTRwith custom show functions to the IIO framework'sread_availcallback. This uses the framework's built-in support for_availableattributes, removing the need for manual sysfs formatting.Precompute the available scale values at probe time since they depend on the reference voltage which does not change after initialization.
Signed-off-by Gabriel Rondon <[email protected]>---
Hi Grabriel,
Thanks for your patch, just some minor nits from me. Anyways:
Reviewed-by Nuno Sá <[email protected]>Quoted 119 lines
drivers/iio/adc/ti-ads8688.c | 73 +++++++++++++++++++-----------------
1 file changed, 38 insertions(+), 35 deletions(-)drivers/iio/adc/ti-ads8688.c +0
-2@@ -6,7 +6,6 @@ #include <linux/device.h> #include <linux/kernel.h> #include <linux/slab.h> -#include <linux/sysfs.h> #include <linux/spi/spi.h> #include <linux/regulator/consumer.h> #include <linux/err.h>@@ -17,7 +16,6 @@ #include <linux/iio/buffer.h> #include <linux/iio/trigger_consumer.h> #include <linux/iio/triggered_buffer.h> -#include <linux/iio/sysfs.h>
#defineADS8688_CMD_REG(x)(x << 8)
#defineADS8688_CMD_REG_NOOP0x00drivers/iio/adc/ti-ads8688.c +1
-0@@ -66,6 +64,7 @@ struct ads8688_state { const struct ads8688_chip_info *chip_info; struct spi_device *spi; unsigned int vref_mv; +int scale_avail[3 ][2 ]; enum ads8688_range range[8]; union { __be32 d32;@@ -114,37 +113,9 @@ static const struct ads8688_ranges ads8688_range_def[5] = { } };drivers/iio/adc/ti-ads8688.c +3
-31-static ssize_t ads8688_show_scales (struct device *dev, - struct device_attribute *attr, char *buf) -{ -struct ads8688_state *st =iio_priv (dev_to_iio_dev (dev)); - -return sprintf (buf,"0.%09u 0.%09u 0.%09u\n" , - ads8688_range_def[0].scale * st->vref_mv, - ads8688_range_def[1].scale * st->vref_mv, - ads8688_range_def[2].scale * st->vref_mv); -} - -static ssize_t ads8688_show_offsets (struct device *dev, - struct device_attribute *attr, char *buf) -{ -return sprintf (buf,"%d %d\n" , ads8688_range_def[0 ].offset, - ads8688_range_def[3].offset); -} - -static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, - ads8688_show_scales, NULL, 0); -static IIO_DEVICE_ATTR(in_voltage_offset_available, S_IRUGO, - ads8688_show_offsets, NULL, 0); - -static struct attribute *ads8688_attributes[] = { - &iio_dev_attr_in_voltage_scale_available.dev_attr.attr, - &iio_dev_attr_in_voltage_offset_available.dev_attr.attr, -NULL , -}; - -static const struct attribute_group ads8688_attribute_group = { - .attrs = ads8688_attributes, +static const int ads8688_offset_avail[] = { + -(1 << (ADS8688_REALBITS -1 )), +0 ,};
#defineADS8688_CHAN(index)\drivers/iio/adc/ti-ads8688.c +3
-0@@ -155,6 +126,9 @@ static const struct attribute_group ads8688_attribute_group = { .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) \ | BIT(IIO_CHAN_INFO_SCALE) \ | BIT(IIO_CHAN_INFO_OFFSET), \ + .info_mask_shared_by_type_available = \ + BIT(IIO_CHAN_INFO_SCALE) \ + | BIT(IIO_CHAN_INFO_OFFSET), \ .scan_index = index, \ .scan_type = { \ .sign = 'u', \@@ -369,11 +343,34 @@ static int ads8688_write_raw_get_fmt(struct iio_dev *indio_dev, return -EINVAL; }drivers/iio/adc/ti-ads8688.c +23
-0+static int ads8688_read_avail (struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ +struct ads8688_state *st =iio_priv (indio_dev); + +switch (mask) { +case IIO_CHAN_INFO_SCALE : + *vals = (const int *)st->scale_avail; + *type =IIO_VAL_INT_PLUS_NANO ; + *length =ARRAY_SIZE (st->scale_avail) *2 ; +return IIO_AVAIL_LIST ; +case IIO_CHAN_INFO_OFFSET : + *vals = ads8688_offset_avail; + *type =IIO_VAL_INT ; + *length =ARRAY_SIZE (ads8688_offset_avail); +return IIO_AVAIL_LIST ; +default : +return -EINVAL ; + } +} +static const struct
iio_infoads8688_info= {
.read_raw =&ads8688_read_raw,drivers/iio/adc/ti-ads8688.c +1
-0+ .read_avail = &ads8688_read_avail,.write_raw =
&ads8688_write_raw, .write_raw_get_fmt =&ads8688_write_raw_get_fmt,drivers/iio/adc/ti-ads8688.c +0
-1- .attrs = &ads8688_attribute_group,};
staticirqreturn_tads8688_trigger_handler(int irq, void *p)drivers/iio/adc/ti-ads8688.c static int ads8688_probe(struct spi_device *spi) · line 412
Quoted 5 lines
drivers/iio/adc/ti-ads8688.c +1
-1@@ -412,7 +409,7 @@ static int ads8688_probe(struct spi_device *spi) { struct ads8688_state *st; struct iio_dev *indio_dev; -int ret; +int ret, i;These days you could just declare i in the
for()loop and make it unsigned int.
Quoted 15 lines
drivers/iio/adc/ti-ads8688.c static int ads8688_probe(struct spi_device *spi) · line 430
Quoted 12 lines
indio_dev=devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (indio_dev== NULL)drivers/iio/adc/ti-ads8688.c +0
-0@@ -426,6 +423,12 @@ static int ads8688_probe(struct spi_device *spi)
st->vref_mv= ret ==-ENODEV?ADS8688_VREF_MV: ret / 1000;drivers/iio/adc/ti-ads8688.c +5
-0+for (i =0 ; i <ARRAY_SIZE (st->scale_avail); i++) { + st->scale_avail[i][0 ] =0 ; + st->scale_avail[i][1 ] = ads8688_range_def[i].scale * + st->vref_mv; + }Even though the above crosses the column preferred limit, I don't think the line break hurts readability.
Naturally I meant that the line break __hurts__ (to me at least :))
- Nuno Sá
Quoted 3 lines
- Nuno Sá
Quoted 1 line
Jonathan Cameron
maintainerQuoted 18 lines · On Tue, 24 Mar 2026 13:42:40 +0200 Andy Shevchenko…
Quoted 8 lines · Gabriel Rondon
Convert the
in_voltage_scale_availableandin_voltage_offset_availableattributes from legacyIIO_DEVICE_ATTRwith custom show functions to the IIO framework'sread_availcallback. This uses the framework's built-in support for_availableattributes, removing the need for manual sysfs formatting.Precompute the available scale values at probe time since they depend on the reference voltage which does not change after initialization.
...
drivers/iio/adc/ti-ads8688.c static const struct ads8688_ranges ads8688_range_def[5] = { · line 117
Quoted 2 lines
drivers/iio/adc/ti-ads8688.c +2
-0+static const int ads8688_offset_avail[] = { + -(1 << (ADS8688_REALBITS -1 )),This is fragile code (however it probably won't be exposed IRL) if
ADS8688_REALBITS== 32 this is UB in accordance with C standard.
Quoted 4 lines
Also the trick with -BIT(x) is harder to read than simple
GENMASK(). IfADS8688_REALBITS== 1, this becomes -1 (all ones), is it correct?drivers/iio/adc/ti-ads8688.c static const struct ads8688_ranges ads8688_range_def[5] = { · line 118
Quoted 1 line
drivers/iio/adc/ti-ads8688.c +1
-0+ 0,
Replying here because the follow up lost too much context. This is a classic offset for bipolar ADC, which is - half the full range binary value. So we won't hit the edge cases, but maybe expressing it different will be clearer.
-(GENMASK(ADS8688_REALBITS - 1, 0) >> 1) does feel a bit overkill but -GENMASK(ADS8688_REALBITS - 2, 0) feels under explained (much like the current).
We 'could' use -(U16MAX >> 1) but that feels very specific to it being 16 bits.
Maybe just leave this as it already is in the table the value is copied from.