staging: rtl8723bs: fix checkpatch style issues
PATCH 1/1 staging: rtl8723bs: fix checkpatch style issues
Fix minor style issues in hal_com.c reported by checkpatch:
- Remove multiple blank lines
- Remove blank line after open brace
- Fix comparison style (constant on right side)
No functional changes, only coding style fixes.
--- drivers/staging/rtl8723bs/hal/hal_com.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +1 -4
@@ -30,7 +30,6 @@ void rtw_hal_data_deinit(struct adapter *padapter) } } -void dump_chip_info (struct hal_version ChipVersion) {char buf[128 ];
@@ -71,7 +70,6 @@ void dump_chip_info(struct hal_version ChipVersion) cnt +=scnprintf (buf + cnt,sizeof (buf) - cnt,"RomVer(%d)\n" , ChipVersion.ROMVer); } -#define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80/*
@@ -107,7 +105,7 @@ u8 hal_com_config_channel_plan( pHalData->bDisableSWChannelPlan = false; chnlPlan = def_channel_plan; -if (0xFF == hw_channel_plan) +if (hw_channel_plan ==0xFF ) AutoLoadFail = true;if (!AutoLoadFail) {
@@ -294,7 +292,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)u8 i, is_brate, brate;for (i =0 ; i <NDIS_802_11_LENGTH_RATES_EX ; i++) { - is_brate = mBratesOS[i] &IEEE80211_BASIC_RATE_MASK ; brate = mBratesOS[i] &0x7f ;
Signature · 1 line
2.53.0
Quoted 9 lines · MrXploisLite
Fix minor style issues in
hal_com.creported by checkpatch:
- Remove multiple blank lines
- Remove blank line after open brace
- Fix comparison style (constant on right side)No functional changes, only coding style fixes.
Signed-off-by MrXploisLite <[email protected]>---
You need to use your real name when submitting patches. Also, don't use the name of the tool in your subject, it should be something like "Remove unneeded blank lines".
...
drivers/staging/rtl8723bs/hal/hal_com.c u8 hal_com_config_channel_plan( · line 109
Quoted 3 lines
drivers/staging/rtl8723bs/hal/hal_com.c +1
-1-if (0xFF == hw_channel_plan) +if (hw_channel_plan ==0xFF ) AutoLoadFail = true;
Please keep one logical change per patch. The removal of blank lines and correcting comparison orientation are two different changes.
Use "$ ./scripts/checkpatch.pl --strict <patch>" too before sending patches off, it helps catch a lot of easy mistakes.
Thanks,
ET