Skip to contentSkip to conversation

ASoC: Drop some unused GPIO includes

PATCH In review Linus Walleij 2 participants 5 messages Mar 26 – Mar 27

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover ASoC: Drop some unused GPIO includes

This drops the unnecessary legacy includes from three more codecs.

---
Linus Walleij (3):
ASoC: rt1318: Drop unused include
ASoC: nau8315: Drop unused include
ASoC: ts3a227e: Drop unused include

 sound/soc/codecs/nau8315.c  | 1 -
 sound/soc/codecs/rt1318.c   | 1 -
 sound/soc/codecs/ts3a227e.c | 1 -
 3 files changed, 3 deletions(-)

---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260327-asoc-rt1318-1ee6cc1d217d

Best regards,

Signature · 1 line
Linus Walleij <[email protected]>
#1 lore raw

PATCH 1/3 ASoC: rt1318: Drop unused include

The driver includes the legacy GPIO header <linux/gpio.h> but does not use any symbols from it so drop the include.

---
 sound/soc/codecs/rt1318.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/rt1318.c +0 -1
index 01c58b15fd91..a80643099644 100644
@@ -18,7 +18,6 @@
 #include <linux/i2c.h>
 #include <linux/platform_device.h>
 #include <linux/firmware.h>
-#include <linux/gpio.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
Signature · 1 line
2.53.0
#2 lore raw

PATCH 2/3 ASoC: nau8315: Drop unused include

In reply to Linus Walleij

The driver includes the legacy GPIO header <linux/gpio.h> but does not use any symbols from it so drop the include. (It is already using the consumer header as is proper.)

---
 sound/soc/codecs/nau8315.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/nau8315.c +0 -1
index 125742601f88..9ac2048ff0b0 100644
@@ -11,7 +11,6 @@
 #include <linux/acpi.h>
 #include <linux/device.h>
 #include <linux/err.h>
-#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
Signature · 1 line
2.53.0
#3 lore raw

PATCH 3/3 ASoC: ts3a227e: Drop unused include

In reply to Linus Walleij

The driver includes the legacy GPIO header <linux/gpio.h> but does not use any symbols from it so drop the include.

---
 sound/soc/codecs/ts3a227e.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/ts3a227e.c +0 -1
index 5ce0db9326fd..5a7beeadb009 100644
@@ -5,7 +5,6 @@
  * Copyright (C) 2014 Google, Inc.
  */
 
-#include <linux/gpio.h>
 #include <linux/i2c.h>
 #include <linux/init.h>
 #include <linux/input.h>
Signature · 1 line
2.53.0
maintainer
#4 lore raw
In reply to Linus Walleij
Quoted 4 lines · Linus Walleij

ASoC: Drop some unused GPIO includes

This drops the unnecessary legacy includes from three more codecs.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[1/3] ASoC: rt1318: Drop unused include

      https://git.kernel.org/broonie/sound/c/486c06451590
[2/3] ASoC: nau8315: Drop unused include
      https://git.kernel.org/broonie/sound/c/175b2d025874
[3/3] ASoC: ts3a227e: Drop unused include
      https://git.kernel.org/broonie/sound/c/00e981c7c0a1

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark