Skip to contentSkip to conversation

ALSA: hda/intel: Add MSI X870E Tomahawk to denylist by DMI ID

PATCH In review Stuart Hayhurst 3 participants 7 messages Mar 27 – Apr 14 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/intel: Add MSI X870E Tomahawk to denylist by DMI ID

This motherboard uses USB audio instead, causing this driver to complain about "no codecs found!".
Add it to the denylist to silence the warning.

The first attempt only matched on the PCI device, but this caused issues for some laptops, so DMI match against the board as well.

---
 sound/hda/controllers/intel.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
sound/hda/controllers/intel.c +13 -0
index 2edbcab597c8..8a7bd49e411f 100644
@@ -2085,6 +2085,11 @@ static struct pci_device_id driver_denylist_ideapad_z570[] = {
 	{}
 };
 
+static struct pci_device_id driver_denylist_msi_x870e[] = {
+	{ PCI_DEVICE_SUB(0x1022, 0x15e3, 0x1462, 0xee59) }, /* MSI X870E Tomahawk WiFi */
+	{}
+};
+
 /* DMI-based denylist, to be used when:
  *  - PCI subsystem IDs are zero, impossible to distinguish from valid sound cards.
  *  - Different modifications of the same laptop use different GPU models.
@@ -2098,6 +2103,14 @@ static const struct dmi_system_id driver_denylist_dmi[] = {
 		},
 		.driver_data = &driver_denylist_ideapad_z570,
 	},
+	{
+		/* PCI device matching alone incorrectly matches some laptops */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+			DMI_MATCH(DMI_BOARD_NAME, "MAG X870E TOMAHAWK WIFI (MS-7E59)"),
+		},
+		.driver_data = &driver_denylist_msi_x870e,
+	},
 	{}
 };
 
Signature · 1 line
2.53.0
#1 lore raw
Quoted 8 lines · Stuart Hayhurst

This motherboard uses USB audio instead, causing this driver to complain about "no codecs found!".
Add it to the denylist to silence the warning.

The first attempt only matched on the PCI device, but this caused issues for some laptops, so DMI match against the board as well.

Thanks!

Takashi,

Probably worth asking - why is the "no codecs found" ERR in the first place? There are obviously designs out there like this, should the ERR message be simmered down?

Quoted 35 lines
---
  sound/hda/controllers/intel.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)
sound/hda/controllers/intel.c +13 -0
index 2edbcab597c8..8a7bd49e411f 100644
@@ -2085,6 +2085,11 @@ static struct pci_device_id driver_denylist_ideapad_z570[] = {
  	{}
  };
 
+static struct pci_device_id driver_denylist_msi_x870e[] = {
+	{ PCI_DEVICE_SUB(0x1022, 0x15e3, 0x1462, 0xee59) }, /* MSI X870E Tomahawk WiFi */
+	{}
+};
+
  /* DMI-based denylist, to be used when:
   *  - PCI subsystem IDs are zero, impossible to distinguish from valid sound cards.
   *  - Different modifications of the same laptop use different GPU models.
@@ -2098,6 +2103,14 @@ static const struct dmi_system_id driver_denylist_dmi[] = {
  		},
  		.driver_data = &driver_denylist_ideapad_z570,
  	},
+	{
+		/* PCI device matching alone incorrectly matches some laptops */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Micro-Star International Co., Ltd."),
+			DMI_MATCH(DMI_BOARD_NAME, "MAG X870E TOMAHAWK WIFI (MS-7E59)"),
+		},
+		.driver_data = &driver_denylist_msi_x870e,
+	},
  	{}
  };
 
#2 lore raw
Quoted 13 lines · Mario Limonciello
Quoted 8 lines · Stuart Hayhurst

This motherboard uses USB audio instead, causing this driver to complain about "no codecs found!".
Add it to the denylist to silence the warning.

The first attempt only matched on the PCI device, but this caused issues for some laptops, so DMI match against the board as well.

Quoted 7 lines

Thanks!

Takashi,

Probably worth asking - why is the "no codecs found" ERR in the first place? There are obviously designs out there like this, should the ERR message be simmered down?

Although HD-audio is a bus that can be dynamically enabled / disabled codecs, it's been supposed to be rather static and exposed only if there is really a need for it -- that is, only if there is a codec on it. So "no codec" is seen as an error for now if you try to initialize the HD-audio controller.

We may downgrade it, but the situation is still not ideal either; the driver is still bound without serving anything useful, and it needs to react for the PM and other things. Since the probe of codecs happens after the driver probe stage, the driver can't go away by itself, unfortunately.

thanks,

Takashi

#3 lore raw
Quoted 36 lines · Takashi Iwai
Quoted 13 lines · Mario Limonciello
Quoted 8 lines · Stuart Hayhurst

This motherboard uses USB audio instead, causing this driver to complain about "no codecs found!".
Add it to the denylist to silence the warning.

The first attempt only matched on the PCI device, but this caused issues for some laptops, so DMI match against the board as well.

Quoted 7 lines

Thanks!

Takashi,

Probably worth asking - why is the "no codecs found" ERR in the first place? There are obviously designs out there like this, should the ERR message be simmered down?

Although HD-audio is a bus that can be dynamically enabled / disabled codecs, it's been supposed to be rather static and exposed only if there is really a need for it -- that is, only if there is a codec on it. So "no codec" is seen as an error for now if you try to initialize the HD-audio controller.

We may downgrade it, but the situation is still not ideal either; the driver is still bound without serving anything useful, and it needs to react for the PM and other things. Since the probe of codecs happens after the driver probe stage, the driver can't go away by itself, unfortunately.

Quoted 3 lines

thanks,

Takashi

I guess in an ideal world systems like this (where physically there is USB audio and HD audio, but HD audio has no codecs connected to it) the BIOS should avoid exposing the HD audio device on the PCI bus.

Stuart,

In parallel could you try spinning up a thread with your MB vendor? If they're willing, maybe a future BIOS can also stop exposing the HD audio PCI device.

If you end up having a good experience that could be the way we approach this problem in the future.

author
#4 lore raw
Quoted 2 lines

If you end up having a good experience that could be the way we approach this problem in the future.

I can certainly try, but I've already got a pile of issues stacking up that they don't seem to be interested in fixing.

Hopefully this will be a simpler fix for them than the other issues...

author
#5 lore raw
Quoted 2 lines

If you end up having a good experience that could be the way we approach this problem in the future

They just got back to me with a test BIOS that solves the problem BIOS-side

Not sure when it'll be released publicly, but in this case it seems to have worked

Quoted 8 lines · Stuart
Quoted 3 lines

If you end up having a good experience that could be the way we approach this problem in the future.

I can certainly try, but I've already got a pile of issues stacking up that they don't seem to be interested in fixing.

Hopefully this will be a simpler fix for them than the other issues...

#6 lore raw
In reply to Stuart Hayhurst
Quoted 9 lines · Stuart Hayhurst

This motherboard uses USB audio instead, causing this driver to complain about "no codecs found!".
Add it to the denylist to silence the warning.

The first attempt only matched on the PCI device, but this caused issues for some laptops, so DMI match against the board as well.

Although this could be addressed in BIOS, it won't hurt much to take a workaround for now. So I applied this one.

thanks,

Takashi