Mark NeuralDSP Quad Cortex as not supporting DSD playback
cover Mark NeuralDSP Quad Cortex as not supporting DSD playback
USB Vendor ID 0x152a is owned by a company which produces firmware for other company's devices. Some of those devices support DSD playback and some do not.
I'm not totally comfortable adding the first ever zero-quirks device entry to the quirk flags table, but it does appear to have worked.
This patch preserves the current assumption that all of this vendor's devices will support DSD unless explicitly disabled in this way. I will ask them if that is a good assumption and if they can give me a list of existing USB pids and whether they are DSD devices.
Phil Willoughby (1):
NeuralDSP Quad Cortex isn't a DSD Device
sound/usb/quirks.c | 2 ++ 1 file changed, 2 insertions(+)
Signature · 1 line
2.53.0
PATCH 1/1 NeuralDSP Quad Cortex isn't a DSD Device
--- sound/usb/quirks.c | 2 ++ 1 file changed, 2 insertions(+)
sound/usb/quirks.c +2 -0
@@ -2361,6 +2361,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_PLAYBACK_FIRST | QUIRK_FLAG_GENERIC_IMPLICIT_FB),DEVICE_FLG (0x13e5 ,0x0001 ,/* Serato Phono */ QUIRK_FLAG_IGNORE_CTL_ERROR ), +DEVICE_FLG (0x152a ,0x880a ,/* NeuralDSP Quad Cortex */ +0 ),/* Doesn't have the vendor quirk which would otherwise apply */ DEVICE_FLG (0x154e ,0x1002 ,/* Denon DCD-1500RE */ QUIRK_FLAG_ITF_USB_DSD_DAC |QUIRK_FLAG_CTL_MSG_DELAY ), DEVICE_FLG(0x154e, 0x1003, /* Denon DA-300USB */
Signature · 1 line
2.53.0
Re: [PATCH 1/1] NeuralDSP Quad Cortex isn't a DSD Device
Hi Phil,
Quoted 6 lines · Phil Willoughby
Signed-off-by Phil Willoughby <[email protected]>Cc Yue Wang <[email protected]>--- sound/usb/quirks.c | 2 ++ 1 file changed, 2 insertions(+)
Please provide an appropriate commit message and remember to Cc: the relevant maintainers.
Thanks,
Geraldo Nascimento
Quoted 17 lines
sound/usb/quirks.c +2
-0@@ -2361,6 +2361,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_PLAYBACK_FIRST | QUIRK_FLAG_GENERIC_IMPLICIT_FB),DEVICE_FLG (0x13e5 ,0x0001 ,/* Serato Phono */ QUIRK_FLAG_IGNORE_CTL_ERROR ), +DEVICE_FLG (0x152a ,0x880a ,/* NeuralDSP Quad Cortex */ +0 ),/* Doesn't have the vendor quirk which would otherwise apply */ DEVICE_FLG (0x154e ,0x1002 ,/* Denon DCD-1500RE */ QUIRK_FLAG_ITF_USB_DSD_DAC |QUIRK_FLAG_CTL_MSG_DELAY ), DEVICE_FLG(0x154e, 0x1003, /* Denon DA-300USB */Signature · 1 line
2.53.0