Skip to contentSkip to conversation

insane: appendVarFlags must be preceded by a whitespace

PATCH New Shotaro Uchida 1 participant 1 message Mar 27

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 insane: appendVarFlags must be preceded by a whitespace

appendVarFlags is not automatically adding a whitespace, user must add a white space before the value to be added. Current usage may break INSANE_SKIP:${PN} vardeps flag value by adding QAPATHTEST functions immediately without a whitespace. e.g. It will become something like INSANE_SKIP:${PN}package_qa_check_shebang_size

---
 meta/classes-global/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes-global/insane.bbclass +1 -1
index 8bbe5bb19a..4ccc532282 100644
@@ -1207,7 +1207,7 @@ python() {
     funcs = d.getVarFlags("QAPATHTEST")
     funcs.update(d.getVarFlags("QAPKGTEST"))
     funcs.update(d.getVarFlags("QARECIPETEST"))
-    d.appendVarFlag("do_package_qa", "vardeps", " ".join(funcs.values()))
+    d.appendVarFlag("do_package_qa", "vardeps", " {}".format(" ".join(funcs.values())))
 }
 
 SSTATETASKS += "do_package_qa"
Signature · 1 line
2.51.0