Docs/admin-guide/mm/damon: warn commit_inputs vs other params race
Subsystems (5)
SeongJae Park
maintainercover Docs/admin-guide/mm/damon: warn commit_inputs vs other params race
Writing 'Y' to the commit_inputs parameter of DAMON_RECLAIM and DAMON_LRU_SORT, and writing other parameters before the commit_inputs request is completely processed can cause race conditions. While the consequence can be bad, the documentation is not clearly describing that. Add clear warnings.
The issue was discovered [1,2] by sashiko.
[1] https://lore.kernel.org/[email protected]
[2] https://lore.kernel.org/[email protected]
SeongJae Park (2):
Docs/admin-guide/mm/damon/reclaim: warn commit_inputs vs param updates
race
Docs/admin-guide/mm/damon/lru_sort: warn commit_inputs vs param
updates race
Documentation/admin-guide/mm/damon/lru_sort.rst | 4 ++++ Documentation/admin-guide/mm/damon/reclaim.rst | 4 ++++ 2 files changed, 8 insertions(+)
base-commit: 02617badb619e548c4489c371fec5a4ceb0c347e
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 1/2 Docs/admin-guide/mm/damon/reclaim: warn commit_inputs vs param updates race
DAMON_RECLAIM handles commit_inputs request inside kdamond thread, reading the module parameters. If the user updates the module parameters while the kdamond thread is reading those, races can happen. To avoid this, the commit_inputs parameter shows whether it is still in the progress, assuming users wouldn't update parameters in the middle of the work. Some users might ignore that. Add a warning about the behavior.
The issue was discovered [1] by sashiko.
[1] https://lore.kernel.org/[email protected]
--- Documentation/admin-guide/mm/damon/reclaim.rst | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/admin-guide/mm/damon/reclaim.rst +4 -0
@@ -71,6 +71,10 @@ of parameters except ``enabled`` again. Once the re-reading is done, this parameter is set as ``N``. If invalid parameters are found while the re-reading, DAMON_RECLAIM will be disabled. +Once ``Y`` is written to this parametr, the user must not write to any +parameters until reading ``commit_inputs`` again returns ``N``. If users +violate this rule, the kernel can do undefined behaviors. + min_age -------
Signature · 1 line
2.47.3
SeongJae Park
maintainerRFC PATCH 2/2 Docs/admin-guide/mm/damon/lru_sort: warn commit_inputs vs param updates race
In reply to SeongJae ParkDAMON_LRU_SORT handles commit_inputs request inside kdamond thread, reading the module parameters. If the user updates the module parameters while the kdamond thread is reading those, races can happen. To avoid this, the commit_inputs parameter shows whether it is still in the progress, assuming users wouldn't update parameters in the middle of the work. Some users might ignore that. Add a warning about the behavior.
The issue was discovered [1] by sashiko.
[1] https://lore.kernel.org/[email protected]
--- Documentation/admin-guide/mm/damon/lru_sort.rst | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/admin-guide/mm/damon/lru_sort.rst +4 -0
@@ -79,6 +79,10 @@ of parameters except ``enabled`` again. Once the re-reading is done, this parameter is set as ``N``. If invalid parameters are found while the re-reading, DAMON_LRU_SORT will be disabled. +Once ``Y`` is written to this parametr, the user must not write to any +parameters until reading ``commit_inputs`` again returns ``N``. If users +violate this rule, the kernel can do undefined behaviors. + active_mem_bp -------------
Signature · 1 line
2.47.3
SeongJae Park
maintainerRe: (sashiko status) [RFC PATCH 0/2] Docs/admin-guide/mm/damon: warn commit_inputs vs other params race
In reply to SeongJae ParkForwarding sashiko.dev review status for this thread.
# review url: https://sashiko.dev/#/patchset/[email protected]
- [RFC PATCH 1/2] Docs/admin-guide/mm/damon/reclaim: warn commit_inputs vs param updates race
- status: Reviewed
- review: ISSUES MAY FOUND
- [RFC PATCH 2/2] Docs/admin-guide/mm/damon/lru_sort: warn commit_inputs vs param updates race
- status: Reviewed
- review: ISSUES MAY FOUND
# hkml [1] generated a draft of this mail. It can be regenerated # using below command: # # hkml patch sashiko_dev --thread_status --for_forwarding \ # [email protected] # # [1] https://github.com/sjp38/hackermail
Sent using hkml (https://github.com/sjp38/hackermail)
SeongJae Park
maintainerRe: (sashiko review) [RFC PATCH 1/2] Docs/admin-guide/mm/damon/reclaim: warn commit_inputs vs param updates race
In reply to SeongJae ParkForwarding Sashiko review for doing discussions via mails.
# review url: https://sashiko.dev/#/patchset/[email protected] # start of sashiko.dev inline review commit 8b189801fc104c5ecc412454a3d8db6a3faf27d6 Author: SeongJae Park <[email protected]>
Docs/admin-guide/mm/damon/reclaim: warn commit_inputs vs param updates race
This commit adds documentation warning users not to write to module parameters while commit_inputs is in progress. This warning is intended to help users avoid a race condition that can cause undefined kernel behavior.
Documentation/admin-guide/mm/damon/reclaim.rst of parametrs except ``enabled`` again. Once the re-reading is done, this · line 74
Quoted 8 lines
Documentation/admin-guide/mm/damon/reclaim.rst +1
-0@@ -71,6 +71,10 @@ of parametrs except ``enabled`` again. Once the re-reading is done, this parameter is set as ``N``. If invalid parameters are found while the re-reading, DAMON_RECLAIM will be disabled. +Once ``Y`` is written to this parametr, the user must not write to any
This isn't a bug, but there is a typo ("parametr") in this line.
Documentation/admin-guide/mm/damon/reclaim.rst of parameters except ``enabled`` again. Once the re-reading is done, this · line 76
Quoted 2 lines
Documentation/admin-guide/mm/damon/reclaim.rst +2
-0+parameters until reading ``commit_inputs`` again returns ``N``. If users +violate this rule, the kernel can do undefined behaviors.
Is it acceptable to document a race condition that leads to undefined behavior instead of fixing it?
Even if the module parameter interface is restricted to root, user space shouldn't be able to trigger kernel undefined behavior (which could lead to memory corruption or crashes) simply by writing to module parameters concurrently.
Should the underlying race condition in DAMON_RECLAIM be fixed with proper synchronization rather than relying on userspace adherence to a documentation warning?
This isn't a bug, but the phrasing "can do undefined behaviors" is slightly awkward. Rephrasing to "may exhibit undefined behavior" might be more natural.
# end of sashiko.dev inline review # review url: https://sashiko.dev/#/patchset/[email protected] # # hkml [1] generated a draft of this mail. It can be regenerated # using below command: # # hkml patch sashiko_dev --for_forwarding \ # [email protected] # # [1] https://github.com/sjp38/hackermail
Sent using hkml (https://github.com/sjp38/hackermail)
SeongJae Park
maintainerRe: (sashiko review) [RFC PATCH 2/2] Docs/admin-guide/mm/damon/lru_sort: warn commit_inputs vs param updates race
In reply to SeongJae ParkForwarding Sashiko review for doing discussions via mails.
# review url: https://sashiko.dev/#/patchset/[email protected] # start of sashiko.dev inline review commit 0a9a055d4225a92c337c76fef97bfcdca5d9508f Author: SeongJae Park <[email protected]> Docs/admin-guide/mm/damon/lru_sort: warn commit_inputs vs param updates race
This patch adds documentation warning users about a data race in DAMON_LRU_SORT when modifying module parameters while the kdamond thread is reading them. It states that violating this rule can cause undefined behavior in the kernel.
Documentation/admin-guide/mm/damon/lru_sort.rst of parametrs except ``enabled`` again. Once the re-reading is done, this · line 82
Quoted 9 lines
Documentation/admin-guide/mm/damon/lru_sort.rst +1
-0@@ -79,6 +79,10 @@ of parametrs except ``enabled`` again. Once the re-reading is done, this parameter is set as ``N``. If invalid parameters are found while the re-reading, DAMON_LRU_SORT will be disabled. +Once ``Y`` is written to this parametr, the user must not write to any
^^^^^^^^
This isn't a bug, but there is a typo here (parametr).
Documentation/admin-guide/mm/damon/lru_sort.rst of parameters except ``enabled`` again. Once the re-reading is done, this · line 84
Quoted 2 lines
Documentation/admin-guide/mm/damon/lru_sort.rst +2
-0+parameters until reading ``commit_inputs`` again returns ``N``. If users +violate this rule, the kernel can do undefined behaviors.
^^^^^^^^^^^^^^^^^^^
Should this data race be fixed in the kernel code itself rather than just documented?
The kernel generally should not exhibit undefined behavior, memory corruption, or crashes due to concurrent sysfs or module parameter writes, even if those writes are restricted to root users. Could the underlying code be updated with proper synchronization to safely handle concurrent updates instead?
Documentation/admin-guide/mm/damon/lru_sort.rst of parameters except ``enabled`` again. Once the re-reading is done, this · line 88
Quoted 4 lines
Documentation/admin-guide/mm/damon/lru_sort.rst +1
-0+ active_mem_bp -------------
# end of sashiko.dev inline review # review url: https://sashiko.dev/#/patchset/[email protected] # # hkml [1] generated a draft of this mail. It can be regenerated # using below command: # # hkml patch sashiko_dev --for_forwarding \ # [email protected] # # [1] https://github.com/sjp38/hackermail
Sent using hkml (https://github.com/sjp38/hackermail)
SeongJae Park
maintainerRe: (sashiko review) [RFC PATCH 1/2] Docs/admin-guide/mm/damon/reclaim: warn commit_inputs vs param updates race
In reply to SeongJae ParkQuoted 22 lines · On Sat, 28 Mar 2026 10:34:45 -0700 SeongJae Park <[email protected]> wrote:
Forwarding Sashiko review for doing discussions via mails.
# review url: https://sashiko.dev/#/patchset/[email protected] # start of sashiko.dev inline review commit 8b189801fc104c5ecc412454a3d8db6a3faf27d6 Author: SeongJae Park <[email protected]>Docs/admin-guide/mm/damon/reclaim: warn
commit_inputsvs param updates raceThis commit adds documentation warning users not to write to module parameters while
commit_inputsis in progress. This warning is intended to help users avoid a race condition that can cause undefined kernel behavior.Quoted 7 lines
Documentation/admin-guide/mm/damon/reclaim.rst +0
-0@@ -71,6 +71,10 @@ of parametrs except ``enabled`` again. Once the re-reading is done, this parameter is set as ``N``. If invalid parameters are found while the re-reading, DAMON_RECLAIM will be disabled.
Quoted 3 lines
Documentation/admin-guide/mm/damon/reclaim.rst of parameters except ``enabled`` again. Once the re-reading is done, this · line 74
Quoted 1 line
Documentation/admin-guide/mm/damon/reclaim.rst +1
-0+Once ``Y`` is written to this parametr, the user must not write to anyThis isn't a bug, but there is a typo ("parametr") in this line.
Good eye, I will fix this in the next revision.
Quoted 7 lines
Documentation/admin-guide/mm/damon/reclaim.rst of parameters except ``enabled`` again. Once the re-reading is done, this · line 76
Quoted 3 lines
Documentation/admin-guide/mm/damon/reclaim.rst +2
-0+parameters until reading ``commit_inputs`` again returns ``N``. If users +violate this rule, the kernel can do undefined behaviors.Is it acceptable to document a race condition that leads to undefined behavior instead of fixing it?
Quoted 8 lines
Even if the module parameter interface is restricted to root, user space shouldn't be able to trigger kernel undefined behavior (which could lead to memory corruption or crashes) simply by writing to module parameters concurrently.
Should the underlying race condition in
DAMON_RECLAIMbe fixed with proper synchronization rather than relying on userspace adherence to a documentation warning?
Good callout. In short, I agree for mainline kernel, but I'd argue this may be enough for stable kernels.
That is, I was also thinking in a way similar to sashiko. But, from the work I realized the amount of changes for fixing those in stable-backporting-easy way is not small. Also, given the age of the broken commits (5.19!), I don't think this is urgent. And again arguably, as long as it is well documented, letting users break kernel when they want (e.g., sysrq-trigger) is ok...? Let me know if other humans have different opinion, though.
But for future (mainline), surely this have to be fixed in the code. And Liew's patch [1] was initially started not for exactly this patch, but will fix this together. Cc-ing Liew.
So, I'm suggesting to add this documentation for stable kernels, and continue helping Liew's patch for cleanly removing this awkward behavior in the mianline and future kernels.
Quoted 3 lines
This isn't a bug, but the phrasing "can do undefined behaviors" is slightly awkward. Rephrasing to "may exhibit undefined behavior" might be more natural.
Good catch. I will update so in the next version.
[1] https://lore.kernel.org/[email protected]
Thanks,
SJ
[...]
SeongJae Park
maintainerRe: (sashiko review) [RFC PATCH 2/2] Docs/admin-guide/mm/damon/lru_sort: warn commit_inputs vs param updates race
In reply to SeongJae ParkQuoted 1 line · On Sat, 28 Mar 2026 10:35:04 -0700 SeongJae Park <[email protected]> wrote:
Forwarding Sashiko review for doing discussions via mails.
All comments are same to that for DAMON_RECLAIM. Please refer to
https://lore.kernel.org/[email protected] for my response.
Thanks,
SJ
[...]