Skip to contentSkip to conversation

platform/x86: oxpec: add support for OneXPlayer Super X

PATCH Superseded Alexander Egorov 4 participants 9 messages Mar 29 – May 26

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: oxpec: add support for OneXPlayer Super X

From: ps1x <[email protected]>

OneXPlayer Super X identifies itself via DMI as:

board vendor: ONE-NETBOOK
board name: ONEXPLAYER SUPER X
product name: ONEXPLAYER SUPER X

Current mainline oxpec does not contain a matching DMI entry for this system, so the in-tree driver is not auto-loaded.

On the tested Super X device, the working EC layout matches the following handling:

- fan RPM is read from OXP_SENSOR_FAN_REG (0x76)
- pwm1_enable uses OXP_SENSOR_PWM_ENABLE_REG (0x4A)
- pwm1 uses OXP_SENSOR_PWM_REG (0x4B) with direct 0-255 writes
- turbo toggle uses OXP_TURBO_SWITCH_REG (0xF1)
- charge-limit / charge-behaviour uses the same battery extension path as the X1 family

Add a dedicated oxp_superx board id, a DMI match for OneXPlayer Super X, and route the fan, PWM, turbo-toggle, and battery-extension paths through the validated Super X handling.

Tested-on: OneXPlayer Super X

---
 drivers/platform/x86/oxpec.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/platform/x86/oxpec.c +17 -0
index 6d4a53a2e..d366c398d 100644
@@ -48,6 +48,7 @@ enum oxp_board {
 	oxp_mini_amd_a07,
 	oxp_mini_amd_pro,
 	oxp_x1,
+	oxp_superx,
 	oxp_g1_i,
 	oxp_g1_a,
 };
@@ -282,6 +283,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)oxp_x1,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
+		},
+		.driver_data = (void *)oxp_superx,
+	},
 	{},
 };
 
@@ -336,6 +344,7 @@ static umode_t tt_toggle_is_visible(struct kobject *kobj,
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return attr->mode;
@@ -366,6 +375,7 @@ static ssize_t tt_toggle_store(struct device *dev,
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		reg = OXP_TURBO_SWITCH_REG;
 		mask = OXP_TURBO_TAKE_VAL;
@@ -412,6 +422,7 @@ static ssize_t tt_toggle_show(struct device *dev,
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		reg = OXP_TURBO_SWITCH_REG;
 		mask = OXP_TURBO_TAKE_VAL;
@@ -507,6 +518,7 @@ static bool oxp_psy_ext_supported(void)
 {
 	switch (board) {
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 	case oxp_fly:
@@ -640,6 +652,7 @@ static int oxp_pwm_enable(void)
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_MANUAL);
@@ -660,6 +673,7 @@ static int oxp_pwm_disable(void)
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_AUTO);
@@ -717,6 +731,7 @@ static int oxp_pwm_fan_speed(long *val)
 	case oxp_mini_amd:
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		return read_from_ec(OXP_SENSOR_FAN_REG, 2, val);
 	default:
@@ -749,6 +764,7 @@ static int oxp_pwm_input_write(long val)
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_REG, val);
 	default:
@@ -788,6 +804,7 @@ static int oxp_pwm_input_read(long *val)
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 	default:
 		ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
Signature · 1 line
2.53.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 21 lines · Alexander Egorov

From: ps1x <[email protected]>

OneXPlayer Super X identifies itself via DMI as:

board vendor: ONE-NETBOOK
board name: ONEXPLAYER SUPER X
product name: ONEXPLAYER SUPER X

Current mainline oxpec does not contain a matching DMI entry for this system, so the in-tree driver is not auto-loaded.

On the tested Super X device, the working EC layout matches the following handling:

- fan RPM is read from OXP_SENSOR_FAN_REG (0x76)
- pwm1_enable uses OXP_SENSOR_PWM_ENABLE_REG (0x4A)
- pwm1 uses OXP_SENSOR_PWM_REG (0x4B) with direct 0-255 writes
- turbo toggle uses OXP_TURBO_SWITCH_REG (0xF1)
- charge-limit / charge-behaviour uses the same battery extension path as the X1 family

Quoted 6 lines

Add a dedicated oxp_superx board id, a DMI match for OneXPlayer Super X, and route the fan, PWM, turbo-toggle, and battery-extension paths through the validated Super X handling.

Tested-on: OneXPlayer Super X

Looks good. Thanks for adding this.

drivers/platform/x86/oxpec.c enum oxp_board { · line 51

Quoted 13 lines

---
drivers/platform/x86/oxpec.c | 17 +++++++++++++++++

1 file changed, 17 insertions(+)
drivers/platform/x86/oxpec.c +1 -0
index 6d4a53a2e..d366c398d 100644
@@ -48,6 +48,7 @@ enum oxp_board {
 	oxp_mini_amd_a07,
 	oxp_mini_amd_pro,
 	oxp_x1,
+	oxp_superx,

As an aside, I'm not sure how the order on all these tables got so messed up. Don't worry about it for your patch, this is just a note for myself to go back and sort everything better later.

Thanks,
Derek

Quoted 89 lines
drivers/platform/x86/oxpec.c +16 -0
 	oxp_g1_i,
 	oxp_g1_a,
 };
@@ -282,6 +283,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)oxp_x1,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
+		},
+		.driver_data = (void *)oxp_superx,
+	},
 	{},
 };
 
@@ -336,6 +344,7 @@ static umode_t tt_toggle_is_visible(struct kobject *kobj,
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return attr->mode;
@@ -366,6 +375,7 @@ static ssize_t tt_toggle_store(struct device *dev,
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		reg = OXP_TURBO_SWITCH_REG;
 		mask = OXP_TURBO_TAKE_VAL;
@@ -412,6 +422,7 @@ static ssize_t tt_toggle_show(struct device *dev,
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		reg = OXP_TURBO_SWITCH_REG;
 		mask = OXP_TURBO_TAKE_VAL;
@@ -507,6 +518,7 @@ static bool oxp_psy_ext_supported(void)
 {
 	switch (board) {
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 	case oxp_fly:
@@ -640,6 +652,7 @@ static int oxp_pwm_enable(void)
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_MANUAL);
@@ -660,6 +673,7 @@ static int oxp_pwm_disable(void)
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_AUTO);
@@ -717,6 +731,7 @@ static int oxp_pwm_fan_speed(long *val)
 	case oxp_mini_amd:
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		return read_from_ec(OXP_SENSOR_FAN_REG, 2, val);
 	default:
@@ -749,6 +764,7 @@ static int oxp_pwm_input_write(long val)
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_REG, val);
 	default:
@@ -788,6 +804,7 @@ static int oxp_pwm_input_read(long *val)
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 	default:
 		ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
#2 lore raw
In reply to Alexander Egorov
Quoted 9 lines · Alexander Egorov

From: ps1x <[email protected]>

OneXPlayer Super X identifies itself via DMI as:

board vendor: ONE-NETBOOK
board name: ONEXPLAYER SUPER X
product name: ONEXPLAYER SUPER X

Quoted 5 lines

Current mainline oxpec does not contain a matching DMI entry for this system, so the in-tree driver is not auto-loaded.

On the tested Super X device, the working EC layout matches the following handling:

Hi,
thanks. Some minor issues with your patch we need to go through first

Quoted 7 lines

- fan RPM is read from OXP_SENSOR_FAN_REG (0x76)
- pwm1_enable uses OXP_SENSOR_PWM_ENABLE_REG (0x4A)
- pwm1 uses OXP_SENSOR_PWM_REG (0x4B) with direct 0-255 writes
- turbo toggle uses OXP_TURBO_SWITCH_REG (0xF1)
- charge-limit / charge-behaviour uses the same battery extension path as the X1 family

Quoted 5 lines

Add a dedicated oxp_superx board id, a DMI match for OneXPlayer Super X, and route the fan, PWM, turbo-toggle, and battery-extension paths through the validated Super X handling.

Tested-on: OneXPlayer Super X

Drop this tag

Quoted 1 line

AFAIK kernel requires real names and emails although in the past there have been some pseudonyms.

Using Alexander Egorov <[email protected]> would be better since you used this for the submission anyway.

Quoted 95 lines
---
 drivers/platform/x86/oxpec.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/platform/x86/oxpec.c +16 -0
index 6d4a53a2e..d366c398d 100644
@@ -48,6 +48,7 @@ enum oxp_board {
        oxp_mini_amd_a07,
        oxp_mini_amd_pro,
        oxp_x1,
+       oxp_superx,
        oxp_g1_i,
        oxp_g1_a,
 };
@@ -282,6 +283,13 @@ static const struct dmi_system_id dmi_table[] = {
                },
                .driver_data = (void *)oxp_x1,
        },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
+               },
+               .driver_data = (void *)oxp_superx,
+       },
        {},
 };
 
@@ -336,6 +344,7 @@ static umode_t tt_toggle_is_visible(struct kobject *kobj,
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
                return attr->mode;
@@ -366,6 +375,7 @@ static ssize_t tt_toggle_store(struct device *dev,
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                reg = OXP_TURBO_SWITCH_REG;
                mask = OXP_TURBO_TAKE_VAL;
@@ -412,6 +422,7 @@ static ssize_t tt_toggle_show(struct device *dev,
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                reg = OXP_TURBO_SWITCH_REG;
                mask = OXP_TURBO_TAKE_VAL;
@@ -507,6 +518,7 @@ static bool oxp_psy_ext_supported(void)
 {
        switch (board) {
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
        case oxp_fly:
@@ -640,6 +652,7 @@ static int oxp_pwm_enable(void)
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
                return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_MANUAL);
@@ -660,6 +673,7 @@ static int oxp_pwm_disable(void)
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
                return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_AUTO);
@@ -717,6 +731,7 @@ static int oxp_pwm_fan_speed(long *val)
        case oxp_mini_amd:
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                return read_from_ec(OXP_SENSOR_FAN_REG, 2, val);
        default:
@@ -749,6 +764,7 @@ static int oxp_pwm_input_write(long val)
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                return write_to_ec(OXP_SENSOR_PWM_REG, val);
        default:

drivers/platform/x86/oxpec.c static int oxp_pwm_input_read(long *val) · line 807

Quoted 4 lines
drivers/platform/x86/oxpec.c +1 -0
@@ -788,6 +804,7 @@ static int oxp_pwm_input_read(long *val)
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:

All these matches are above g1_a, do you need to add another enum? If not, re-use the g1_a to compact the patch.

Thanks,
Antheas

Quoted 7 lines
drivers/platform/x86/oxpec.c +0 -1
        case oxp_g1_a:
        default:
                ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
--

2.53.0

#3 lore raw

PATCH v2 1/1 platform/x86: oxpec: add support for OneXPlayer Super X

In reply to Alexander Egorov

OneXPlayer Super X identifies itself via DMI as:

board vendor: ONE-NETBOOK
board name: ONEXPLAYER SUPER X
product name: ONEXPLAYER SUPER X

Current mainline oxpec does not contain a matching DMI entry for this system, so the in-tree driver is not auto-loaded.

On the tested Super X device, the working EC layout matches the following handling:

- fan RPM is read from OXP_SENSOR_FAN_REG (0x76)
- pwm1_enable uses OXP_SENSOR_PWM_ENABLE_REG (0x4A)
- pwm1 uses OXP_SENSOR_PWM_REG (0x4B) with direct 0-255 writes
- turbo toggle uses OXP_TURBO_SWITCH_REG (0xF1)
- charge-limit / charge-behaviour uses the same battery extension path as the X1 family

Add a dedicated oxp_superx board id, a DMI match for OneXPlayer Super X, and route the fan, PWM, turbo-toggle, and battery-extension paths through the validated Super X handling.

---
 drivers/platform/x86/oxpec.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/platform/x86/oxpec.c +17 -0
index 6d4a53a2e..d366c398d 100644
@@ -48,6 +48,7 @@ enum oxp_board {
 	oxp_mini_amd_a07,
 	oxp_mini_amd_pro,
 	oxp_x1,
+	oxp_superx,
 	oxp_g1_i,
 	oxp_g1_a,
 };
@@ -282,6 +283,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)oxp_x1,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
+		},
+		.driver_data = (void *)oxp_superx,
+	},
 	{},
 };
 
@@ -336,6 +344,7 @@ static umode_t tt_toggle_is_visible(struct kobject *kobj,
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return attr->mode;
@@ -366,6 +375,7 @@ static ssize_t tt_toggle_store(struct device *dev,
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		reg = OXP_TURBO_SWITCH_REG;
 		mask = OXP_TURBO_TAKE_VAL;
@@ -412,6 +422,7 @@ static ssize_t tt_toggle_show(struct device *dev,
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		reg = OXP_TURBO_SWITCH_REG;
 		mask = OXP_TURBO_TAKE_VAL;
@@ -507,6 +518,7 @@ static bool oxp_psy_ext_supported(void)
 {
 	switch (board) {
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 	case oxp_fly:
@@ -640,6 +652,7 @@ static int oxp_pwm_enable(void)
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_MANUAL);
@@ -660,6 +673,7 @@ static int oxp_pwm_disable(void)
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
 	case oxp_x1:
+	case oxp_superx:
 	case oxp_g1_i:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_AUTO);
@@ -717,6 +731,7 @@ static int oxp_pwm_fan_speed(long *val)
 	case oxp_mini_amd:
 	case oxp_mini_amd_a07:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		return read_from_ec(OXP_SENSOR_FAN_REG, 2, val);
 	default:
@@ -749,6 +764,7 @@ static int oxp_pwm_input_write(long val)
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 		return write_to_ec(OXP_SENSOR_PWM_REG, val);
 	default:
@@ -788,6 +804,7 @@ static int oxp_pwm_input_read(long *val)
 	case aok_zoe_a1:
 	case oxp_fly:
 	case oxp_mini_amd_pro:
+	case oxp_superx:
 	case oxp_g1_a:
 	default:
 		ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
Signature · 1 line
2.53.0
maintainer Reviewed-by on v2 1/1
#4 lore raw
Quoted 20 lines · Alexander Egorov

OneXPlayer Super X identifies itself via DMI as:

board vendor: ONE-NETBOOK
board name: ONEXPLAYER SUPER X
product name: ONEXPLAYER SUPER X

Current mainline oxpec does not contain a matching DMI entry for this system, so the in-tree driver is not auto-loaded.

On the tested Super X device, the working EC layout matches the following handling:

- fan RPM is read from OXP_SENSOR_FAN_REG (0x76)
- pwm1_enable uses OXP_SENSOR_PWM_ENABLE_REG (0x4A)
- pwm1 uses OXP_SENSOR_PWM_REG (0x4B) with direct 0-255 writes
- turbo toggle uses OXP_TURBO_SWITCH_REG (0xF1)
- charge-limit / charge-behaviour uses the same battery extension path as the X1 family

Quoted 3 lines

Add a dedicated oxp_superx board id, a DMI match for OneXPlayer Super X, and route the fan, PWM, turbo-toggle, and battery-extension paths through the validated Super X handling.

Hi,
did you check if the superx board id is needed or if you can piggyback on g1_a?

If you can, I'd rather you do that. In either case:

Also, for this V2, you missed Derek's Reviewed-by. Resend the patch with both my and Derek's reviewed tags, use -v3 in the makepatch generation to include V3 in the header, and cc Ilpo who is the x86 subsystem maintainer so they can merge this patch. Before you do that, check if you can use g1_a though.

Best,
Antheas

Quoted 107 lines
---
 drivers/platform/x86/oxpec.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/platform/x86/oxpec.c +17 -1
index 6d4a53a2e..d366c398d 100644
@@ -48,6 +48,7 @@ enum oxp_board {
        oxp_mini_amd_a07,
        oxp_mini_amd_pro,
        oxp_x1,
+       oxp_superx,
        oxp_g1_i,
        oxp_g1_a,
 };
@@ -282,6 +283,13 @@ static const struct dmi_system_id dmi_table[] = {
                },
                .driver_data = (void *)oxp_x1,
        },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
+               },
+               .driver_data = (void *)oxp_superx,
+       },
        {},
 };
 
@@ -336,6 +344,7 @@ static umode_t tt_toggle_is_visible(struct kobject *kobj,
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
                return attr->mode;
@@ -366,6 +375,7 @@ static ssize_t tt_toggle_store(struct device *dev,
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                reg = OXP_TURBO_SWITCH_REG;
                mask = OXP_TURBO_TAKE_VAL;
@@ -412,6 +422,7 @@ static ssize_t tt_toggle_show(struct device *dev,
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                reg = OXP_TURBO_SWITCH_REG;
                mask = OXP_TURBO_TAKE_VAL;
@@ -507,6 +518,7 @@ static bool oxp_psy_ext_supported(void)
 {
        switch (board) {
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
        case oxp_fly:
@@ -640,6 +652,7 @@ static int oxp_pwm_enable(void)
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
                return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_MANUAL);
@@ -660,6 +673,7 @@ static int oxp_pwm_disable(void)
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
        case oxp_x1:
+       case oxp_superx:
        case oxp_g1_i:
        case oxp_g1_a:
                return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_AUTO);
@@ -717,6 +731,7 @@ static int oxp_pwm_fan_speed(long *val)
        case oxp_mini_amd:
        case oxp_mini_amd_a07:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                return read_from_ec(OXP_SENSOR_FAN_REG, 2, val);
        default:
@@ -749,6 +764,7 @@ static int oxp_pwm_input_write(long val)
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
                return write_to_ec(OXP_SENSOR_PWM_REG, val);
        default:
@@ -788,6 +804,7 @@ static int oxp_pwm_input_read(long *val)
        case aok_zoe_a1:
        case oxp_fly:
        case oxp_mini_amd_pro:
+       case oxp_superx:
        case oxp_g1_a:
        default:
                ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
--

2.53.0

#7 lore raw

PATCH v3 1/1 Remove outdated upstream contact note

In reply to Alexander Egorov

From: ps1x <[email protected]>

---
 README.md | 5 -----
 1 file changed, 5 deletions(-)
README.md +0 -5
index acc4503..67c2915 100644
@@ -58,11 +58,6 @@ This project is based on the original `oxp-sensors` work:
 
 - <https://gitlab.com/Samsagax/oxp-sensors>
 
-I could not find a working way to contact Joaquín Ignacio Aramendía
-(`@Samsagax`) directly. If the upstream author wants this repository or any
-part of it to be removed from public distribution, they are welcome to open an
-issue in this repository.
-
 ## Included Components
 
 - `oxp-sensors.c`: kernel driver
Signature · 1 line
2.53.0
#5 lore raw

PATCH v3 1/1 platform/x86: oxpec: add support for OneXPlayer Super X

In reply to Alexander Egorov

OneXPlayer Super X identifies itself via DMI as:

board vendor: ONE-NETBOOK
board name: ONEXPLAYER SUPER X
product name: ONEXPLAYER SUPER X

Current mainline oxpec does not contain a matching DMI entry for this system, so the in-tree driver is not auto-loaded.

The tested Super X fan, PWM, turbo-toggle, and battery charge-control EC layout matches the existing ONEXPLAYER G1 A handling.

Add a DMI match for OneXPlayer Super X and reuse the oxp_g1_a board data.

---
Changes in v3:
- Reuse oxp_g1_a instead of adding a dedicated oxp_superx board id.
- Add Derek's Reviewed-by tag.
- Add Antheas' Reviewed-by tag.
- Use consistent submitter identity.

 drivers/platform/x86/oxpec.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/platform/x86/oxpec.c +7 -0
index 6d4a53a..99c0dfc 100644
@@ -205,6 +205,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)oxp_g1_a,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
+		},
+		.driver_data = (void *)oxp_g1_a,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
Signature · 1 line
2.54.0
#6 lore raw

lgtm

Antheas

Quoted 49 lines · Alexander Egorov

OneXPlayer Super X identifies itself via DMI as:

board vendor: ONE-NETBOOK
board name: ONEXPLAYER SUPER X
product name: ONEXPLAYER SUPER X

Current mainline oxpec does not contain a matching DMI entry for this system, so the in-tree driver is not auto-loaded.

The tested Super X fan, PWM, turbo-toggle, and battery charge-control EC layout matches the existing ONEXPLAYER G1 A handling.

Add a DMI match for OneXPlayer Super X and reuse the oxp_g1_a board data.

---
Changes in v3:
- Reuse oxp_g1_a instead of adding a dedicated oxp_superx board id.
- Add Derek's Reviewed-by tag.
- Add Antheas' Reviewed-by tag.
- Use consistent submitter identity.

 drivers/platform/x86/oxpec.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/platform/x86/oxpec.c +7 -1
index 6d4a53a..99c0dfc 100644
@@ -205,6 +205,13 @@ static const struct dmi_system_id dmi_table[] = {
                },
                .driver_data = (void *)oxp_g1_a,
        },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
+                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
+               },
+               .driver_data = (void *)oxp_g1_a,
+       },
        {
                .matches = {
                        DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
--

2.54.0

maintainer
#8 lore raw

Re: [PATCH v3] Remove outdated upstream contact note

In reply to Alexander Egorov
Quoted 1 line · Alexander Egorov

Thank you for your contribution, it has been applied to my local review-ilpo-fixes branch. Note it will show up in the public platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/1] Remove outdated upstream contact note
(no commit info)
[1/1] platform/x86: oxpec: add support for OneXPlayer Super X

      commit: 51be655c307a3e6c8bce16f01c51393eea2d23c2

--
i.