Skip to contentSkip to conversation

ALSA: hda/realtek: fix bad indentation for alc269

PATCH Superseded Lei Huang 3 participants 3 messages Mar 30 – Apr 1 Sound

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Lei Huang

author
#0 lore raw

PATCH 1/1 ALSA: hda/realtek: fix bad indentation for alc269

From: Lei Huang <[email protected]>

Mention complains about this coding style:

ERROR: code indent should use tabs where possible #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$

fix it up.

---
 sound/hda/codecs/realtek/alc269.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
sound/hda/codecs/realtek/alc269.c +4 -4
index b6a58852752a..09af4d378b30 100644
@@ -6637,10 +6637,10 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc288_fixup_surface_swap_dacs,
 	},
-        [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
-                .type = HDA_FIXUP_FUNC,
-                .v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
-        },
+	[ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
+	},
 	[ALC245_FIXUP_BASS_HP_DAC] = {
 		.type = HDA_FIXUP_FUNC,
 		/* Borrow the DAC routing selected for those Thinkpads */
Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · Lei Huang

From: Lei Huang <[email protected]>

Mention complains about this coding style:

Quoted 7 lines

ERROR: code indent should use tabs where possible #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$

fix it up.

Could you try to pinpoint the introducing commit with Fixes tag?

thanks,

Takashi

#2 lore raw
Quoted 11 lines · Takashi Iwai
Quoted 9 lines · Lei Huang

From: Lei Huang <[email protected]>

Mention complains about this coding style:

ERROR: code indent should use tabs where possible #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$

Quoted 5 lines
Quoted 3 lines

fix it up.

Could you try to pinpoint the introducing commit with Fixes tag?

Nothing to be fixed here. This is coding style. Coding style has absolutely zero effect on working code thus it is not a bug.

Best regards,
Krzysztof