IB/mlx5: Fix potential NULL dereference in query_device
Subsystems (2)
PATCH 1/1 IB/mlx5: Fix potential NULL dereference in query_device
Smatch reported an inconsistent NULL check for 'uhw' in mlx5_ib_query_device(). While 'uhw_outlen' is checked at the end of the function before calling ib_copy_to_udata(), 'uhw' is explicitly checked for NULL earlier in the same function.
If a caller provides a non-zero 'uhw_outlen' but a NULL 'uhw' pointer, ib_copy_to_udata() will attempt to dereference 'uhw', leading to a kernel panic. Fix this by checking the 'uhw' pointer directly.
--- drivers/infiniband/hw/mlx5/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/main.c +1 -1
@@ -1353,7 +1353,7 @@ static int mlx5_ib_query_device(struct ib_device *ibdev,fill_esw_mgr_reg_c0 (mdev, &resp); } -if (uhw_outlen) { +if (uhw) { err =ib_copy_to_udata (uhw, &resp, resp.response_length);if (err)
Signature · 1 line
2.43.0
Quoted 7 lines · Prathamesh Deshpande
Smatch reported an inconsistent NULL check for 'uhw' in
mlx5_ib_query_device(). While 'uhw_outlen' is checked at the end of the function before callingib_copy_to_udata(), 'uhw' is explicitly checked for NULL earlier in the same function.If a caller provides a non-zero '
uhw_outlen' but a NULL 'uhw' pointer,ib_copy_to_udata()will attempt to dereference 'uhw',
How is it possible?
Quoted 10 lines · Leon Romanovsky
Quoted 7 lines · Prathamesh Deshpande
Smatch reported an inconsistent NULL check for 'uhw' in
mlx5_ib_query_device(). While 'uhw_outlen' is checked at the end of the function before callingib_copy_to_udata(), 'uhw' is explicitly checked for NULL earlier in the same function.If a caller provides a non-zero '
uhw_outlen' but a NULL 'uhw' pointer,ib_copy_to_udata()will attempt to dereference 'uhw',How is it possible?
Hi Leon,
You are right that in the current uverbs paths, 'uhw_outlen' and 'uhw' should stay in sync.
However, Smatch flags this as an inconsistency because 'uhw' is explicitly checked for NULL earlier in this same function (at line 968). If the code assumes 'uhw' could be NULL there, it is safer and more consistent to check the pointer directly before passing it to ib_copy_to_udata() at line 1357.
This prevents any future refactoring or unconventional kernel-space callers from accidentally triggering a NULL dereference.
What do you think?
Thanks,
Prathamesh
Quoted 17 lines · Prathamesh Deshpande
Quoted 10 lines · Leon Romanovsky
Quoted 7 lines · Prathamesh Deshpande
Smatch reported an inconsistent NULL check for 'uhw' in
mlx5_ib_query_device(). While 'uhw_outlen' is checked at the end of the function before callingib_copy_to_udata(), 'uhw' is explicitly checked for NULL earlier in the same function.If a caller provides a non-zero '
uhw_outlen' but a NULL 'uhw' pointer,ib_copy_to_udata()will attempt to dereference 'uhw',How is it possible?
Hi Leon,
You are right that in the current uverbs paths, '
uhw_outlen' and 'uhw' should stay in sync.
Quoted 8 lines
However, Smatch flags this as an inconsistency because 'uhw' is explicitly checked for NULL earlier in this same function (at line 968). If the code assumes 'uhw' could be NULL there, it is safer and more consistent to check the pointer directly before passing it to
ib_copy_to_udata()at line 1357.This prevents any future refactoring or unconventional kernel-space callers from accidentally triggering a NULL dereference.
Kernel-space callers don't use uverbs path. It is solely for the user-space access.
Thanks
Quoted 5 lines
What do you think?
Thanks,
Prathamesh