Bluetooth: hci_event: fix OOB read and infinite loop in hci_le_create_big_complete_evt
Subsystems (3)
PATCH 1/1 Bluetooth: hci_event: fix OOB read and infinite loop in hci_le_create_big_complete_evt
hci_le_create_big_complete_evt() iterates over BT_BOUND connections for a BIG handle using a while loop, accessing ev->bis_handle[i++] on each iteration. However, there is no check that i < ev->num_bis before the array access.
When a controller sends a LE_Create_BIG_Complete event with num_bis=0 while BT_BOUND connections exist for that BIG handle, the loop reads beyond the valid bis_handle[] entries into adjacent heap memory. Since the out-of-bounds values typically exceed HCI_CONN_HANDLE_MAX (0x0EFF), hci_conn_set_handle() rejects them and the connection remains in BT_BOUND state. The same connection is then found again by hci_conn_hash_lookup_big_state(), creating an infinite loop with hci_dev_lock held that blocks all Bluetooth operations:
Bluetooth: hci0: Invalid handle: 0x6b6b > 0x0eff
Bluetooth: hci0: Invalid handle: 0x6b6b > 0x0eff ... (repeats ~177 times)
Bluetooth: hci0: Opcode 0x2040 failed: -110
Bluetooth: hci0: command 0x2040 tx timeout
The value 0x6b6b is the KASAN slab free poison byte (0x6b), confirming reads of freed/uninitialized heap memory.
Fix this by adding a bounds check on i against ev->num_bis before accessing the array. Connections beyond the reported count are cleaned up with HCI_ERROR_UNSPECIFIED to prevent the infinite loop.
--- net/bluetooth/hci_event.c | 6 ++++++ 1 file changed, 6 insertions(+)
net/bluetooth/hci_event.c +6 -0
@@ -7085,6 +7085,12 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,continue ; } +if (i >= ev->num_bis) { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn); +continue ; + } +if (hci_conn_set_handle (conn,__le16_to_cpu (ev->bis_handle[i++])))continue ;
Signature · 1 line
2.51.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1074955
---Test result---
Test Summary:
CheckPatch PENDING 0.35 seconds GitLint PENDING 0.24 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 25.88 seconds CheckAllWarning PASS 28.00 seconds CheckSparse PASS 26.93 seconds BuildKernel32 PASS 25.20 seconds TestRunnerSetup PASS 563.48 seconds TestRunner_l2cap-tester PASS 27.49 seconds TestRunner_iso-tester PASS 41.46 seconds TestRunner_bnep-tester PASS 6.28 seconds TestRunner_mgmt-tester FAIL 112.29 seconds TestRunner_rfcomm-tester PASS 9.28 seconds TestRunner_sco-tester FAIL 14.09 seconds TestRunner_ioctl-tester PASS 9.95 seconds TestRunner_mesh-tester FAIL 11.48 seconds TestRunner_smp-tester PASS 10.67 seconds TestRunner_userchan-tester PASS 6.57 seconds IncrementalBuild PENDING 0.43 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.104 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.936 seconds Mesh - Send cancel - 2 Timed out 1.994 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz
maintainerHi Hkbinbin,
Quoted 40 lines · hkbinbin
hci_le_create_big_complete_evt()iterates overBT_BOUNDconnections for a BIG handle using a while loop, accessing ev->bis_handle[i++] on each iteration. However, there is no check that i <ev->num_bisbefore the array access.When a controller sends a
LE_Create_BIG_Completeevent with num_bis=0 whileBT_BOUNDconnections exist for that BIG handle, the loop reads beyond the valid bis_handle[] entries into adjacent heap memory. Since the out-of-bounds values typically exceedHCI_CONN_HANDLE_MAX(0x0EFF),hci_conn_set_handle()rejects them and the connection remains inBT_BOUNDstate. The same connection is then found again byhci_conn_hash_lookup_big_state(), creating an infinite loop withhci_dev_lockheld that blocks all Bluetooth operations:Bluetooth: hci0: Invalid handle:
0x6b6b>0x0eff
Bluetooth: hci0: Invalid handle:0x6b6b>0x0eff... (repeats ~177 times)
Bluetooth: hci0: Opcode0x2040failed: -110
Bluetooth: hci0: command0x2040tx timeoutThe value
0x6b6bis the KASAN slab free poison byte (0x6b), confirming reads of freed/uninitialized heap memory.Fix this by adding a bounds check on i against
ev->num_bisbefore accessing the array. Connections beyond the reported count are cleaned up withHCI_ERROR_UNSPECIFIEDto prevent the infinite loop.Fixes a0bfde167b50 ("Bluetooth: ISO: Add support for connecting multiple BISes")Signed-off-by hkbinbin <[email protected]>--- net/bluetooth/hci_event.c | 6 ++++++ 1 file changed, 6 insertions(+)net/bluetooth/hci_event.c +0
-0
net/bluetooth/hci_event.c static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data, · line 7092
Quoted 8 lines
net/bluetooth/hci_event.c +5
-0@@ -7085,6 +7085,12 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,continue ; } +if (i >= ev->num_bis) { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn); +continue ; + }
https://sashiko.dev/#/patchset/20260331055032.1883139-1-hkbinbinbin%40gmail.com
Actually we might want to consider that all BISes failed if something like this happens, so perhaps we should break and terminate if i != ev->num_bis
Quoted 6 lines
net/bluetooth/hci_event.c +0
-1if (hci_conn_set_handle (conn,__le16_to_cpu (ev->bis_handle[i++])))continue ; --2.51.0
Signature · 1 line
Luiz Augusto von Dentz
PATCH v2 1/1 Bluetooth: hci_event: fix OOB read in hci_le_create_big_complete_evt
In reply to hkbinbinhci_le_create_big_complete_evt() iterates over BT_BOUND connections for a BIG handle using a while loop, accessing ev->bis_handle[i++] on each iteration. However, there is no check that i stays within ev->num_bis before the array access.
When a controller sends a LE_Create_BIG_Complete event with fewer bis_handle entries than there are BT_BOUND connections for that BIG, or with num_bis=0, the loop reads beyond the valid bis_handle[] flex array into adjacent heap memory. Since the out-of-bounds values typically exceed HCI_CONN_HANDLE_MAX (0x0EFF), hci_conn_set_handle() rejects them and the connection remains in BT_BOUND state. The same connection is then found again by hci_conn_hash_lookup_big_state(), creating an infinite loop with hci_dev_lock held.
Fix this by:
- Breaking out of the loop when i reaches ev->num_bis and cleaning up all remaining BT_BOUND connections, then terminating the BIG since a mismatch between the host and controller state indicates failure.
- Properly cleaning up the connection when hci_conn_set_handle() fails, instead of calling continue which leaves it in BT_BOUND state where it would be found again by the same lookup on the next iteration.
--- net/bluetooth/hci_event.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-)
net/bluetooth/hci_event.c +24 -2
@@ -7085,9 +7085,15 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,continue ; } +if (i >= ev->num_bis) +break ; +if (hci_conn_set_handle (conn, -__le16_to_cpu (ev->bis_handle[i++]))) +__le16_to_cpu (ev->bis_handle[i++]))) { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn);continue ; + } conn->state =BT_CONNECTED ;set_bit (HCI_CONN_BIG_CREATED , &conn->flags);
@@ -7096,7 +7102,22 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,hci_iso_setup_path (conn); } -if (!ev->status && !i) +if (conn) { +/* More bound connections than BIS handles reported by the +* controller -- treat this as a failure for the entire BIG +* and clean up any remaining BT_BOUND connections. +*/ +do { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn); + }while ((conn =hci_conn_hash_lookup_big_state (hdev, + ev->handle, +BT_BOUND , +HCI_ROLE_MASTER ))); + +hci_cmd_sync_queue (hdev, hci_iso_term_big_sync, +UINT_PTR (ev->handle),NULL ); + }else if (!ev->status && !i) {/* If no BISes have been connected for the BIG, * terminate. This is in case all bound connections * have been closed before the BIG creation
@@ -7104,6 +7125,7 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,*/ hci_cmd_sync_queue (hdev, hci_iso_term_big_sync,UINT_PTR (ev->handle),NULL ); + }hci_dev_unlock (hdev); }
Signature · 1 line
2.51.0
PATCH v2 1/1 Bluetooth: hci_event: fix OOB read in hci_le_create_big_complete_evt
In reply to hkbinbinhci_le_create_big_complete_evt() iterates over BT_BOUND connections for a BIG handle using a while loop, accessing ev->bis_handle[i++] on each iteration. However, there is no check that i stays within ev->num_bis before the array access.
When a controller sends a LE_Create_BIG_Complete event with fewer bis_handle entries than there are BT_BOUND connections for that BIG, or with num_bis=0, the loop reads beyond the valid bis_handle[] flex array into adjacent heap memory. Since the out-of-bounds values typically exceed HCI_CONN_HANDLE_MAX (0x0EFF), hci_conn_set_handle() rejects them and the connection remains in BT_BOUND state. The same connection is then found again by hci_conn_hash_lookup_big_state(), creating an infinite loop with hci_dev_lock held.
Fix this by:
- Breaking out of the loop when i reaches ev->num_bis and cleaning up all remaining BT_BOUND connections, then terminating the BIG since a mismatch between the host and controller state indicates failure.
- Properly cleaning up the connection when hci_conn_set_handle() fails, instead of calling continue which leaves it in BT_BOUND state where it would be found again by the same lookup on the next iteration.
--- net/bluetooth/hci_event.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-)
net/bluetooth/hci_event.c +24 -2
@@ -7085,9 +7085,15 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,continue ; } +if (i >= ev->num_bis) +break ; +if (hci_conn_set_handle (conn, -__le16_to_cpu (ev->bis_handle[i++]))) +__le16_to_cpu (ev->bis_handle[i++]))) { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn);continue ; + } conn->state =BT_CONNECTED ;set_bit (HCI_CONN_BIG_CREATED , &conn->flags);
@@ -7096,7 +7102,22 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,hci_iso_setup_path (conn); } -if (!ev->status && !i) +if (conn) { +/* More bound connections than BIS handles reported by the +* controller -- treat this as a failure for the entire BIG +* and clean up any remaining BT_BOUND connections. +*/ +do { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn); + }while ((conn =hci_conn_hash_lookup_big_state (hdev, + ev->handle, +BT_BOUND , +HCI_ROLE_MASTER ))); + +hci_cmd_sync_queue (hdev, hci_iso_term_big_sync, +UINT_PTR (ev->handle),NULL ); + }else if (!ev->status && !i) {/* If no BISes have been connected for the BIG, * terminate. This is in case all bound connections * have been closed before the BIG creation
@@ -7104,6 +7125,7 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,*/ hci_cmd_sync_queue (hdev, hci_iso_term_big_sync,UINT_PTR (ev->handle),NULL ); + }hci_dev_unlock (hdev); }
Signature · 1 line
2.51.0
RE: [v2] Bluetooth: hci_event: fix OOB read in hci_le_create_big_complete_evt
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1075230
---Test result---
Test Summary:
CheckPatch PENDING 0.54 seconds GitLint PENDING 0.30 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 26.97 seconds CheckAllWarning PASS 29.71 seconds CheckSparse PASS 28.46 seconds BuildKernel32 PASS 26.25 seconds TestRunnerSetup PASS 580.72 seconds TestRunner_l2cap-tester PASS 28.52 seconds TestRunner_iso-tester PASS 44.02 seconds TestRunner_bnep-tester PASS 6.53 seconds TestRunner_mgmt-tester FAIL 115.81 seconds TestRunner_rfcomm-tester PASS 9.70 seconds TestRunner_sco-tester FAIL 14.98 seconds TestRunner_ioctl-tester PASS 10.72 seconds TestRunner_mesh-tester FAIL 12.54 seconds TestRunner_smp-tester PASS 10.94 seconds TestRunner_userchan-tester PASS 6.95 seconds IncrementalBuild PENDING 0.75 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 488 (98.8%), Failed: 2, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.113 seconds LL Privacy - Start Discovery 1 (Disable RL) Failed 0.174 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.510 seconds Mesh - Send cancel - 2 Timed out 1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
RE: [v2] Bluetooth: hci_event: fix OOB read in hci_le_create_big_complete_evt
In reply to hkbinbinThis is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1075230
---Test result---
Test Summary:
CheckPatch PENDING 0.43 seconds GitLint PENDING 0.35 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 27.23 seconds CheckAllWarning PASS 30.20 seconds CheckSparse PASS 29.00 seconds BuildKernel32 PASS 31.33 seconds TestRunnerSetup PASS 583.67 seconds TestRunner_l2cap-tester PASS 28.78 seconds TestRunner_iso-tester PASS 42.38 seconds TestRunner_bnep-tester PASS 6.52 seconds TestRunner_mgmt-tester FAIL 114.53 seconds TestRunner_rfcomm-tester PASS 9.55 seconds TestRunner_sco-tester FAIL 14.36 seconds TestRunner_ioctl-tester PASS 10.20 seconds TestRunner_mesh-tester FAIL 12.56 seconds TestRunner_smp-tester PASS 9.06 seconds TestRunner_userchan-tester PASS 6.95 seconds TestRunner_6lowpan-tester FAIL 8.66 seconds IncrementalBuild PENDING 0.26 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.107 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
7.0.0-rc2-g9f419c47155d #1 Not tainted
------------------------------------------------------
kworker/u5:2/117 is trying to acquire lock:ffff8880020be240 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_connect_cfm+0x358/0x8d0
but task is already holding lock:ffff888002094c20 (&conn->lock){+.+.}-{3:3}, at: sco_connect_cfm+0x22d/0x8d0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&conn->lock){+.+.}-{3:3}:
lock_acquire+0xf7/0x2c0
_raw_spin_lock+0x2a/0x40
sco_sock_connect+0x4d7/0x1280
__sys_connect+0x1a3/0x260
__x64_sys_connect+0x6e/0xb0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
check_prev_add+0xe9/0xc70
__lock_acquire+0x1457/0x1df0
lock_acquire+0xf7/0x2c0
lock_sock_nested+0x36/0xd0
sco_connect_cfm+0x358/0x8d0
hci_sync_conn_complete_evt+0x3d3/0x8e0
hci_event_packet+0x74f/0xb10
hci_rx_work+0x398/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30other info that might help us debug this:
...
BUG: sleeping function called from invalid context at net/core/sock.c:3782
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 117, name: kworker/u5:2preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
CPU: 0 UID: 0 PID: 117 Comm: kworker/u5:2 Not tainted 7.0.0-rc2-g9f419c47155d #1 PREEMPT(lazy) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Workqueue: hci0 hci_rx_work Call Trace: <TASK> dump_stack_lvl+0x49/0x60 __might_resched+0x2ea/0x500 lock_sock_nested+0x47/0xd0 ? sco_connect_cfm+0x358/0x8d0 sco_connect_cfm+0x358/0x8d0 ? hci_debugfs_create_conn+0x190/0x210 ? __pfx_sco_connect_cfm+0x10/0x10 hci_sync_conn_complete_evt+0x3d3/0x8e0 hci_event_packet+0x74f/0xb10 ? __pfx_hci_sync_conn_complete_evt+0x10/0x10 ? __pfx_hci_event_packet+0x10/0x10 ? mark_held_locks+0x49/0x80 ? lockdep_hardirqs_on_prepare+0xd4/0x180 ? _raw_spin_unlock_irqrestore+0x2c/0x50 hci_rx_work+0x398/0xd00 process_scheduled_works+0xb16/0x1ac0 ? __pfx_process_scheduled_works+0x10/0x10 ? lock_acquire+0xf7/0x2c0 ? lock_is_held_type+0x9b/0x110 ? __pfx_hci_rx_work+0x10/0x10 worker_thread+0x4ff/0xba0 ? _raw_spin_unlock_irqrestore+0x2c/0x50 ? __pfx_worker_thread+0x10/0x10 kthread+0x368/0x490 ? _raw_spin_unlock_irq+0x23/0x40 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x498/0x7e0 ? __pfx_ret_from_fork+0x10/0x10 ? __switch_to+0x9e4/0xe50 ? __switch_to_asm+0x32/0x60
...
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.659 seconds Mesh - Send cancel - 2 Timed out 1.992 seconds
##############################
Test: TestRunner_6lowpan-tester - FAIL
Desc: Run 6lowpan-tester with test-runner
Output:
WARNING: possible circular locking dependency detected 7.0.0-rc2-g9f419c47155d #1 Not tainted
------------------------------------------------------
kworker/0:1/11 is trying to acquire lock:ffff8880026f4940 ((wq_completion)hci0#2){+.+.}-{0:0}, at: touch_wq_lockdep_map+0x75/0x180
but task is already holding lock:ffffffff9e44d720 (rtnl_mutex){+.+.}-{4:4}, at: lowpan_unregister_netdev+0xd/0x30
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (rtnl_mutex){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
lowpan_register_netdev+0x11/0x30
chan_ready_cb+0x836/0xd00
l2cap_recv_frame+0x6a06/0x8920
l2cap_recv_acldata+0x790/0xdf0
hci_rx_work+0x500/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30-> #3 (&chan->lock#3/1){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
l2cap_chan_connect+0x74e/0x1980
lowpan_control_write+0x523/0x660
full_proxy_write+0x10b/0x190
vfs_write+0x1c0/0xf60
ksys_write+0xf1/0x1d0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c-> #2 (&conn->lock){+.+.}-{4:4}:
...
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
https://github.com/bluez/bluetooth-next/pull/40/checks
---
Regards,
Linux Bluetooth
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1074955
---Test result---
Test Summary:
CheckPatch PENDING 0.38 seconds GitLint PENDING 0.27 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 26.03 seconds CheckAllWarning PASS 28.49 seconds CheckSparse PASS 33.68 seconds BuildKernel32 PASS 25.50 seconds TestRunnerSetup PASS 561.70 seconds TestRunner_l2cap-tester PASS 27.46 seconds TestRunner_iso-tester PASS 36.85 seconds TestRunner_bnep-tester PASS 6.26 seconds TestRunner_mgmt-tester FAIL 115.85 seconds TestRunner_rfcomm-tester PASS 9.88 seconds TestRunner_sco-tester FAIL 15.12 seconds TestRunner_ioctl-tester PASS 10.36 seconds TestRunner_mesh-tester FAIL 12.61 seconds TestRunner_smp-tester PASS 9.16 seconds TestRunner_userchan-tester PASS 6.88 seconds TestRunner_6lowpan-tester FAIL 9.59 seconds IncrementalBuild PENDING 0.33 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.115 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
7.0.0-rc2-gae498cc69c41 #1 Not tainted
------------------------------------------------------
kworker/u5:2/116 is trying to acquire lock:ffff888002086240 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_connect_cfm+0x358/0x8d0
but task is already holding lock:ffff8880025f9420 (&conn->lock){+.+.}-{3:3}, at: sco_connect_cfm+0x22d/0x8d0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&conn->lock){+.+.}-{3:3}:
lock_acquire+0xf7/0x2c0
_raw_spin_lock+0x2a/0x40
sco_sock_connect+0x4d7/0x1280
__sys_connect+0x1a3/0x260
__x64_sys_connect+0x6e/0xb0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
check_prev_add+0xe9/0xc70
__lock_acquire+0x1457/0x1df0
lock_acquire+0xf7/0x2c0
lock_sock_nested+0x36/0xd0
sco_connect_cfm+0x358/0x8d0
hci_sync_conn_complete_evt+0x3d3/0x8e0
hci_event_packet+0x74f/0xb10
hci_rx_work+0x398/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30other info that might help us debug this:
...
BUG: sleeping function called from invalid context at net/core/sock.c:3782
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 116, name: kworker/u5:2preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
CPU: 0 UID: 0 PID: 116 Comm: kworker/u5:2 Not tainted 7.0.0-rc2-gae498cc69c41 #1 PREEMPT(lazy) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Workqueue: hci0 hci_rx_work Call Trace: <TASK> dump_stack_lvl+0x49/0x60 __might_resched+0x2ea/0x500 lock_sock_nested+0x47/0xd0 ? sco_connect_cfm+0x358/0x8d0 sco_connect_cfm+0x358/0x8d0 ? hci_debugfs_create_conn+0x190/0x210 ? __pfx_sco_connect_cfm+0x10/0x10 hci_sync_conn_complete_evt+0x3d3/0x8e0 hci_event_packet+0x74f/0xb10 ? __pfx_hci_sync_conn_complete_evt+0x10/0x10 ? __pfx_hci_event_packet+0x10/0x10 ? mark_held_locks+0x49/0x80 ? lockdep_hardirqs_on_prepare+0xd4/0x180 ? _raw_spin_unlock_irqrestore+0x2c/0x50 hci_rx_work+0x398/0xd00 process_scheduled_works+0xb16/0x1ac0 ? __pfx_process_scheduled_works+0x10/0x10 ? lock_acquire+0xf7/0x2c0 ? lock_is_held_type+0x9b/0x110 ? __pfx_hci_rx_work+0x10/0x10 worker_thread+0x4ff/0xba0 ? _raw_spin_unlock_irqrestore+0x2c/0x50 ? __pfx_worker_thread+0x10/0x10 kthread+0x368/0x490 ? _raw_spin_unlock_irq+0x23/0x40 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x498/0x7e0 ? __pfx_ret_from_fork+0x10/0x10 ? __switch_to+0x9e4/0xe50 ? __switch_to_asm+0x32/0x60
...
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.099 seconds Mesh - Send cancel - 2 Timed out 2.008 seconds
##############################
Test: TestRunner_6lowpan-tester - FAIL
Desc: Run 6lowpan-tester with test-runner
Output:
WARNING: possible circular locking dependency detected 7.0.0-rc2-gae498cc69c41 #1 Not tainted
------------------------------------------------------
kworker/0:1/11 is trying to acquire lock:ffff8880026dd140 ((wq_completion)hci0#2){+.+.}-{0:0}, at: touch_wq_lockdep_map+0x75/0x180
but task is already holding lock:ffffffff92c4d720 (rtnl_mutex){+.+.}-{4:4}, at: lowpan_unregister_netdev+0xd/0x30
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (rtnl_mutex){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
lowpan_register_netdev+0x11/0x30
chan_ready_cb+0x836/0xd00
l2cap_recv_frame+0x6a06/0x8920
l2cap_recv_acldata+0x790/0xdf0
hci_rx_work+0x500/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30-> #3 (&chan->lock#3/1){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
l2cap_chan_connect+0x74e/0x1980
lowpan_control_write+0x523/0x660
full_proxy_write+0x10b/0x190
vfs_write+0x1c0/0xf60
ksys_write+0xf1/0x1d0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c-> #2 (&conn->lock){+.+.}-{4:4}:
...
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
https://github.com/bluez/bluetooth-next/pull/39/checks
---
Regards,
Linux Bluetooth
PATCH v2 1/1 Bluetooth: hci_event: fix OOB read and infinite loop in hci_le_create_big_complete_evt
In reply to hkbinbinFrom: ZhiTao Ou <[email protected]>
hci_le_create_big_complete_evt() iterates over BT_BOUND connections for a BIG handle using a while loop, accessing ev->bis_handle[i++] on each iteration. However, there is no check that i stays within ev->num_bis before the array access.
When a controller sends a LE_Create_BIG_Complete event with fewer bis_handle entries than there are BT_BOUND connections for that BIG, or with num_bis=0, the loop reads beyond the valid bis_handle[] flex array into adjacent heap memory. Since the out-of-bounds values typically exceed HCI_CONN_HANDLE_MAX (0x0EFF), hci_conn_set_handle() rejects them and the connection remains in BT_BOUND state. The same connection is then found again by hci_conn_hash_lookup_big_state(), creating an infinite loop with hci_dev_lock held.
Fix this by:
- Breaking out of the loop when i reaches ev->num_bis and cleaning up all remaining BT_BOUND connections, then terminating the BIG since a mismatch between the host and controller state indicates failure.
- Properly cleaning up the connection when hci_conn_set_handle() fails, instead of calling continue which leaves it in BT_BOUND state where it would be found again by the same lookup on the next iteration.
--- net/bluetooth/hci_event.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-)
net/bluetooth/hci_event.c +24 -2
@@ -7085,9 +7085,15 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,continue ; } +if (i >= ev->num_bis) +break ; +if (hci_conn_set_handle (conn, -__le16_to_cpu (ev->bis_handle[i++]))) +__le16_to_cpu (ev->bis_handle[i++]))) { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn);continue ; + } conn->state =BT_CONNECTED ;set_bit (HCI_CONN_BIG_CREATED , &conn->flags);
@@ -7096,7 +7102,22 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,hci_iso_setup_path (conn); } -if (!ev->status && !i) +if (conn) { +/* More bound connections than BIS handles reported by the +* controller -- treat this as a failure for the entire BIG +* and clean up any remaining BT_BOUND connections. +*/ +do { +hci_connect_cfm (conn,HCI_ERROR_UNSPECIFIED ); +hci_conn_del (conn); + }while ((conn =hci_conn_hash_lookup_big_state (hdev, + ev->handle, +BT_BOUND , +HCI_ROLE_MASTER ))); + +hci_cmd_sync_queue (hdev, hci_iso_term_big_sync, +UINT_PTR (ev->handle),NULL ); + }else if (!ev->status && !i) {/* If no BISes have been connected for the BIG, * terminate. This is in case all bound connections * have been closed before the BIG creation
@@ -7104,6 +7125,7 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,*/ hci_cmd_sync_queue (hdev, hci_iso_term_big_sync,UINT_PTR (ev->handle),NULL ); + }hci_dev_unlock (hdev); }
Signature · 1 line
2.51.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1079845
---Test result---
Test Summary:
CheckPatch PENDING 0.55 seconds GitLint PENDING 0.31 seconds SubjectPrefix PASS 0.08 seconds BuildKernel PASS 24.13 seconds CheckAllWarning PASS 26.30 seconds CheckSparse PASS 31.36 seconds BuildKernel32 PASS 23.23 seconds TestRunnerSetup PASS 520.97 seconds TestRunner_l2cap-tester PASS 27.53 seconds TestRunner_iso-tester PASS 41.48 seconds TestRunner_bnep-tester PASS 6.29 seconds TestRunner_mgmt-tester FAIL 115.18 seconds TestRunner_rfcomm-tester PASS 9.51 seconds TestRunner_sco-tester FAIL 14.39 seconds TestRunner_ioctl-tester PASS 10.31 seconds TestRunner_mesh-tester FAIL 12.55 seconds TestRunner_smp-tester PASS 8.73 seconds TestRunner_userchan-tester PASS 6.89 seconds TestRunner_6lowpan-tester FAIL 8.81 seconds IncrementalBuild PENDING 0.29 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.119 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
7.0.0-rc2-gf3185b64cf7e #1 Not tainted
------------------------------------------------------
kworker/u5:2/117 is trying to acquire lock:ffff888001946240 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_connect_cfm+0x358/0x8d0
but task is already holding lock:ffff8880025f4220 (&conn->lock){+.+.}-{3:3}, at: sco_connect_cfm+0x22d/0x8d0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&conn->lock){+.+.}-{3:3}:
lock_acquire+0xf7/0x2c0
_raw_spin_lock+0x2a/0x40
sco_sock_connect+0x4d7/0x1280
__sys_connect+0x1a3/0x260
__x64_sys_connect+0x6e/0xb0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
check_prev_add+0xe9/0xc70
__lock_acquire+0x1457/0x1df0
lock_acquire+0xf7/0x2c0
lock_sock_nested+0x36/0xd0
sco_connect_cfm+0x358/0x8d0
hci_sync_conn_complete_evt+0x3d3/0x8e0
hci_event_packet+0x74f/0xb10
hci_rx_work+0x398/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30other info that might help us debug this:
...
BUG: sleeping function called from invalid context at net/core/sock.c:3782
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 117, name: kworker/u5:2preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
CPU: 0 UID: 0 PID: 117 Comm: kworker/u5:2 Not tainted 7.0.0-rc2-gf3185b64cf7e #1 PREEMPT(lazy) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Workqueue: hci0 hci_rx_work Call Trace: <TASK> dump_stack_lvl+0x49/0x60 __might_resched+0x2ea/0x500 lock_sock_nested+0x47/0xd0 ? sco_connect_cfm+0x358/0x8d0 sco_connect_cfm+0x358/0x8d0 ? hci_debugfs_create_conn+0x190/0x210 ? __pfx_sco_connect_cfm+0x10/0x10 hci_sync_conn_complete_evt+0x3d3/0x8e0 hci_event_packet+0x74f/0xb10 ? __pfx_hci_sync_conn_complete_evt+0x10/0x10 ? __pfx_hci_event_packet+0x10/0x10 ? mark_held_locks+0x49/0x80 ? lockdep_hardirqs_on_prepare+0xd4/0x180 ? _raw_spin_unlock_irqrestore+0x2c/0x50 hci_rx_work+0x398/0xd00 process_scheduled_works+0xb16/0x1ac0 ? __pfx_process_scheduled_works+0x10/0x10 ? lock_acquire+0xf7/0x2c0 ? lock_is_held_type+0x9b/0x110 ? __pfx_hci_rx_work+0x10/0x10 worker_thread+0x4ff/0xba0 ? _raw_spin_unlock_irqrestore+0x2c/0x50 ? __pfx_worker_thread+0x10/0x10 kthread+0x368/0x490 ? _raw_spin_unlock_irq+0x23/0x40 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x498/0x7e0 ? __pfx_ret_from_fork+0x10/0x10 ? __switch_to+0x9e4/0xe50 ? __switch_to_asm+0x32/0x60
...
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.758 seconds Mesh - Send cancel - 2 Timed out 1.995 seconds
##############################
Test: TestRunner_6lowpan-tester - FAIL
Desc: Run 6lowpan-tester with test-runner
Output:
WARNING: possible circular locking dependency detected 7.0.0-rc2-gf3185b64cf7e #1 Not tainted
------------------------------------------------------
kworker/0:0/9 is trying to acquire lock:ffff8880026d8940 ((wq_completion)hci0#2){+.+.}-{0:0}, at: touch_wq_lockdep_map+0x75/0x180
but task is already holding lock:ffffffffbaa4d720 (rtnl_mutex){+.+.}-{4:4}, at: lowpan_unregister_netdev+0xd/0x30
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (rtnl_mutex){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
lowpan_register_netdev+0x11/0x30
chan_ready_cb+0x836/0xd00
l2cap_recv_frame+0x6a06/0x8920
l2cap_recv_acldata+0x790/0xdf0
hci_rx_work+0x500/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30-> #3 (&chan->lock#3/1){+.+.}-{4:4}:
lock_acquire+0xf7/0x2c0
__mutex_lock+0x16b/0x1fc0
l2cap_chan_connect+0x74e/0x1980
lowpan_control_write+0x523/0x660
full_proxy_write+0x10b/0x190
vfs_write+0x1c0/0xf60
ksys_write+0xf1/0x1d0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c-> #2 (&conn->lock){+.+.}-{4:4}:
...
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
https://github.com/bluez/bluetooth-next/pull/63
---
Regards,
Linux Bluetooth