mm/mempolicy: fix memory leak in weighted_interleave_auto_store()
Subsystems (2)
PATCH 1/1 mm/mempolicy: fix memory leak in weighted_interleave_auto_store()
From: Jackie Liu <[email protected]>
Add the missing kfree(new_wi_state) when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto == false), the function returns early without freeing new_wi_state allocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.
--- mm/mempolicy.c | 1 + 1 file changed, 1 insertion(+)
mm/mempolicy.c +1 -0
@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);return count; }
Signature · 1 line
2.51.1
Quoted 1 line · On Tue, 31 Mar 2026 18:07:40 +0800 Jackie Liu <[email protected]> wrote:
From: Jackie Liu <[email protected]>
Hi Jackie,
Thank you for the patch! Wow!! This is a great catch. As you note, the trigger for this memory leak doesn't seem too difficult either.
Everything looks good, thank you! Have a great day : -)
Quoted 27 lines
Add the missing
kfree(new_wi_state)when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto== false), the function returns early without freeingnew_wi_stateallocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.Fixes e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")Signed-off-by Jackie Liu <[email protected]>--- mm/mempolicy.c | 1 + 1 file changed, 1 insertion(+)mm/mempolicy.c +1
-0@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);return count; }Signature · 1 line
2.51.1
Hi Jackie
Quoted 20 lines · Jackie Liu
From: Jackie Liu <[email protected]>
Add the missing
kfree(new_wi_state)when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto== false), the function returns early without freeingnew_wi_stateallocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.Fixes e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")Signed-off-by Jackie Liu <[email protected]>--- mm/mempolicy.c | 1 + 1 file changed, 1 insertion(+)mm/mempolicy.c +0
-0
mm/mempolicy.c static ssize_t weighted_interleave_auto_store(struct kobject *kobj, · line 3716
Quoted 4 lines
mm/mempolicy.c +1
-0@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);
Good catch—this looks good to me
Reviewed by: Donet Tom <[email protected]>
Quoted 3 lines
mm/mempolicy.c +0
-0return count; }
Quoted 11 lines · Jackie Liu
From: Jackie Liu <[email protected]>
Add the missing
kfree(new_wi_state)when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto== false), the function returns early without freeingnew_wi_stateallocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.Fixes e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")Signed-off-by Jackie Liu <[email protected]>
Quoted 20 lines
--- mm/mempolicy.c | 1 + 1 file changed, 1 insertion(+)mm/mempolicy.c +1
-0@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);return count; }Signature · 1 line
2.51.1
Andrew Morton
maintainerQuoted 15 lines · On Tue, 31 Mar 2026 12:53:40 -0400 Gregory Price <[email protected]> wrote:
Quoted 11 lines · Jackie Liu
From: Jackie Liu <[email protected]>
Add the missing
kfree(new_wi_state)when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto== false), the function returns early without freeingnew_wi_stateallocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.Fixes e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")Signed-off-by Jackie Liu <[email protected]>..
Quoted 10 lines
mm/mempolicy.c static ssize_t weighted_interleave_auto_store(struct kobject *kobj, · line 3719
Quoted 10 lines
mm/mempolicy.c +1
-0@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);return count; }
Thanks all.
Am I correct in believing that triggering this leak requires elevated privileges?
I'll add cc:stable to this and shall queue it for 7.1-rc1. This means (I assume) that its entry into the -stable trees might be a little later than if we were to upstream it immediately.
AI review liked this patch but claims to have found another one:
https://sashiko.dev/#/patchset/[email protected]
Joshua Hahn
reviewerQuoted 30 lines · On Tue, 31 Mar 2026 12:01:10 -0700 Andrew Morton <[email protected]>…
Quoted 15 lines · On Tue, 31 Mar 2026 12:53:40 -0400 Gregory Price <[email protected]> wrote:
Quoted 11 lines · Jackie Liu
From: Jackie Liu <[email protected]>
Add the missing
kfree(new_wi_state)when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto== false), the function returns early without freeingnew_wi_stateallocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.Fixes e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")Signed-off-by Jackie Liu <[email protected]>..
Quoted 10 lines
mm/mempolicy.c static ssize_t weighted_interleave_auto_store(struct kobject *kobj, · line 3719
Quoted 10 lines
mm/mempolicy.c +1
-0@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);return count; }Thanks all.
Quoted 2 lines
Am I correct in believing that triggering this leak requires elevated privileges?
Hello Andrew, I hope you are doing well : -)
Yes indeed, writing to the file requires elevated privileges.
While going to check this out, however, I noticed a different bug which is that the file is no longer called "auto", but called "__auto_type". I suspected this was the result of a newly defined macro, and surely... commit 6cce897a37dc "compiler_types.h: add "auto" as a macro for "__auto_type"" seems to have defined auto to always expand out to __auto_type.
Of course for using the __ATTR(name, permissions, show, store) macro this is bad because writing "auto" there no longer works...
I'll send up a quick fix to just manually write out the name instead. Doing a quick grep for the pattern thankfully seems to only point to this. I do think it is a bit weird to pass a raw, unquoted string into the macro...
Quoted 6 lines
I'll add cc:stable to this and shall queue it for 7.1-rc1. This means (I assume) that its entry into the -stable trees might be a little later than if we were to upstream it immediately.
AI review liked this patch but claims to have found another one:
https://sashiko.dev/#/patchset/[email protected]
Sashiko seems to be correct here. Pretty neat that it was able to catch a related bug when analyzing the correctness of this fix!
I can send up a fix for this one too, or leave it to you Jackie, whichever you prefer! Just let me know : -) I'll go ahead and send a fix for the naming issue though, since that one seems orthogonal to this.
Thank you, and I hope you have a great day!
Joshua
Joshua Hahn
reviewerQuoted 45 lines · On Tue, 31 Mar 2026 12:21:04 -0700 Joshua Hahn <[email protected]> wrote:
Quoted 30 lines · On Tue, 31 Mar 2026 12:01:10 -0700 Andrew Morton <[email protected]>…
Quoted 15 lines · On Tue, 31 Mar 2026 12:53:40 -0400 Gregory Price <[email protected]> wrote:
Quoted 11 lines · Jackie Liu
From: Jackie Liu <[email protected]>
Add the missing
kfree(new_wi_state)when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto== false), the function returns early without freeingnew_wi_stateallocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.Fixes e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")Signed-off-by Jackie Liu <[email protected]>..
Quoted 10 lines
mm/mempolicy.c static ssize_t weighted_interleave_auto_store(struct kobject *kobj, · line 3719
Quoted 10 lines
mm/mempolicy.c +1
-0@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);return count; }Thanks all.
Quoted 2 lines
Am I correct in believing that triggering this leak requires elevated privileges?
Hello Andrew, I hope you are doing well : -)
Yes indeed, writing to the file requires elevated privileges.
While going to check this out, however, I noticed a different bug which is that the file is no longer called "auto", but called "
__auto_type". I suspected this was the result of a newly defined macro, and surely... commit6cce897a37dc"compiler_types.h: add "auto" as a macro for "__auto_type"" seems to have defined auto to always expand out to__auto_type.
Quoted 6 lines
Of course for using the
__ATTR(name, permissions, show, store)macro this is bad because writing "auto" there no longer works...I'll send up a quick fix to just manually write out the name instead. Doing a quick grep for the pattern thankfully seems to only point to this. I do think it is a bit weird to pass a raw, unquoted string into the macro...
(I just want to clarify that I am not suggesting that 6cce897a37dc was incorrect. In hindsight, I should have been more wary about using a name like "auto" when it is already a C keyword)
2026年4月1日 03:21, "Joshua Hahn" <[email protected] mailto:[email protected]?to=%22Joshua%20Hahn%22%20%3Cjoshua.hahnjy%40gmail.com%3E > 写到:
Quoted 59 lines · On Tue, 31 Mar 2026 12:01:10 -0700 Andrew Morton <[email protected]>…
Quoted 32 lines · On Tue, 31 Mar 2026 12:53:40 -0400 Gregory Price <[email protected]> wrote:
Quoted 11 lines · Jackie Liu
From: Jackie Liu <[email protected]>
Add the missing
kfree(new_wi_state)when the auto mode is already set to the requested value. When a user writes "false" to the auto sysfs interface and the current mode is already manual (mode_auto== false), the function returns early without freeingnew_wi_stateallocated at the beginning of the function. This can be triggered repeatedly from userspace, leaking memory on each write.Fixes e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")Signed-off-by Jackie Liu <[email protected]>..
mm/mempolicy.c static ssize_t weighted_interleave_auto_store(struct kobject *kobj, · line 3719
Quoted 10 lines
mm/mempolicy.c +1
-0@@ -3713,6 +3713,7 @@ static ssize_t weighted_interleave_auto_store(struct kobject *kobj, goto update_wi_state;if (input == old_wi_state->mode_auto) {mutex_unlock (&wi_state_lock); +kfree (new_wi_state);return count; }Thanks all.
Quoted 3 lines
Am I correct in believing that triggering this leak requires elevated privileges?
Hello Andrew, I hope you are doing well : -)
Yes indeed, writing to the file requires elevated privileges.
While going to check this out, however, I noticed a different bug which is that the file is no longer called "auto", but called "
__auto_type". I suspected this was the result of a newly defined macro, and surely... commit6cce897a37dc"compiler_types.h: add "auto" as a macro for "__auto_type"" seems to have defined auto to always expand out to__auto_type.Of course for using the
__ATTR(name, permissions, show, store)macro this is bad because writing "auto" there no longer works...I'll send up a quick fix to just manually write out the name instead. Doing a quick grep for the pattern thankfully seems to only point to this. I do think it is a bit weird to pass a raw, unquoted string into the macro...
Quoted 5 lines
I'll add cc:stable to this and shall queue it for 7.1-rc1.
This means (I assume) that its entry into the -stable trees might be a little later than if we were to upstream it immediately.
Quoted 5 lines
Quoted 3 lines
AI review liked this patch but claims to have found another one:
https://sashiko.dev/#/patchset/[email protected]Sashiko seems to be correct here. Pretty neat that it was able to catch a related bug when analyzing the correctness of this fix!
Thank you. I quickly wrote a patch and sent it. Sashiko looks amazing.
The link is https://lore.kernel.org/all/[email protected]/
Please help me review it again.
Signature · 1 line
Jackie Liu
Quoted 8 lines
I can send up a fix for this one too, or leave it to you Jackie, whichever you prefer! Just let me know : -) I'll go ahead and send a fix for the naming issue though, since that one seems orthogonal to this.
Thank you, and I hope you have a great day!
Joshua