staging: rtl8723bs: remove GEN_CMD_CODE macro and callback array
PATCH 1/1 staging: rtl8723bs: remove GEN_CMD_CODE macro and callback array
The GEN_CMD_CODE macro and the rtw_cmd_callback function pointer array add unnecessary layers of indirection and make the code difficult to follow.
Remove the GEN_CMD_CODE macro and replace the function pointer array dispatcher in rtw_cmd_thread() with a switch statement.
--- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 +- drivers/staging/rtl8723bs/core/rtw_cmd.c | 155 ++++++------------ drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 18 +- drivers/staging/rtl8723bs/include/rtw_cmd.h | 154 +++++++++-------- 5 files changed, 134 insertions(+), 201 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -2
@@ -1237,7 +1237,7 @@ u8 rtw_ap_set_pairwise_key(struct adapter *padapter, struct sta_info *psta) goto exit; } -init_h2fwcmd_w_parm_no_rsp (ph2c, psetstakey_para, _SetStaKey_CMD_); +init_h2fwcmd_w_parm_no_rsp (ph2c, psetstakey_para, _SetStaKey); psetstakey_para->algorithm = (u8 )psta->dot118021XPrivacy;
@@ -1300,7 +1300,7 @@ static int rtw_ap_set_key(struct adapter *padapter,memcpy (&psetkeyparm->key[0 ], key, keylen); - pcmd->cmdcode = _SetKey_CMD_; + pcmd->cmdcode = _SetKey; pcmd->parmbuf = (u8 *)psetkeyparm; pcmd->cmdsz = (sizeof (struct setkey_parm )); pcmd->rsp =NULL ;
drivers/staging/rtl8723bs/core/rtw_cmd.c +48 -107
300 lines not on this page · raw message
drivers/staging/rtl8723bs/core/rtw_mlme.c +2 -2
@@ -1881,7 +1881,7 @@ signed int rtw_set_auth(struct adapter *adapter, struct security_priv *psecurity psetauthparm->mode = (unsigned char )psecuritypriv->dot11AuthAlgrthm; - pcmd->cmdcode = _SetAuth_CMD_; + pcmd->cmdcode = _SetAuth; pcmd->parmbuf = (unsigned char *)psetauthparm; pcmd->cmdsz = (sizeof (struct setauth_parm )); pcmd->rsp =NULL ;
@@ -1952,7 +1952,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp goto exit; } - pcmd->cmdcode = _SetKey_CMD_; + pcmd->cmdcode = _SetKey; pcmd->parmbuf = (u8 *)psetkeyparm; pcmd->cmdsz = (sizeof (struct setkey_parm )); pcmd->rsp =NULL ;
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +9 -9
@@ -4391,7 +4391,7 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frameINIT_LIST_HEAD (&pcmd_obj->list); - pcmd_obj->cmdcode =GEN_CMD_CODE (_Set_MLME_EVT); + pcmd_obj->cmdcode = _Set_MLME_EVT; pcmd_obj->cmdsz = cmdsz; pcmd_obj->parmbuf = pevtcmd;
@@ -4444,7 +4444,7 @@ void report_surveydone_event(struct adapter *padapter)INIT_LIST_HEAD (&pcmd_obj->list); - pcmd_obj->cmdcode =GEN_CMD_CODE (_Set_MLME_EVT); + pcmd_obj->cmdcode = _Set_MLME_EVT; pcmd_obj->cmdsz = cmdsz; pcmd_obj->parmbuf = pevtcmd;
@@ -4489,7 +4489,7 @@ void report_join_res(struct adapter *padapter, int res)INIT_LIST_HEAD (&pcmd_obj->list); - pcmd_obj->cmdcode =GEN_CMD_CODE (_Set_MLME_EVT); + pcmd_obj->cmdcode = _Set_MLME_EVT; pcmd_obj->cmdsz = cmdsz; pcmd_obj->parmbuf = pevtcmd;
@@ -4538,7 +4538,7 @@ void report_wmm_edca_update(struct adapter *padapter)INIT_LIST_HEAD (&pcmd_obj->list); - pcmd_obj->cmdcode =GEN_CMD_CODE (_Set_MLME_EVT); + pcmd_obj->cmdcode = _Set_MLME_EVT; pcmd_obj->cmdsz = cmdsz; pcmd_obj->parmbuf = pevtcmd;
@@ -4584,7 +4584,7 @@ void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsiINIT_LIST_HEAD (&pcmd_obj->list); - pcmd_obj->cmdcode =GEN_CMD_CODE (_Set_MLME_EVT); + pcmd_obj->cmdcode = _Set_MLME_EVT; pcmd_obj->cmdsz = cmdsz; pcmd_obj->parmbuf = pevtcmd;
@@ -4635,7 +4635,7 @@ void report_add_sta_event(struct adapter *padapter, unsigned char *MacAddr, intINIT_LIST_HEAD (&pcmd_obj->list); - pcmd_obj->cmdcode =GEN_CMD_CODE (_Set_MLME_EVT); + pcmd_obj->cmdcode = _Set_MLME_EVT; pcmd_obj->cmdsz = cmdsz; pcmd_obj->parmbuf = pevtcmd;
@@ -5085,7 +5085,7 @@ void survey_timer_hdl(struct timer_list *t)return ; } -init_h2fwcmd_w_parm_no_rsp (ph2c, psurveyPara,GEN_CMD_CODE (_SiteSurvey)); +init_h2fwcmd_w_parm_no_rsp (ph2c, psurveyPara, _SiteSurvey);rtw_enqueue_cmd (pcmdpriv, ph2c); } }
@@ -5696,7 +5696,7 @@ u8 chk_bmc_sleepq_cmd(struct adapter *padapter) goto exit; } -init_h2fwcmd_w_parm_no_parm_rsp (ph2c,GEN_CMD_CODE (_ChkBMCSleepq)); +init_h2fwcmd_w_parm_no_parm_rsp (ph2c, _ChkBMCSleepq); res =rtw_enqueue_cmd (pcmdpriv, ph2c);
@@ -5734,7 +5734,7 @@ u8 set_tx_beacon_cmd(struct adapter *padapter) pmlmeinfo->hidden_ssid_mode); ptxBeacon_parm->network.ie_length += len_diff; -init_h2fwcmd_w_parm_no_rsp (ph2c, ptxBeacon_parm,GEN_CMD_CODE (_TX_Beacon)); +init_h2fwcmd_w_parm_no_rsp (ph2c, ptxBeacon_parm, _TX_Beacon); res =rtw_enqueue_cmd (pcmdpriv, ph2c);
drivers/staging/rtl8723bs/include/rtw_cmd.h +73 -81
167 lines not on this page · raw message
Signature · 1 line
2.53.0
Quoted 9 lines · Xiyuan Guo
The
GEN_CMD_CODEmacro and thertw_cmd_callbackfunction pointer array add unnecessary layers of indirection and make the code difficult to follow.Remove the
GEN_CMD_CODEmacro and replace the function pointer array dispatcher inrtw_cmd_thread()with a switch statement.Signed-off-by Xiyuan Guo <[email protected]>---
Can't compile it :( Please compile driver with 'make M=drivers/staging/rtl8723bs' before sending your patch.
Quoted 29 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +19
-9/* call callback function for post-processed */ -if (pcmd->cmdcode <ARRAY_SIZE (rtw_cmd_callback)) { - pcmd_callback = rtw_cmd_callback[pcmd->cmdcode].callback; -if (!pcmd_callback) { -rtw_free_cmd_obj (pcmd); - }else { -/* todo: !!! fill rsp_buf to pcmd->rsp if (pcmd->rsp!= NULL) */ -pcmd_callback (pcmd->padapter, pcmd);/* need consider that free cmd_obj in rtw_cmd_callback */ - } - }else { +switch (pcmd->cmdcode) { +case _Read_BBREG: +case _Read_RFREG: +rtw_getbbrfreg_cmdrsp_callback (padapter, pcmd); +break ; +case _JoinBss: +rtw_joinbss_cmd_callback (padapter, pcmd); +break ; +case _DisConnect: +rtw_disassoc_cmd_callback (padapter, pcmd); +break ; +case _CreateBss: +rtw_createbss_cmd_callback (padapter, pcmd); +break ; +case _SiteSurvey: +rtw_survey_cmd_callback (padapter, pcmd); +break ; +case _SetStaKey: +rtw_setstaKey_cmdrsp_callback (padapter, pcmd);
drivers/staging/rtl8723bs/core/rtw_cmd.c int rtw_cmd_thread(void *context) · line 434
Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +6
-0+break ; +case _SetAssocSta: +rtw_setassocsta_cmdrsp_callback (padapter, pcmd); +break ; +default :rtw_free_cmd_obj (pcmd); +break ; }flush_signals_thread (); goto _next;
You are deleting a TODO here.
Quoted 63 lines
drivers/staging/rtl8723bs/include/rtw_cmd.h +63
-0+ _Read_MACREG,/*0*/ + _Write_MACREG, + _Read_BBREG, + _Write_BBREG, + _Read_RFREG, + _Write_RFREG,/*5*/ + _Read_EEPROM, + _Write_EEPROM, + _Read_EFUSE, + _Write_EFUSE, + + _Read_CAM,/*10*/ + _Write_CAM, + _setBCNITV, + _setMBIDCFG, + _JoinBss,/*14*/ + _DisConnect,/*15*/ + _CreateBss, + _SetOpMode, + _SiteSurvey,/*18*/ + _SetAuth, + + _SetKey,/*20*/ + _SetStaKey, + _SetAssocSta, + _DelAssocSta, + _SetStaPwrState, + _SetBasicRate,/*25*/ + _GetBasicRate, + _SetDataRate, + _GetDataRate, + _SetPhyInfo, + + _GetPhyInfo,/*30*/ + _SetPhy, + _GetPhy, + _readRssi, + _readGain, + _SetAtim,/*35*/ + _SetPwrMode, + _JoinbssRpt, + _SetRaTable, + _GetRaTable, + + _GetCCXReport,/*40*/ + _GetDTMReport, + _GetTXRateStatistics, + _SetUsbSuspend, + _SetH2cLbk, + _AddBAReq,/*45*/ + _SetChannel,/*46*/ + _SetTxPower, + _SwitchAntenna, + _SetCrystalCap, + _SetSingleCarrierTx,/*50*/ + + _SetSingleToneTx,/*51*/ + _SetCarrierSuppressionTx, + _SetContinuousTx, + _SwitchBandwidth,/*54*/ + _TX_Beacon,/*55*/ + + _Set_MLME_EVT, /*56*/
drivers/staging/rtl8723bs/include/rtw_cmd.h extern void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct c · line 697
Quoted 10 lines
drivers/staging/rtl8723bs/include/rtw_cmd.h +10
-0+ _Set_Drv_Extra,/*57*/ + _Set_H2C_MSG,/*58*/ + + _SetChannelPlan,/*59*/ + + _SetChannelSwitch,/*60*/ + _TDLS,/*61*/ + _ChkBMCSleepq,/*62*/ + + _RunInThreadCMD, /*63*/
Why not use snake case instead?
Thanks,
Bera
kernel test robot
build botkernel test robot noticed the following build warnings:
Hi Xiyuan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Xiyuan-Guo/staging-rtl8723bs-remove-GEN_CMD_CODE-macro-and-callback-array/20260403-054141 base: staging/staging-testing patch link: https://lore.kernel.org/r/20260401000818.51141-1-tommyguo039%40gmail.com patch subject: [PATCH v1] staging: rtl8723bs: remove GEN_CMD_CODE macro and callback array config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260403/[email protected]/config) compiler: nios2-linux-gcc (GCC) 11.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260403/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
drivers/staging/rtl8723bs/core/rtw_cmd.c: In function 'rtw_cmd_thread':
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:305:16: warning: unused variable 'pcmd_callback' [-Wunused-variable]
305 | void (*pcmd_callback)(struct adapter *dev, struct cmd_obj *pcmd);
| ^~~~~~~~~~~~~vim +/pcmd_callback +305 drivers/staging/rtl8723bs/core/rtw_cmd.c
554c0a3abf216c Hans de Goede 2017-03-29 298
554c0a3abf216c Hans de Goede 2017-03-29 299 int rtw_cmd_thread(void *context)
554c0a3abf216c Hans de Goede 2017-03-29 300 {
554c0a3abf216c Hans de Goede 2017-03-29 301 u8 ret;
554c0a3abf216c Hans de Goede 2017-03-29 302 struct cmd_obj *pcmd;
d698b0a0965681 YueHaibing 2019-07-31 303 u8 *pcmdbuf;
554c0a3abf216c Hans de Goede 2017-03-29 304 u8 (*cmd_hdl)(struct adapter *padapter, u8 *pbuf);
554c0a3abf216c Hans de Goede 2017-03-29 @305 void (*pcmd_callback)(struct adapter *dev, struct cmd_obj *pcmd);
529d87b44da777 Himanshu Jha 2017-08-28 306 struct adapter *padapter = context;
53303e7a1f6eec Kushal Kothari 2021-10-23 307 struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
554c0a3abf216c Hans de Goede 2017-03-29 308 struct drvextra_cmd_parm *extra_parm = NULL;
554c0a3abf216c Hans de Goede 2017-03-29 309
8209ab0f9bf97f Philipp Hortmann 2024-11-03 310 allow_signal(SIGTERM);
554c0a3abf216c Hans de Goede 2017-03-29 311
554c0a3abf216c Hans de Goede 2017-03-29 312 pcmdbuf = pcmdpriv->cmd_buf;
554c0a3abf216c Hans de Goede 2017-03-29 313
554c0a3abf216c Hans de Goede 2017-03-29 314 pcmdpriv->stop_req = 0;
53303e7a1f6eec Kushal Kothari 2021-10-23 315 atomic_set(&pcmdpriv->cmdthd_running, true);
09a8ea34cf431b Arnd Bergmann 2018-12-10 316 complete(&pcmdpriv->terminate_cmdthread_comp);
554c0a3abf216c Hans de Goede 2017-03-29 317
554c0a3abf216c Hans de Goede 2017-03-29 318 while (1) {
09a8ea34cf431b Arnd Bergmann 2018-12-10 319 if (wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp)) {
79df841b435018 Fabio Aiuto 2021-04-15 320 netdev_dbg(padapter->pnetdev,
79df841b435018 Fabio Aiuto 2021-04-15 321 FUNC_ADPT_FMT " wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp) return != 0, break\n",
79df841b435018 Fabio Aiuto 2021-04-15 322 FUNC_ADPT_ARG(padapter));
554c0a3abf216c Hans de Goede 2017-03-29 323 break;
554c0a3abf216c Hans de Goede 2017-03-29 324 }
554c0a3abf216c Hans de Goede 2017-03-29 325
cf8f6446bb9f03 Kushal Kothari 2021-10-20 326 if (padapter->bDriverStopped || padapter->bSurpriseRemoved) {
79df841b435018 Fabio Aiuto 2021-04-15 327 netdev_dbg(padapter->pnetdev,
79df841b435018 Fabio Aiuto 2021-04-15 328 "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n",
79df841b435018 Fabio Aiuto 2021-04-15 329 __func__, padapter->bDriverStopped,
79df841b435018 Fabio Aiuto 2021-04-15 330 padapter->bSurpriseRemoved, __LINE__);
554c0a3abf216c Hans de Goede 2017-03-29 331 break;
554c0a3abf216c Hans de Goede 2017-03-29 332 }
554c0a3abf216c Hans de Goede 2017-03-29 333
554c0a3abf216c Hans de Goede 2017-03-29 334 if (pcmdpriv->stop_req) {
79df841b435018 Fabio Aiuto 2021-04-15 335 netdev_dbg(padapter->pnetdev,
79df841b435018 Fabio Aiuto 2021-04-15 336 FUNC_ADPT_FMT " stop_req:%u, break\n",
79df841b435018 Fabio Aiuto 2021-04-15 337 FUNC_ADPT_ARG(padapter),
79df841b435018 Fabio Aiuto 2021-04-15 338 pcmdpriv->stop_req);
554c0a3abf216c Hans de Goede 2017-03-29 339 break;
554c0a3abf216c Hans de Goede 2017-03-29 340 }
554c0a3abf216c Hans de Goede 2017-03-29 341
6206fdb4f30ba1 Fabio Aiuto 2021-04-07 342 if (list_empty(&pcmdpriv->cmd_queue.queue))
554c0a3abf216c Hans de Goede 2017-03-29 343 continue;
554c0a3abf216c Hans de Goede 2017-03-29 344
13aefa65bc6a63 Fabio Aiuto 2021-04-04 345 if (rtw_register_cmd_alive(padapter) != _SUCCESS)
554c0a3abf216c Hans de Goede 2017-03-29 346 continue;
554c0a3abf216c Hans de Goede 2017-03-29 347
554c0a3abf216c Hans de Goede 2017-03-29 348 _next:
cf8f6446bb9f03 Kushal Kothari 2021-10-20 349 if (padapter->bDriverStopped || padapter->bSurpriseRemoved) {
79df841b435018 Fabio Aiuto 2021-04-15 350 netdev_dbg(padapter->pnetdev,
79df841b435018 Fabio Aiuto 2021-04-15 351 "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n",
79df841b435018 Fabio Aiuto 2021-04-15 352 __func__, padapter->bDriverStopped,
79df841b435018 Fabio Aiuto 2021-04-15 353 padapter->bSurpriseRemoved, __LINE__);
554c0a3abf216c Hans de Goede 2017-03-29 354 break;
554c0a3abf216c Hans de Goede 2017-03-29 355 }
554c0a3abf216c Hans de Goede 2017-03-29 356
554c0a3abf216c Hans de Goede 2017-03-29 357 pcmd = rtw_dequeue_cmd(pcmdpriv);
554c0a3abf216c Hans de Goede 2017-03-29 358 if (!pcmd) {
554c0a3abf216c Hans de Goede 2017-03-29 359 rtw_unregister_cmd_alive(padapter);
554c0a3abf216c Hans de Goede 2017-03-29 360 continue;
554c0a3abf216c Hans de Goede 2017-03-29 361 }
554c0a3abf216c Hans de Goede 2017-03-29 362
92576c84c8c608 Manuel Palenzuela 2020-10-29 363 if (rtw_cmd_filter(pcmdpriv, pcmd) == _FAIL) {
554c0a3abf216c Hans de Goede 2017-03-29 364 pcmd->res = H2C_DROPPED;
554c0a3abf216c Hans de Goede 2017-03-29 365 goto post_process;
554c0a3abf216c Hans de Goede 2017-03-29 366 }
554c0a3abf216c Hans de Goede 2017-03-29 367
554c0a3abf216c Hans de Goede 2017-03-29 368 pcmdpriv->cmd_issued_cnt++;
554c0a3abf216c Hans de Goede 2017-03-29 369
046bd5c9c2833f Ross Schmidt 2020-10-03 370 pcmd->cmdsz = round_up((pcmd->cmdsz), 4);
554c0a3abf216c Hans de Goede 2017-03-29 371
554c0a3abf216c Hans de Goede 2017-03-29 372 memcpy(pcmdbuf, pcmd->parmbuf, pcmd->cmdsz);
554c0a3abf216c Hans de Goede 2017-03-29 373
554c0a3abf216c Hans de Goede 2017-03-29 374 if (pcmd->cmdcode < ARRAY_SIZE(wlancmds)) {
554c0a3abf216c Hans de Goede 2017-03-29 375 cmd_hdl = wlancmds[pcmd->cmdcode].h2cfuns;
554c0a3abf216c Hans de Goede 2017-03-29 376
554c0a3abf216c Hans de Goede 2017-03-29 377 if (cmd_hdl) {
554c0a3abf216c Hans de Goede 2017-03-29 378 ret = cmd_hdl(pcmd->padapter, pcmdbuf);
554c0a3abf216c Hans de Goede 2017-03-29 379 pcmd->res = ret;
554c0a3abf216c Hans de Goede 2017-03-29 380 }
554c0a3abf216c Hans de Goede 2017-03-29 381
554c0a3abf216c Hans de Goede 2017-03-29 382 pcmdpriv->cmd_seq++;
554c0a3abf216c Hans de Goede 2017-03-29 383 } else {
554c0a3abf216c Hans de Goede 2017-03-29 384 pcmd->res = H2C_PARAMETERS_ERROR;
554c0a3abf216c Hans de Goede 2017-03-29 385 }
554c0a3abf216c Hans de Goede 2017-03-29 386
554c0a3abf216c Hans de Goede 2017-03-29 387 cmd_hdl = NULL;
554c0a3abf216c Hans de Goede 2017-03-29 388
554c0a3abf216c Hans de Goede 2017-03-29 389 post_process:
554c0a3abf216c Hans de Goede 2017-03-29 390
53303e7a1f6eec Kushal Kothari 2021-10-23 391 if (mutex_lock_interruptible(&pcmd->padapter->cmdpriv.sctx_mutex) == 0) {
554c0a3abf216c Hans de Goede 2017-03-29 392 if (pcmd->sctx) {
79df841b435018 Fabio Aiuto 2021-04-15 393 netdev_dbg(padapter->pnetdev,
79df841b435018 Fabio Aiuto 2021-04-15 394 FUNC_ADPT_FMT " pcmd->sctx\n",
554c0a3abf216c Hans de Goede 2017-03-29 395 FUNC_ADPT_ARG(pcmd->padapter));
554c0a3abf216c Hans de Goede 2017-03-29 396
554c0a3abf216c Hans de Goede 2017-03-29 397 if (pcmd->res == H2C_SUCCESS)
554c0a3abf216c Hans de Goede 2017-03-29 398 rtw_sctx_done(&pcmd->sctx);
554c0a3abf216c Hans de Goede 2017-03-29 399 else
554c0a3abf216c Hans de Goede 2017-03-29 400 rtw_sctx_done_err(&pcmd->sctx, RTW_SCTX_DONE_CMD_ERROR);
554c0a3abf216c Hans de Goede 2017-03-29 401 }
53303e7a1f6eec Kushal Kothari 2021-10-23 402 mutex_unlock(&pcmd->padapter->cmdpriv.sctx_mutex);
554c0a3abf216c Hans de Goede 2017-03-29 403 }
554c0a3abf216c Hans de Goede 2017-03-29 404
554c0a3abf216c Hans de Goede 2017-03-29 405 /* call callback function for post-processed */
933201cba4056f Xiyuan Guo 2026-03-31 406 switch (pcmd->cmdcode) {
933201cba4056f Xiyuan Guo 2026-03-31 407 case _Read_BBREG:
933201cba4056f Xiyuan Guo 2026-03-31 408 case _Read_RFREG:
933201cba4056f Xiyuan Guo 2026-03-31 409 rtw_getbbrfreg_cmdrsp_callback(padapter, pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 410 break;
933201cba4056f Xiyuan Guo 2026-03-31 411 case _JoinBss:
933201cba4056f Xiyuan Guo 2026-03-31 412 rtw_joinbss_cmd_callback(padapter, pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 413 break;
933201cba4056f Xiyuan Guo 2026-03-31 414 case _DisConnect:
933201cba4056f Xiyuan Guo 2026-03-31 415 rtw_disassoc_cmd_callback(padapter, pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 416 break;
933201cba4056f Xiyuan Guo 2026-03-31 417 case _CreateBss:
933201cba4056f Xiyuan Guo 2026-03-31 418 rtw_createbss_cmd_callback(padapter, pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 419 break;
933201cba4056f Xiyuan Guo 2026-03-31 420 case _SiteSurvey:
933201cba4056f Xiyuan Guo 2026-03-31 421 rtw_survey_cmd_callback(padapter, pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 422 break;
933201cba4056f Xiyuan Guo 2026-03-31 423 case _SetStaKey:
933201cba4056f Xiyuan Guo 2026-03-31 424 rtw_setstaKey_cmdrsp_callback(padapter, pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 425 break;
933201cba4056f Xiyuan Guo 2026-03-31 426 case _SetAssocSta:
933201cba4056f Xiyuan Guo 2026-03-31 427 rtw_setassocsta_cmdrsp_callback(padapter, pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 428 break;
933201cba4056f Xiyuan Guo 2026-03-31 429 default:
554c0a3abf216c Hans de Goede 2017-03-29 430 rtw_free_cmd_obj(pcmd);
933201cba4056f Xiyuan Guo 2026-03-31 431 break;
554c0a3abf216c Hans de Goede 2017-03-29 432 }
554c0a3abf216c Hans de Goede 2017-03-29 433 flush_signals_thread();
554c0a3abf216c Hans de Goede 2017-03-29 434 goto _next;
554c0a3abf216c Hans de Goede 2017-03-29 435 }
554c0a3abf216c Hans de Goede 2017-03-29 436
554c0a3abf216c Hans de Goede 2017-03-29 437 /* free all cmd_obj resources */
554c0a3abf216c Hans de Goede 2017-03-29 438 do {
554c0a3abf216c Hans de Goede 2017-03-29 439 pcmd = rtw_dequeue_cmd(pcmdpriv);
cd1f1450092216 Michael Straube 2021-08-29 440 if (!pcmd) {
554c0a3abf216c Hans de Goede 2017-03-29 441 rtw_unregister_cmd_alive(padapter);
554c0a3abf216c Hans de Goede 2017-03-29 442 break;
554c0a3abf216c Hans de Goede 2017-03-29 443 }
554c0a3abf216c Hans de Goede 2017-03-29 444
933201cba4056f Xiyuan Guo 2026-03-31 445 if (pcmd->cmdcode == _Set_Drv_Extra) {
554c0a3abf216c Hans de Goede 2017-03-29 446 extra_parm = (struct drvextra_cmd_parm *)pcmd->parmbuf;
8f870aab80b041 Manuel Palenzuela 2020-10-28 447 if (extra_parm->pbuf && extra_parm->size > 0)
554c0a3abf216c Hans de Goede 2017-03-29 448 kfree(extra_parm->pbuf);
554c0a3abf216c Hans de Goede 2017-03-29 449 }
554c0a3abf216c Hans de Goede 2017-03-29 450
554c0a3abf216c Hans de Goede 2017-03-29 451 rtw_free_cmd_obj(pcmd);
554c0a3abf216c Hans de Goede 2017-03-29 452 } while (1);
554c0a3abf216c Hans de Goede 2017-03-29 453
09a8ea34cf431b Arnd Bergmann 2018-12-10 454 complete(&pcmdpriv->terminate_cmdthread_comp);
53303e7a1f6eec Kushal Kothari 2021-10-23 455 atomic_set(&pcmdpriv->cmdthd_running, false);
554c0a3abf216c Hans de Goede 2017-03-29 456
501c88722797a1 Eric W. Biederman 2021-10-20 457 return 0;
554c0a3abf216c Hans de Goede 2017-03-29 458 }
554c0a3abf216c Hans de Goede 2017-03-29 459 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki