mm/vmalloc: fix KMSAN uninit-value warning in decay_va_pool_node()
Subsystems (2)
PATCH 1/1 mm/vmalloc: fix KMSAN uninit-value warning in decay_va_pool_node()
KMSAN reported an uninit-value warning when accessing vmap_area->list in decay_va_pool_node():
BUG: KMSAN: uninit-value in __list_del_entry_valid include/linux/list.h:-1 [inline] BUG: KMSAN: uninit-value in __list_del_entry include/linux/list.h:223 [inline] BUG: KMSAN: uninit-value in list_del_init include/linux/list.h:295 [inline] BUG: KMSAN: uninit-value in decay_va_pool_node+0xf78/0x1dd0 mm/vmalloc.c:2255
Uninit was created at:
kmem_cache_alloc_node_noprof+0x3cd/0x12d0 mm/slub.c:4918 alloc_vmap_area+0x327/0x2e30 mm/vmalloc.c:2065
The root cause is that if node_alloc() fail and the va is allocated via kmem_cache_alloc_node() by alloc_vmap_area(), va->list will be uninitialized.
Fix this by explicitly initializing va->list after allocation.
--- mm/vmalloc.c | 1 + 1 file changed, 1 insertion(+)
mm/vmalloc.c +1 -0
@@ -2071,6 +2071,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,* to avoid false negatives. */ kmemleak_scan_area (&va->rb_node,SIZE_MAX , gfp_mask); +INIT_LIST_HEAD (&va->list); } retry:
Signature · 1 line
2.34.1
Uladzislau Rezki
maintainerHello, Qing Wang!
Let me check it close!
Quoted 40 lines · Qing Wang
KMSAN reported an uninit-value warning when accessing
vmap_area->listindecay_va_pool_node():BUG: KMSAN: uninit-value in __list_del_entry_valid include/linux/list.h:-1 [inline] BUG: KMSAN: uninit-value in __list_del_entry include/linux/list.h:223 [inline] BUG: KMSAN: uninit-value in list_del_init include/linux/list.h:295 [inline] BUG: KMSAN: uninit-value in decay_va_pool_node+0xf78/0x1dd0 mm/vmalloc.c:2255Uninit was created at:
kmem_cache_alloc_node_noprof+0x3cd/0x12d0 mm/slub.c:4918 alloc_vmap_area+0x327/0x2e30 mm/vmalloc.c:2065The root cause is that if
node_alloc()fail and the va is allocated viakmem_cache_alloc_node()byalloc_vmap_area(),va->listwill be uninitialized.Fix this by explicitly initializing
va->listafter allocation.Reported-by [email protected]Signed-off-by Qing Wang <[email protected]>--- mm/vmalloc.c | 1 + 1 file changed, 1 insertion(+)mm/vmalloc.c +1
-1@@ -2071,6 +2071,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,* to avoid false negatives. */ kmemleak_scan_area (&va->rb_node,SIZE_MAX , gfp_mask); +INIT_LIST_HEAD (&va->list); } retry: --2.34.1
Signature · 1 line
Uladzislau Rezki
Uladzislau Rezki
maintainerQuoted 12 lines · Qing Wang
KMSAN reported an uninit-value warning when accessing
vmap_area->listindecay_va_pool_node():BUG: KMSAN: uninit-value in __list_del_entry_valid include/linux/list.h:-1 [inline] BUG: KMSAN: uninit-value in __list_del_entry include/linux/list.h:223 [inline] BUG: KMSAN: uninit-value in list_del_init include/linux/list.h:295 [inline] BUG: KMSAN: uninit-value in decay_va_pool_node+0xf78/0x1dd0 mm/vmalloc.c:2255Uninit was created at:
kmem_cache_alloc_node_noprof+0x3cd/0x12d0 mm/slub.c:4918 alloc_vmap_area+0x327/0x2e30 mm/vmalloc.c:2065
Quoted 8 lines
The root cause is that if
node_alloc()fail and the va is allocated viakmem_cache_alloc_node()byalloc_vmap_area(),va->listwill be uninitialized.Fix this by explicitly initializing
va->listafter allocation.
I can not access two above links. Are they valid? I would like to have a look at report.
Quoted 10 lines
Signed-off-by Qing Wang <[email protected]>--- mm/vmalloc.c | 1 + 1 file changed, 1 insertion(+)mm/vmalloc.c +0
-0
mm/vmalloc.c static struct vmap_area *alloc_vmap_area(unsigned long size, · line 2076
Quoted 6 lines
mm/vmalloc.c +1
-0@@ -2071,6 +2071,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,* to avoid false negatives. */ kmemleak_scan_area (&va->rb_node,SIZE_MAX , gfp_mask); +INIT_LIST_HEAD (&va->list); }
va->list does not require to be initialized. Because:
spin_lock(&vn->busy.lock); insert_vmap_area(va, &vn->busy.root, &vn->busy.head); spin_unlock(&vn->busy.lock);
when a node is inserted into list_head, its next/prev pointers are properly set by the list_add().
Or, am i missing something?
--
Uladzislau Rezki
Quoted 15 lines · Uladzislau Rezki
Quoted 15 lines
KMSAN reported an uninit-value warning when accessing
vmap_area->listindecay_va_pool_node():BUG: KMSAN: uninit-value in __list_del_entry_valid include/linux/list.h:-1 [inline] BUG: KMSAN: uninit-value in __list_del_entry include/linux/list.h:223 [inline] BUG: KMSAN: uninit-value in list_del_init include/linux/list.h:295 [inline] BUG: KMSAN: uninit-value in decay_va_pool_node+0xf78/0x1dd0 mm/vmalloc.c:2255Uninit was created at:
kmem_cache_alloc_node_noprof+0x3cd/0x12d0 mm/slub.c:4918 alloc_vmap_area+0x327/0x2e30 mm/vmalloc.c:2065The root cause is that if
node_alloc()fail and the va is allocated viakmem_cache_alloc_node()byalloc_vmap_area(),va->listwill be uninitialized.
Quoted 7 lines
Quoted 5 lines
Fix this by explicitly initializing
va->listafter allocation.I can not access two above links. Are they valid? I would like to have a look at report.
I recheck the 'Closes' link and it's valid.
Quoted 23 lines
Quoted 11 lines
Signed-off-by Qing Wang <[email protected]>--- mm/vmalloc.c | 1 + 1 file changed, 1 insertion(+)mm/vmalloc.c +0
-0mm/vmalloc.c static struct vmap_area *alloc_vmap_area(unsigned long size, · line 2076
Quoted 6 lines
mm/vmalloc.c +1
-0@@ -2071,6 +2071,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,* to avoid false negatives. */ kmemleak_scan_area (&va->rb_node,SIZE_MAX , gfp_mask); +INIT_LIST_HEAD (&va->list); }
va->listdoes not require to be initialized. Because:spin_lock(&vn->busy.lock); insert_vmap_area(va, &vn->busy.root, &vn->busy.head); spin_unlock(&vn->busy.lock);
Quoted 7 lines
when a node is inserted into
list_head, its next/prev pointers are properly set by thelist_add().Or, am i missing something?
--
Uladzislau Rezki
First, va->list is inserted into the list_head when insert_vmap_area() calls link_va(). However, if find_va_links() returns NULL, link_va() will not be called, leaving va->list uninitialized.
Second, even if link_va() is called, list_add() will still invoke __list_add_valid() which reads va->list fields (prev/next). Under KMSAN, this will also report a same uninit-value error.
--
Best Regards,
Qing
Quoted 7 lines · Qing Wang
First,
va->listis inserted into thelist_headwheninsert_vmap_area()callslink_va(). However, iffind_va_links()returns NULL,link_va()will not be called, leavingva->listuninitialized.Second, even if
link_va()is called,list_add()will still invoke__list_add_valid()which readsva->listfields (prev/next). Under KMSAN, this will also report a same uninit-value error.
Hi Qing,
While adding INIT_LIST_HEAD(&va->list) in alloc_vmap_area() would indeed silence the KMSAN warning, I'm concerned that it might only be masking a deeper issue rather than fixing the root cause.
It seems that the uninitialized access in decay_va_pool_node() suggests a potential race condition where nodes from a concurrently repopulated pool might be lost or the list structure could be incorrectly overwritten during list_replace_init().
Instead of just initializing the list head to satisfy KMSAN, should we consider modifying decay_va_pool_node() to avoid using list_replace_init() which might drop concurrent repopulate nodes? Perhaps using list_splice() or a proper merge of the leftover VAs would be a more robust fix for the underlying synchronization issue.
What do you and Uladzislau think?
Best regards,
Morduang
Quoted 9 lines · Morduan Zang
While adding
INIT_LIST_HEAD(&va->list)inalloc_vmap_area()would indeed silence the KMSAN warning, I'm concerned that it might only be masking a deeper issue rather than fixing the root cause.It seems that the uninitialized access in
decay_va_pool_node()suggests a potential race condition where nodes from a concurrently repopulated pool might be lost or the list structure could be incorrectly overwritten duringlist_replace_init().
Quoted 5 lines
Instead of just initializing the list head to satisfy KMSAN, should we consider modifying
decay_va_pool_node()to avoid usinglist_replace_init()which might drop concurrent repopulate nodes? Perhaps usinglist_splice()or a proper merge of the leftover VAs would be a more robust fix for the underlying synchronization issue.
Thank you very much for the reminder. I realized that my patch does not fix the real issue(concurrent corruption of the list). Please ignore this patch and let's focus on analyzing this concurrency issue.
---
Best Regards,
Qing
Quoted 15 lines · Uladzislau Rezki
Quoted 15 lines
KMSAN reported an uninit-value warning when accessing
vmap_area->listindecay_va_pool_node():BUG: KMSAN: uninit-value in __list_del_entry_valid include/linux/list.h:-1 [inline] BUG: KMSAN: uninit-value in __list_del_entry include/linux/list.h:223 [inline] BUG: KMSAN: uninit-value in list_del_init include/linux/list.h:295 [inline] BUG: KMSAN: uninit-value in decay_va_pool_node+0xf78/0x1dd0 mm/vmalloc.c:2255Uninit was created at:
kmem_cache_alloc_node_noprof+0x3cd/0x12d0 mm/slub.c:4918 alloc_vmap_area+0x327/0x2e30 mm/vmalloc.c:2065The root cause is that if
node_alloc()fail and the va is allocated viakmem_cache_alloc_node()byalloc_vmap_area(),va->listwill be uninitialized.
Quoted 7 lines
Quoted 5 lines
Fix this by explicitly initializing
va->listafter allocation.I can not access two above links. Are they valid? I would like to have a look at report.
Try to it?
PATCH 1/1 mm/vmalloc: fix KMSAN uninit in decay_va_pool_node list handling
In reply to Qing WangPrevent decay_va_pool_node from overwriting concurrent repopulation of vmap_node pool[i].head while purging. Read/reset pool[i].len under pool_lock and splice leftover vmap_area nodes back into the pool instead of replacing the list.
--- mm/vmalloc.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
mm/vmalloc.c +9 -4
@@ -2233,10 +2233,9 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay)/* Detach the pool, so no-one can access it. */ spin_lock (&vn->pool_lock);list_replace_init (&vn->pool[i].head, &tmp_list); -spin_unlock (&vn->pool_lock); - pool_len = n_decay = vn->pool[i].len;WRITE_ONCE (vn->pool[i].len,0 ); +spin_unlock (&vn->pool_lock);/* Decay a pool by ~25% out of left objects. */ if (!full_decay)
@@ -2259,8 +2258,14 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay)*/ if (!list_empty (&tmp_list)) {spin_lock (&vn->pool_lock); -list_replace_init (&tmp_list, &vn->pool[i].head); -WRITE_ONCE (vn->pool[i].len, pool_len); +/* +* Merge leftover areas back into the pool rather than +* replacing the whole list. A concurrent allocator can +* repopulate vn->pool[i].head while we are decaying +* tmp_list, and replacing would drop those nodes. +*/ +list_splice_tail_init (&tmp_list, &vn->pool[i].head); +WRITE_ONCE (vn->pool[i].len, vn->pool[i].len + pool_len);spin_unlock (&vn->pool_lock); } }
Signature · 1 line
2.50.1
Uladzislau Rezki
maintainerRe: [PATCH] mm/vmalloc: fix KMSAN uninit in decay_va_pool_node list handling
Quoted 34 lines · chenyichong
Prevent
decay_va_pool_nodefrom overwriting concurrent repopulation ofvmap_nodepool[i].head while purging. Read/reset pool[i].len underpool_lockand splice leftovervmap_areanodes back into the pool instead of replacing the list.Reported-by [email protected]Fixes 7679ba6b36db ("mm: vmalloc: add a shrinker to drain vmap pools")Signed-off-by chenyichong <[email protected]>--- mm/vmalloc.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)mm/vmalloc.c +1
-3@@ -2233,10 +2233,9 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay)/* Detach the pool, so no-one can access it. */ spin_lock (&vn->pool_lock);list_replace_init (&vn->pool[i].head, &tmp_list); -spin_unlock (&vn->pool_lock); - pool_len = n_decay = vn->pool[i].len;WRITE_ONCE (vn->pool[i].len,0 ); +spin_unlock (&vn->pool_lock);/* Decay a pool by ~25% out of left objects. */ if (!full_decay)@@ -2259,8 +2258,14 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay)*/ if (!list_empty (&tmp_list)) {spin_lock (&vn->pool_lock); -list_replace_init (&tmp_list, &vn->pool[i].head);
mm/vmalloc.c decay_va_pool_node(struct vmap_node *vn, bool full_decay) · line 2269
Quoted 10 lines
mm/vmalloc.c +8
-1-WRITE_ONCE (vn->pool[i].len, pool_len); +/* +* Merge leftover areas back into the pool rather than +* replacing the whole list. A concurrent allocator can +* repopulate vn->pool[i].head while we are decaying +* tmp_list, and replacing would drop those nodes. +*/ +list_splice_tail_init (&tmp_list, &vn->pool[i].head); +WRITE_ONCE (vn->pool[i].len, vn->pool[i].len + pool_len);
"A concurrent allocator can repopulate..." - Where is it done? Probably you meant something different.
--
Uladzislau Rezki
Uladzislau Rezki
maintainerRe: [PATCH] mm/vmalloc: fix KMSAN uninit in decay_va_pool_node list handling
Quoted 39 lines · Uladzislau Rezki
Quoted 38 lines · chenyichong
Prevent
decay_va_pool_nodefrom overwriting concurrent repopulation ofvmap_nodepool[i].head while purging. Read/reset pool[i].len underpool_lockand splice leftovervmap_areanodes back into the pool instead of replacing the list.Reported-by [email protected]Fixes 7679ba6b36db ("mm: vmalloc: add a shrinker to drain vmap pools")Signed-off-by chenyichong <[email protected]>--- mm/vmalloc.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)mm/vmalloc.c +4
-4@@ -2233,10 +2233,9 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay)/* Detach the pool, so no-one can access it. */ spin_lock (&vn->pool_lock);list_replace_init (&vn->pool[i].head, &tmp_list); -spin_unlock (&vn->pool_lock); - pool_len = n_decay = vn->pool[i].len;WRITE_ONCE (vn->pool[i].len,0 ); +spin_unlock (&vn->pool_lock);/* Decay a pool by ~25% out of left objects. */ if (!full_decay)@@ -2259,8 +2258,14 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay)*/ if (!list_empty (&tmp_list)) {spin_lock (&vn->pool_lock); -list_replace_init (&tmp_list, &vn->pool[i].head); -WRITE_ONCE (vn->pool[i].len, pool_len); +/* +* Merge leftover areas back into the pool rather than +* replacing the whole list. A concurrent allocator can
Quoted 9 lines
mm/vmalloc.c decay_va_pool_node(struct vmap_node *vn, bool full_decay)
Quoted 6 lines
mm/vmalloc.c +5
-0+* repopulate vn->pool[i].head while we are decaying +* tmp_list, and replacing would drop those nodes. +*/ +list_splice_tail_init (&tmp_list, &vn->pool[i].head); +WRITE_ONCE (vn->pool[i].len, vn->pool[i].len + pool_len);"A concurrent allocator can repopulate..." - Where is it done? Probably you meant something different.
Actually decay_va_pool_node() is not designed to be called concurrently. See the comment:
<snip>
/*
* Attach the pool back if it has been partly decayed.
* Please note, it is supposed that nobody(other contexts)
* can populate the pool therefore a simple list replace
* operation takes place here.
*/
<snip>
but after adding the shrinker it may be called concurrently to free some memory, if high memory pressure occurs. This is not good because we can lose added VAs by the __purge_vmap_area_lazy() helper. So it might leak memory.
That problem has been introduced by the "mm: vmalloc: add a shrinker to drain vmap pools" patch.
IMO, the best what we should do is to follow the design reflected by the comment. It implies that shrinker has to decay holding the vmap_purge_lock mutex.
--
Uladzislau Rezki