Skip to contentSkip to conversation

iommu/generic_pt: disable GCOV for iommu_amdv1.o

PATCH New Konstantin Khorenko 2 participants 7 messages Apr 2 – Apr 9 IOMMU

lore
Share & tools
lore
#0 lore raw

cover iommu/generic_pt: disable GCOV for iommu_amdv1.o

This patch fixes a build failure in drivers/iommu/generic_pt/fmt/iommu_amdv1.o when -fprofile-update=atomic is added to global CFLAGS_GCOV.

This is part of a larger effort to add -fprofile-update=atomic to global CFLAGS_GCOV to fix GCOV counter races that cause crashes on SMP (posted earlier as a combined series):
https://lore.kernel.org/lkml/[email protected]/T/#t

That combined series was split per subsystem as requested by reviewers. The companion patches are:

- net: fix skb_ext BUILD_BUG_ON failures (sent to netdev)
- gcov: add -fprofile-update=atomic globally (sent to gcov/kbuild maintainers, depends on this patch and the net patches)

FIELD_PREP() compile-time checks fail because the entire call chain is __always_inline functions generated by PT_MAKE_LEVELS(), and GCC's .constprop cloning creates new profiled function bodies that bypass __no_profile. Disabling GCOV for the file is the only viable fix.

Konstantin Khorenko (1):
iommu/generic_pt: disable GCOV for iommu_amdv1.o

 drivers/iommu/generic_pt/fmt/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.43.5
#1 lore raw

PATCH 1/1 iommu/generic_pt: disable GCOV for iommu_amdv1.o

With -fprofile-update=atomic in global CFLAGS_GCOV, GCC cannot constant-fold FIELD_PREP() expressions inside deeply inlined page table walker functions. GCC creates .constprop clones of the inline level functions, which get their own GCOV instrumentation that prevents constant evaluation of compile-time checks.

__no_profile cannot be used here because the entire call chain is __always_inline functions generated by PT_MAKE_LEVELS() macro, and GCC's constprop cloning creates new profiled function bodies that bypass the attribute.

Disable GCOV for iommu_amdv1.o to allow BUILD_BUG_ON / FIELD_PREP compile-time checks to succeed.

---
 drivers/iommu/generic_pt/fmt/Makefile | 2 ++
 1 file changed, 2 insertions(+)
drivers/iommu/generic_pt/fmt/Makefile +2 -0
index 976b49ec97dc..0305f7fb9e35 100644
@@ -1,5 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 
+GCOV_PROFILE_iommu_amdv1.o := n
+
 iommu_pt_fmt-$(CONFIG_IOMMU_PT_AMDV1) += amdv1
 iommu_pt_fmt-$(CONFIG_IOMMUFD_TEST) += mock
 
Signature · 1 line
2.43.5
#2 lore raw
Quoted 5 lines · Konstantin Khorenko

With -fprofile-update=atomic in global CFLAGS_GCOV, GCC cannot constant-fold FIELD_PREP() expressions inside deeply inlined page table walker functions. GCC creates .constprop clones of the inline level functions, which get their own GCOV instrumentation that prevents constant evaluation of compile-time checks.

That's hasn't been the issue here. gcc gets confused where it thinks a value is constant so the builtin_constant checks inside FIELD_PREP trigger, but if the value is constant then control flow leading up to it excludes that path ever happening.

Somehow gcov is breaking the elimination of the impossible branch, and I think this is all just compiler bugs.

Also, I thought this was fixed by adding the always_inline?

Jason

#3 lore raw
Quoted 12 lines · Jason Gunthorpe
Quoted 5 lines · Konstantin Khorenko

With -fprofile-update=atomic in global CFLAGS_GCOV, GCC cannot constant-fold FIELD_PREP() expressions inside deeply inlined page table walker functions. GCC creates .constprop clones of the inline level functions, which get their own GCOV instrumentation that prevents constant evaluation of compile-time checks.

That's hasn't been the issue here. gcc gets confused where it thinks a value is constant so the builtin_constant checks inside FIELD_PREP trigger, but if the value is constant then control flow leading up to it excludes that path ever happening.

Quoted 4 lines

Somehow gcov is breaking the elimination of the impossible branch, and I think this is all just compiler bugs.

Also, I thought this was fixed by adding the always_inline?

You are definitely right, Jason, thank you for the hint!

Sending v2 with __always_inline.

--
Konstantin Khorenko

#4 lore raw

v2 cover iommu/generic_pt: fix GCOV build failure for amdv1

In reply to Konstantin Khorenko

This patch fixes a build failure in drivers/iommu/generic_pt/fmt/iommu_amdv1.o when -fprofile-update=atomic is added to global CFLAGS_GCOV.

v2: Use __always_inline instead of disabling GCOV for the file, as
suggested by Jason Gunthorpe. The root cause is that amdv1pt_install_leaf_entry() is "static inline" (not __always_inline), so GCC may choose not to inline it. Without inlining, the compiler cannot see constant arguments at the call site and fails to eliminate the impossible branch in FIELD_PREP(). Forcing inlining via __always_inline solves the problem without losing GCOV coverage.

v1: https://lore.kernel.org/lkml/[email protected]/

This is part of a larger effort to add -fprofile-update=atomic to global CFLAGS_GCOV to fix GCOV counter races that cause crashes on SMP (posted earlier as a combined series):
https://lore.kernel.org/lkml/[email protected]/T/#t

That combined series was split per subsystem as requested by reviewers. The companion patches are:

- net: fix skb_ext BUILD_BUG_ON failures (sent to netdev) [1]
- gcov: add -fprofile-update=atomic globally (sent to gcov/kbuild maintainers, depends on this patch and the net patches) [2]

[1] https://lore.kernel.org/lkml/[email protected]/T/#t
[2] https://lore.kernel.org/lkml/[email protected]/T/#t

Konstantin Khorenko (1):
iommu/generic_pt: use __always_inline for amdv1pt_install_leaf_entry()

 drivers/iommu/generic_pt/fmt/amdv1.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.43.5
#5 lore raw

PATCH v2 1/1 iommu/generic_pt: use __always_inline for amdv1pt_install_leaf_entry()

With -fprofile-update=atomic in CFLAGS_GCOV, GCC fails to eliminate an impossible branch in FIELD_PREP() inside amdv1pt_install_leaf_entry() when the function is merely "static inline". GCC may choose not to inline it, and without seeing the constant arguments at the call site it cannot prove the FIELD_PREP value fits the field.

Change from "static inline" to "static __always_inline" so GCC is forced to inline the function and can see the constant values, allowing dead code elimination of the impossible branch.

---
 drivers/iommu/generic_pt/fmt/amdv1.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/generic_pt/fmt/amdv1.h +1 -1
index 3b2c41d9654d..8d11b08291d7 100644
@@ -191,7 +191,7 @@ static inline enum pt_entry_type amdv1pt_load_entry_raw(struct pt_state *pts)
 }
 #define pt_load_entry_raw amdv1pt_load_entry_raw
 
-static inline void
+static __always_inline void
 amdv1pt_install_leaf_entry(struct pt_state *pts, pt_oaddr_t oa,
 			   unsigned int oasz_lg2,
 			   const struct pt_write_attrs *attrs)
Signature · 1 line
2.43.5
#6 lore raw

Re: [PATCH v2] iommu/generic_pt: use __always_inline for amdv1pt_install_leaf_entry()

Quoted 6 lines · Konstantin Khorenko

With -fprofile-update=atomic in CFLAGS_GCOV, GCC fails to eliminate an impossible branch in FIELD_PREP() inside amdv1pt_install_leaf_entry() when the function is merely "static inline". GCC may choose not to inline it, and without seeing the constant arguments at the call site it cannot prove the FIELD_PREP value fits the field.

Quoted 8 lines

Change from "static inline" to "static __always_inline" so GCC is forced to inline the function and can see the constant values, allowing dead code elimination of the impossible branch.

---
 drivers/iommu/generic_pt/fmt/amdv1.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

It was already merged:

commit 8b72aa5704c77380742346d4ac755b074b7f9eaa

Author: Sherry Yang <[email protected]>
Date:   Thu Mar 26 09:17:19 2026 -0700

iommupt/amdv1: mark amdv1pt_install_leaf_entry as __always_inline

After enabling CONFIG_GCOV_KERNEL and CONFIG_GCOV_PROFILE_ALL, following build failure is observed under GCC 14.2.1: