Skip to contentSkip to conversation

staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c

PATCH In review Hungyu Lin 2 participants 2 messages Apr 4 – Apr 8 Staging

lore
Share & tools
lore

Hungyu Lin

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c

Remove redundant return statements at the end of void functions in rtw_mlme_ext.c.

No functional change.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 ---------------
 1 file changed, 15 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -15
index dad1d95bc325..335f5b2c96f0 100644
@@ -2417,9 +2417,6 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
 
 
 	dump_mgntframe(padapter, pmgntframe);
-
-	return;
-
 }
 
 static int _issue_probereq(struct adapter *padapter,
@@ -3877,9 +3874,6 @@ void site_survey(struct adapter *padapter)
 			issue_action_BSSCoexistPacket(padapter);
 		}
 	}
-
-	return;
-
 }
 
 /* collect bss info from Beacon and Probe request/response frames. */
@@ -4414,9 +4408,6 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frame
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
 
 	pmlmeext->sitesurvey_res.bss_cnt++;
-
-	return;
-
 }
 
 void report_surveydone_event(struct adapter *padapter)
@@ -4458,9 +4449,6 @@ void report_surveydone_event(struct adapter *padapter)
 	psurveydone_evt->bss_cnt = pmlmeext->sitesurvey_res.bss_cnt;
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
-
 }
 
 void report_join_res(struct adapter *padapter, int res)
@@ -4549,9 +4537,6 @@ void report_wmm_edca_update(struct adapter *padapter)
 	pwmm_event->wmm = 0;
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
-
 }
 
 void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsigned short reason)
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 55 lines · Hungyu Lin

Remove redundant return statements at the end of void functions in rtw_mlme_ext.c.

No functional change.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 ---------------
 1 file changed, 15 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -12
index dad1d95bc325..335f5b2c96f0 100644
@@ -2417,9 +2417,6 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
 
 
 	dump_mgntframe(padapter, pmgntframe);
-
-	return;
-
 }
 
 static int _issue_probereq(struct adapter *padapter,
@@ -3877,9 +3874,6 @@ void site_survey(struct adapter *padapter)
 			issue_action_BSSCoexistPacket(padapter);
 		}
 	}
-
-	return;
-
 }
 
 /* collect bss info from Beacon and Probe request/response frames. */
@@ -4414,9 +4408,6 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frame
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
 
 	pmlmeext->sitesurvey_res.bss_cnt++;
-
-	return;
-
 }
 
 void report_surveydone_event(struct adapter *padapter)
@@ -4458,9 +4449,6 @@ void report_surveydone_event(struct adapter *padapter)
 	psurveydone_evt->bss_cnt = pmlmeext->sitesurvey_res.bss_cnt;
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
-
 }
 
 void report_join_res(struct adapter *padapter, int res)

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c void report_wmm_edca_update(struct adapter *padapter) · line 4542

Quoted 9 lines
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -3
@@ -4549,9 +4537,6 @@ void report_wmm_edca_update(struct adapter *padapter)
 	pwmm_event->wmm = 0;
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
-
 }
 
 void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsigned short reason)

LGTM

Best regards,
Luka Gejak