Skip to contentSkip to conversation

smb: client: Remove unnecessary selection of CRYPTO_ECB

PATCH New Eric Biggers 1 participant 1 message Apr 4

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smb: client: Remove unnecessary selection of CRYPTO_ECB

Since the SMB client never uses any ecb(...) algorithm from the crypto_skcipher API, selecting CRYPTO_ECB is unnecessary.

Specifically, it has been unnecessary since commit 06deeec77a5a ("cifs:
Fix smbencrypt() to stop pointing a scatterlist at the stack") in 2016.

---

This patch is targeting the smb client tree.

 fs/smb/client/Kconfig  | 1 -
 fs/smb/client/cifsfs.c | 1 -
 2 files changed, 2 deletions(-)
fs/smb/client/Kconfig +0 -1
index 6d7e178e202db..63831242fddfb 100644
@@ -7,11 +7,10 @@ config CIFS
 	select CRYPTO
 	select CRYPTO_CMAC
 	select CRYPTO_AEAD2
 	select CRYPTO_CCM
 	select CRYPTO_GCM
-	select CRYPTO_ECB
 	select CRYPTO_AES
 	select CRYPTO_LIB_ARC4
 	select CRYPTO_LIB_MD5
 	select CRYPTO_LIB_SHA256
 	select CRYPTO_LIB_SHA512
fs/smb/client/cifsfs.c +0 -1
index 0541706c36c52..2025739f070ac 100644
@@ -2156,11 +2156,10 @@ MODULE_AUTHOR("Steve French");
 MODULE_LICENSE("GPL");	/* combination of LGPL + GPL source behaves as GPL */
 MODULE_DESCRIPTION
 	("VFS to access SMB3 servers e.g. Samba, Macs, Azure and Windows (and "
 	"also older servers complying with the SNIA CIFS Specification)");
 MODULE_VERSION(CIFS_VERSION);
-MODULE_SOFTDEP("ecb");
 MODULE_SOFTDEP("nls");
 MODULE_SOFTDEP("aes");
 MODULE_SOFTDEP("cmac");
 MODULE_SOFTDEP("aead2");
 MODULE_SOFTDEP("ccm");

base-commit: 2febe6e6ee6e34c7754eff3c4d81aa7b0dcb7979

Signature · 1 line
2.53.0