Skip to contentSkip to conversation

scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5

PATCH Applied Eric Biggers 2 participants 3 messages Apr 4 – Apr 14 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5

As far as I can tell, CRYPTO_MD5 has been unnecessary here ever since it was added by commit c899e4ef96f0 ("[SCSI] open-iscsi/linux-iscsi-5
Initiator: Kconfig update") in 2005.

CRYPTO was needed until commit 92186c1455a2 ("scsi: iscsi_tcp: Switch to using the crc32c library"), but is no longer needed.

Remove these unnecessary kconfig selections.

---

This patch is targeting the scsi tree

 drivers/scsi/Kconfig | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/Kconfig +0 -2
index f811ce473c2ab..fc8e8b0bfa391 100644
@@ -302,12 +302,10 @@ if SCSI_LOWLEVEL && SCSI
 
 config ISCSI_TCP
 	tristate "iSCSI Initiator over TCP/IP"
 	depends on SCSI && INET
 	select CRC32
-	select CRYPTO
-	select CRYPTO_MD5
 	select SCSI_ISCSI_ATTRS
 	help
 	 The iSCSI Driver provides a host with the ability to access storage
 	 through an IP network. The driver uses the iSCSI protocol to transport
 	 SCSI requests and responses over a TCP/IP network between the host

base-commit: 2febe6e6ee6e34c7754eff3c4d81aa7b0dcb7979

Signature · 1 line
2.53.0
#1 lore raw

Eric,

Quoted 3 lines

As far as I can tell, CRYPTO_MD5 has been unnecessary here ever since it was added by commit c899e4ef96f0 ("[SCSI] open-iscsi/linux-iscsi-5
Initiator: Kconfig update") in 2005.

Applied to 7.1/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen
#2 lore raw
In reply to Eric Biggers
Quoted 8 lines · Eric Biggers

As far as I can tell, CRYPTO_MD5 has been unnecessary here ever since it was added by commit c899e4ef96f0 ("[SCSI] open-iscsi/linux-iscsi-5
Initiator: Kconfig update") in 2005.

CRYPTO was needed until commit 92186c1455a2 ("scsi: iscsi_tcp: Switch to using the crc32c library"), but is no longer needed.

[...]

Applied to 7.1/scsi-queue, thanks!

[1/1] scsi: iscsi_tcp: Remove unneeded selections of CRYPTO and CRYPTO_MD5

      https://git.kernel.org/mkp/scsi/c/7aa0f56d4b48
Signature · 1 line
Martin K. Petersen