Skip to contentSkip to conversation

tg3: Add PowerEdge R740xd to AER quirk list

PATCH In review Oskar Ray-Frayssinet 2 participants 4 messages Apr 4 – Apr 5

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tg3: Add PowerEdge R740xd to AER quirk list

The PowerEdge R740xd is a variant of the R740 that also triggers a fatal PCIe AER event during system reboot. Add it to the DMI list to apply the same workaround.

Fixes e0efe83ed325 ("tg3: Disable tg3 PCIe AER on system reboot")

---
v2: Also add "R740XD vSAN Ready Node" DMI name as reported in
bugzilla #221279 by Thomas Berger
v1: Add "PowerEdge R740xd" DMI name

 drivers/net/ethernet/broadcom/tg3.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/net/ethernet/broadcom/tg3.c +12 -0
index 73a4b569b03e..2b95c97e8161 100644
@@ -18216,6 +18216,18 @@ static const struct dmi_system_id tg3_restart_aer_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740xd"),
+		},
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "R740XD vSAN Ready Node"),
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
Signature · 1 line
2.43.0
#1 lore raw
Quoted 11 lines · Oskar Ray-Frayssinet

The PowerEdge R740xd is a variant of the R740 that also triggers a fatal PCIe AER event during system reboot. Add it to the DMI list to apply the same workaround.

Fixes e0efe83ed325 ("tg3: Disable tg3 PCIe AER on system reboot")

---
v2: Also add "R740XD vSAN Ready Node" DMI name as reported in
bugzilla #221279 by Thomas Berger
v1: Add "PowerEdge R740xd" DMI name

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

says:

* don’t repost your patches within one 24h period

Quoted 9 lines
drivers/net/ethernet/broadcom/tg3.c +5 -0
@@ -18216,6 +18216,18 @@ static const struct dmi_system_id tg3_restart_aer_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740xd"),
+		},

drivers/net/ethernet/broadcom/tg3.c static const struct dmi_system_id tg3_restart_aer_quirk_table[] = { · line 18233

Quoted 10 lines
drivers/net/ethernet/broadcom/tg3.c +7 -0
+	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "R740XD vSAN Ready Node"),
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),

When you look at tg3_restart_aer_quirk_table[] they are all Dell. Are there any Dell systems which actually work? Would it make sense to mark all Dell systems as broken and enable the quirk? Then there is no need to play whack-a-mole.

Andrew

#2 lore raw
Quoted 3 lines · Andrew Lunn

When you look at tg3_restart_aer_quirk_table[] they are all Dell. Are there any Dell systems which actually work? Would it make sense to mark all Dell systems as broken and enable the quirk?

That's a good point. I don't know if there are Dell systems where the quirk would cause harm. Do you know if it's safe to apply the quirk to all Dell systems, or should we be cautious and keep the per-model approach?

Best regards,
Oskar Ray-Frayssinet

#3 lore raw
Quoted 9 lines · Oskar Ray-Frayssinet
Quoted 3 lines · Andrew Lunn

When you look at tg3_restart_aer_quirk_table[] they are all Dell. Are there any Dell systems which actually work? Would it make sense to mark all Dell systems as broken and enable the quirk?

That's a good point. I don't know if there are Dell systems where the quirk would cause harm. Do you know if it's safe to apply the quirk to all Dell systems, or should we be cautious and keep the per-model approach?

You might want to ask on the PCI list.

As far as i see, with 30 seconds for searching and reading documentation, AER, Advanced Error Reporting is an optional feature of PCIe. Since it is optional, it seems like disabling it during shutdown should not have any negative effects. Except for systems where it actually works, and there are real errors during shutdown and resume. It will be harder to debug such errors since you don't get the advanced error report.

Andrew