Skip to contentSkip to conversation

perf test: Skip sched stats test for !root

PATCH Applied Namhyung Kim 3 participants 4 messages Apr 5 – Apr 6 perf events

lore
Share & tools
lore

Namhyung Kim

author maintainer
#0 lore raw

PATCH 1/1 perf test: Skip sched stats test for !root

Running perf sched stats requires root and it fails to open the schedstat file for regular users. Let's skip the test.

  $ perf sched stats true
  Failed to open /proc/sys/kernel/sched_schedstats
Cc Swapnil Sapkal <[email protected]>
---
 tools/perf/tests/shell/perf_sched_stats.sh | 5 +++++
 1 file changed, 5 insertions(+)
tools/perf/tests/shell/perf_sched_stats.sh +5 -0
index 2b1410b050d04737..41ee41fbf0253d55 100755
@@ -4,6 +4,11 @@
 
 set -e
 
+if [ "$(id -u)" != 0 ]; then
+  echo "[Skip] No root permission"
+  exit 2
+fi
+
 err=0
 test_perf_sched_stats_record() {
   echo "Basic perf sched stats record test"
Signature · 1 line
2.53.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Namhyung Kim

Running perf sched stats requires root and it fails to open the schedstat file for regular users. Let's skip the test.

  $ perf sched stats true
  Failed to open /proc/sys/kernel/sched_schedstats
Cc Swapnil Sapkal <[email protected]>

Thanks,
Ian

Quoted 23 lines
---
 tools/perf/tests/shell/perf_sched_stats.sh | 5 +++++
 1 file changed, 5 insertions(+)
tools/perf/tests/shell/perf_sched_stats.sh +5 -1
index 2b1410b050d04737..41ee41fbf0253d55 100755
@@ -4,6 +4,11 @@
 
 set -e
 
+if [ "$(id -u)" != 0 ]; then
+  echo "[Skip] No root permission"
+  exit 2
+fi
+
 err=0
 test_perf_sched_stats_record() {
   echo "Basic perf sched stats record test"
--

2.53.0

Tested-by on v1 1/1
#2 lore raw
In reply to Namhyung Kim

Hi Namhyung,

Quoted 8 lines · Namhyung Kim

Running perf sched stats requires root and it fails to open the schedstat file for regular users. Let's skip the test.

   $ perf sched stats true
   Failed to open /proc/sys/kernel/sched_schedstats
Cc Swapnil Sapkal <[email protected]>

--
Thanks and Regards,
Swapnil

Quoted 20 lines
---
  tools/perf/tests/shell/perf_sched_stats.sh | 5 +++++
  1 file changed, 5 insertions(+)
tools/perf/tests/shell/perf_sched_stats.sh +5 -0
index 2b1410b050d04737..41ee41fbf0253d55 100755
@@ -4,6 +4,11 @@
 
  set -e
 
+if [ "$(id -u)" != 0 ]; then
+  echo "[Skip] No root permission"
+  exit 2
+fi
+
  err=0
  test_perf_sched_stats_record() {
    echo "Basic perf sched stats record test"