ASoC: rt5640: Handle 0Hz sysclk during stream shutdown
Subsystems (3)
PATCH 1/1 ASoC: rt5640: Handle 0Hz sysclk during stream shutdown
Commit 2458adb8f92a ("SoC: simple-card-utils: set 0Hz to sysclk when shutdown") sends a 0Hz sysclk request during stream shutdown to clear codec rate constraints. The rt5640 codec forwards this 0Hz to clk_set_rate(), which can cause clock controller firmware faults on platforms where MCLK is SoC-driven (e.g. Tegra) and 0Hz falls below the hardware minimum rate.
Handle the 0Hz case by clearing the internal sysclk state and returning early, avoiding the invalid clk_set_rate() call.
---
This is a follow-up to the discussion on the ignore_zero_sysclk flag:
https://patchwork.ozlabs.org/project/linux-tegra/patch/[email protected]/
Instead of adding a framework flag, handle 0Hz directly in the codec as suggested by the reviewers.
--- sound/soc/codecs/rt5640.c | 5 +++++ 1 file changed, 5 insertions(+)
sound/soc/codecs/rt5640.c +5 -0
@@ -1838,6 +1838,11 @@ static int rt5640_set_dai_sysclk(struct snd_soc_dai *dai,unsigned int pll_bit =0 ;int ret; +if (!freq) { + rt5640->sysclk =0 ; +return 0 ; + } +switch (clk_id) {case RT5640_SCLK_S_MCLK : ret =clk_set_rate (rt5640->mclk, freq);
Signature · 1 line
2.17.1
Mark Brown
maintainerQuoted 1 line · Sheetal
ASoC: rt5640: Handle 0Hz sysclk during stream shutdown
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1
Thanks!
[1/1] ASoC: rt5640: Handle 0Hz sysclk during stream shutdown
https://git.kernel.org/broonie/sound/c/247d1c13992d
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark