Skip to contentSkip to conversation

docs: netdev: improve wording of reviewer guidance

PATCH Applied Jakub Kicinski 4 participants 4 messages Apr 6 – Apr 9

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 docs: netdev: improve wording of reviewer guidance

Reword the reviewer guidance based on behavior we see on the list. Steer folks:
- towards sending tags
- away from process issues.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 Documentation/process/maintainer-netdev.rst | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Documentation/process/maintainer-netdev.rst +5 -3
index 3aa13bc2405d..bda93b459a05 100644
@@ -551,10 +551,12 @@ helpful tips please see :ref:`development_advancedtopics_reviews`.
 
 It's safe to assume that netdev maintainers know the community and the level
 of expertise of the reviewers. The reviewers should not be concerned about
-their comments impeding or derailing the patch flow.
+their comments impeding or derailing the patch flow. A Reviewed-by tag
+is understood to mean "I have reviewed this code to the best of my ability"
+rather than "I can attest this code is correct".
 
-Less experienced reviewers are highly encouraged to do more in-depth
-review of submissions and not focus exclusively on trivial or subjective
+Reviewers are highly encouraged to do more in-depth review of submissions
+and not focus exclusively on process issues, trivial or subjective
 matters like code formatting, tags etc.
 
 Testimonials / feedback
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jakub Kicinski

Reword the reviewer guidance based on behavior we see on the list. Steer folks:
- towards sending tags
- away from process issues.

Quoted 9 lines

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 Documentation/process/maintainer-netdev.rst | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by on v1 1/1
#2 lore raw
In reply to Jakub Kicinski
Quoted 29 lines · Jakub Kicinski

Reword the reviewer guidance based on behavior we see on the list. Steer folks:
- towards sending tags
- away from process issues.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 Documentation/process/maintainer-netdev.rst | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Documentation/process/maintainer-netdev.rst +0 -0
index 3aa13bc2405d..bda93b459a05 100644
@@ -551,10 +551,12 @@ helpful tips please see 

:ref:development_advancedtopics_reviews.

It's safe to assume that netdev maintainers know the community and the
level
of expertise of the reviewers. The reviewers should not be concerned
about

Documentation/process/maintainer-netdev.rst +2 -1
-their comments impeding or derailing the patch flow.
+their comments impeding or derailing the patch flow. A Reviewed-by tag
+is understood to mean "I have reviewed this code to the best of my 
Quoted 3 lines

ability"
+rather than "I can attest this code is correct".

I had the same hesitation when starting to review on netdev, unsure if my R-b carried any value. Therefore I appreciate the addition.

Quoted 9 lines
Documentation/process/maintainer-netdev.rst +0 -2
-Less experienced reviewers are highly encouraged to do more in-depth
-review of submissions and not focus exclusively on trivial or 

subjective
+Reviewers are highly encouraged to do more in-depth review of submissions
+and not focus exclusively on process issues, trivial or subjective
matters like code formatting, tags etc.

Testimonials / feedback

#3 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 6 Apr 2026 10:53:34 -0700 you wrote:

Reword the reviewer guidance based on behavior we see on the list. Steer folks:
- towards sending tags
- away from process issues.

[...]

Here is the summary with links:
- [net-next] docs: netdev: improve wording of reviewer guidance

    https://git.kernel.org/netdev/net-next/c/bd5c24e4001d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html