Skip to contentSkip to conversation

media: vpif_capture: fix OF node reference imbalance

PATCH In review Johan Hovold 1 participant 3 messages Apr 7 – Apr 30 1 message not in the archive

Subsystems (3)
Stable branch Media (V4L/DVB) TI DaVinci series media driver
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 media: vpif_capture: fix OF node reference imbalance

The driver reuses the OF node of the parent device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the parent and releasing the child devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available")
Cc [email protected] # 4.13
Cc Kevin Hilman <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/media/platform/ti/davinci/vpif_capture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti/davinci/vpif_capture.c +1 -1
index 15df3ea2f77e..91cb6223561a 100644
@@ -1498,7 +1498,7 @@ vpif_capture_get_pdata(struct platform_device *pdev,
 	 * video ports & endpoints data.
 	 */
 	if (pdev->dev.parent && pdev->dev.parent->of_node)
-		pdev->dev.of_node = pdev->dev.parent->of_node;
+		device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
 	if (!IS_ENABLED(CONFIG_OF) || !pdev->dev.of_node)
 		return pdev->dev.platform_data;
Signature · 1 line
2.52.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw
Quoted 6 lines · Patchwork Integration

Thanks for your patches! Unfortunately the Media CI robot detected some issues:

Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.

Quoted 6 lines

For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/96942177/artifacts/report.htm .

If you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.

It appears the media CI bot is still broken.

Johan

author
#3 lore raw
In reply to Johan Hovold
Quoted 11 lines · Johan Hovold

The driver reuses the OF node of the parent device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the parent and releasing the child devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available")
Cc [email protected] # 4.13
Cc Kevin Hilman <[email protected]>
Signed-off-by Johan Hovold <[email protected]>

---

Can this one be picked up now?

Also here there was some invalid complaint from the media CI bot so just want to make sure it has not been silently rejected.

Johan