Skip to contentSkip to conversation

perf test: Make perf trace enum augmentation tests exclusive

PATCH In review Thomas Richter 2 participants 2 messages Apr 9

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf test: Make perf trace enum augmentation tests exclusive

Running both tests cases 'perf trace enum augmentation tests' and 'perf trace BTF general tests' together causes the first test case to fail:

 # for i in $(seq 5); do \
	./perf test 'perf trace enum augmentation tests' \
	'perf trace BTF general tests'; \
   done
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 #

Test case perf trace enum augmentation tests' fails because the second test case 'perf trace BTF general tests' runs concurrently as can be observed using a ps -ef | grep perf output list on a different window. Both do a perf trace command concurrently.
Make test case 'perf trace enum augmentation tests' exclusive.

 # for i in $(seq 5); do \
	./perf test 'perf trace enum augmentation tests' \
	'perf trace BTF general tests'; \
   done
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 #
---
 tools/perf/tests/shell/trace_btf_enum.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/trace_btf_enum.sh +1 -1
index 03e9f680a4a6..437510d46f58 100755
@@ -1,5 +1,5 @@
 #!/bin/bash
-# perf trace enum augmentation tests
+# perf trace enum augmentation tests (exclusive)
 # SPDX-License-Identifier: GPL-2.0
 
 err=0
Signature · 1 line
2.53.0
Acked-by on v1 1/1
#1 lore raw

Hi Thomas,

Quoted 42 lines · Thomas Richter

Running both tests cases 'perf trace enum augmentation tests' and 'perf trace BTF general tests' together causes the first test case to fail:

 # for i in $(seq 5); do \
        ./perf test 'perf trace enum augmentation tests' \
        'perf trace BTF general tests'; \
   done
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 125: perf trace enum augmentation tests  : Ok
 126: perf trace BTF general tests        : FAILED!
 #

Test case perf trace enum augmentation tests' fails because the second test case 'perf trace BTF general tests' runs concurrently as can be observed using a ps -ef | grep perf output list on a different window. Both do a perf trace command concurrently.
Make test case 'perf trace enum augmentation tests' exclusive.

 # for i in $(seq 5); do \
        ./perf test 'perf trace enum augmentation tests' \
        'perf trace BTF general tests'; \
   done
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 125: perf trace BTF general tests        : Ok
 155: perf trace enum augmentation tests  : Ok
 #
Quoted 2 lines

Thanks,
Howard

Quoted 18 lines
---
 tools/perf/tests/shell/trace_btf_enum.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/trace_btf_enum.sh +1 -2
index 03e9f680a4a6..437510d46f58 100755
@@ -1,5 +1,5 @@
 #!/bin/bash
-# perf trace enum augmentation tests
+# perf trace enum augmentation tests (exclusive)
 # SPDX-License-Identifier: GPL-2.0
 
 err=0
--

2.53.0