f2fs_io: support xattr(large_folio)
PATCH 2/2 f2fs_io: user O_RDONLY for fadvise
In reply to Jaegeuk Kim via Linux-f2fs-develWe don't need O_RDONLY for fadvise.
--- tools/f2fs_io/f2fs_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/f2fs_io/f2fs_io.c +1 -1
@@ -474,7 +474,7 @@ static void do_fadvise(int argc, char **argv, const struct cmd_desc *cmd)exit (1 ); } - fd =xopen (argv[4 ],O_RDWR ,0 ); + fd =xopen (argv[4 ],O_RDONLY ,0 );if (!strcmp (argv[1 ],"willneed" )) { advice =POSIX_FADV_WILLNEED ;
Signature · 8 lines
2.53.0.1213.gd9a14994de-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
PATCH 1/2 f2fs_io: support xattr(large_folio)
[Script]
dd if=/dev/zero of=/mnt/test/test bs=1M count=1024 f2fs_io setxattr user.fadvise 1 /mnt/test/test chmod 0400 /mnt/test/test
sync -f /mnt/test/test
echo 3 > /proc/sys/vm/drop_cachesf2fs_io read 1 0 100000 mmap 0 1 /mnt/test/test f2fs_io get_fadvise /mnt/test/test
[Output]
1024+0 records in
1024+0 records out
1073741824 bytes (1.1 GB, 1.0 GiB) copied, 0.520712 s, 2.1 GB/s
setxattr /mnt/test/test CREATE: name: user.fadvise, value: 1: ret=0
Read 409600000 bytes total_time = 106757 us, BW = 4286 MB/s, IO time = 95577 us, mlock time = 11173 us, print 1 bytes:
00000000 : 00
fadvise=0x1, advise_type: largefolio
--- tools/f2fs_io/f2fs_io.c | 32 ++++++++++++++++++++++++++++++++ tools/f2fs_io/f2fs_io.h | 6 ++++++ 2 files changed, 38 insertions(+)
tools/f2fs_io/f2fs_io.c +32 -0
@@ -2084,6 +2084,7 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd)int ret, len;char *value;unsigned char tmp; +unsigned int tmp_u;if (argc !=4 ) {fputs ("Excess arguments\n\n" , stderr);
@@ -2095,6 +2096,10 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd) tmp =strtoul (argv[2 ],NULL ,0 ); value = (char *)&tmp; len =1 ; + }else if (!strcmp (argv[1 ],F2FS_USER_FADVISE_NAME )) { + tmp_u =strtoul (argv[2 ],NULL ,0 ); + value = (char *)&tmp_u; + len =sizeof (unsigned int ); }else { value = argv[2 ]; len =strlen (value);
@@ -2217,6 +2222,32 @@ static void do_get_advise(int argc, char **argv, const struct cmd_desc *cmd)printf ("\n" ); } +#define get_fadvise_desc "get_fadvise" +#define get_fadvise_help "f2fs_io get_fadvise [file_path]\n\n" + +static void do_get_fadvise (int argc,char **argv,const struct cmd_desc *cmd) +{ +int ret; +unsigned int value; + +if (argc !=2 ) { +fputs ("Excess arguments\n\n" , stderr); +fputs (cmd->cmd_help, stderr); +exit (1 ); + } + + ret =getxattr (argv[1 ],F2FS_USER_FADVISE_NAME , &value,sizeof (value)); +if (ret !=sizeof (value)) { +perror ("getxattr" ); +exit (1 ); + } + +printf ("fadvise=0x%x, advise_type: " , value); +if (value & (1 <<F2FS_XATTR_FADV_LARGEFOLIO )) +printf ("largefolio" ); +printf ("\n" ); +} +#define ftruncate_desc "ftruncate a file"#define ftruncate_help \ "f2fs_io ftruncate [length] [file_path]\n\n" \
@@ -2626,6 +2657,7 @@ const struct cmd_desc cmd_list[] = {CMD (removexattr),CMD (lseek),CMD (get_advise), +CMD (get_fadvise),CMD (ioprio),CMD (ftruncate), CMD(test_create_perf),
tools/f2fs_io/f2fs_io.h +6 -0
@@ -186,6 +186,7 @@ struct fsverity_enable_arg {#define F2FS_IOC_FSSETXATTR FS_IOC_FSSETXATTR#define F2FS_SYSTEM_ADVISE_NAME "system.advise" +#define F2FS_USER_FADVISE_NAME "user.fadvise"#define FADVISE_COLD_BIT 0x01#define FADVISE_LOST_PINO_BIT 0x02#define FADVISE_ENCRYPT_BIT 0x04
@@ -195,6 +196,11 @@ struct fsverity_enable_arg {#define FADVISE_VERITY_BIT 0x40#define FADVISE_TRUNC_BIT 0x80 +/* used for F2FS_USER_FADVISE_NAME */ +enum { +F2FS_XATTR_FADV_LARGEFOLIO , +}; +/* used for F2FS_IOC_IO_PRIO */ enum {F2FS_IOPRIO_WRITE =1 ,/* high write priority */
Signature · 8 lines
2.53.0.1213.gd9a14994de-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH 2/2] f2fs_io: user O_RDONLY for fadvise
In reply to Jaegeuk Kim via Linux-f2fs-develQuoted 2 lines · On Thu, Apr 9, 2026 at 6:47 AM Jaegeuk Kim via Linux-f2fs-devel…
We don't need
O_RDONLYfor fadvise.
We don't need O_RDWR for fadvise.
Quoted 24 lines
Signed-off-by Jaegeuk Kim <[email protected]>--- tools/f2fs_io/f2fs_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/f2fs_io/f2fs_io.c +1
-2@@ -474,7 +474,7 @@ static void do_fadvise(int argc, char **argv, const struct cmd_desc *cmd)exit (1 ); } - fd =xopen (argv[4 ],O_RDWR ,0 ); + fd =xopen (argv[4 ],O_RDONLY ,0 );if (!strcmp (argv[1 ],"willneed" )) { advice =POSIX_FADV_WILLNEED ; --2.53.0.1213.gd9a14994de-goog
Quoted 4 lines
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 114 lines · On Thu, Apr 9, 2026 at 6:48 AM Jaegeuk Kim via Linux-f2fs-devel…
[Script]
dd if=/dev/zero of=/mnt/test/test bs=1M count=1024f2fs_iosetxattr user.fadvise 1/mnt/test/testchmod 0400/mnt/test/test
sync -f/mnt/test/test
echo 3 >/proc/sys/vm/drop_cachesf2fs_ioread 1 0 100000 mmap 0 1/mnt/test/testf2fs_ioget_fadvise/mnt/test/test[Output]
1024+0 records in
1024+0 records out
1073741824 bytes (1.1 GB, 1.0 GiB) copied, 0.520712 s, 2.1 GB/s
setxattr/mnt/test/testCREATE: name: user.fadvise, value: 1: ret=0
Read 409600000 bytestotal_time= 106757 us, BW = 4286 MB/s, IO time = 95577 us, mlock time = 11173 us, print 1 bytes:
00000000 : 00
fadvise=0x1,advise_type: largefolioSigned-off-by Jaegeuk Kim <[email protected]>--- tools/f2fs_io/f2fs_io.c | 32 ++++++++++++++++++++++++++++++++ tools/f2fs_io/f2fs_io.h | 6 ++++++ 2 files changed, 38 insertions(+)tools/f2fs_io/f2fs_io.c +32
-0@@ -2084,6 +2084,7 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd)int ret, len;char *value;unsigned char tmp; +unsigned int tmp_u;if (argc !=4 ) {fputs ("Excess arguments\n\n" , stderr);@@ -2095,6 +2096,10 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd) tmp =strtoul (argv[2 ],NULL ,0 ); value = (char *)&tmp; len =1 ; + }else if (!strcmp (argv[1 ],F2FS_USER_FADVISE_NAME )) { + tmp_u =strtoul (argv[2 ],NULL ,0 ); + value = (char *)&tmp_u; + len =sizeof (unsigned int ); }else { value = argv[2 ]; len =strlen (value);@@ -2217,6 +2222,32 @@ static void do_get_advise(int argc, char **argv, const struct cmd_desc *cmd)printf ("\n" ); } +#define get_fadvise_desc "get_fadvise" +#define get_fadvise_help "f2fs_io get_fadvise [file_path]\n\n" + +static void do_get_fadvise (int argc,char **argv,const struct cmd_desc *cmd) +{ +int ret; +unsigned int value; + +if (argc !=2 ) { +fputs ("Excess arguments\n\n" , stderr); +fputs (cmd->cmd_help, stderr); +exit (1 ); + } + + ret =getxattr (argv[1 ],F2FS_USER_FADVISE_NAME , &value,sizeof (value)); +if (ret !=sizeof (value)) { +perror ("getxattr" ); +exit (1 ); + } + +printf ("fadvise=0x%x, advise_type: " , value); +if (value & (1 <<F2FS_XATTR_FADV_LARGEFOLIO )) +printf ("largefolio" ); +printf ("\n" ); +} +#define ftruncate_desc "ftruncate a file"#define ftruncate_help \ "f2fs_io ftruncate [length] [file_path]\n\n" \@@ -2626,6 +2657,7 @@ const struct cmd_desc cmd_list[] = {CMD (removexattr),CMD (lseek),CMD (get_advise), +CMD (get_fadvise),CMD (ioprio),CMD (ftruncate), CMD(test_create_perf),tools/f2fs_io/f2fs_io.h +6
-1@@ -186,6 +186,7 @@ struct fsverity_enable_arg {#define F2FS_IOC_FSSETXATTR FS_IOC_FSSETXATTR#define F2FS_SYSTEM_ADVISE_NAME "system.advise" +#define F2FS_USER_FADVISE_NAME "user.fadvise"#define FADVISE_COLD_BIT 0x01#define FADVISE_LOST_PINO_BIT 0x02#define FADVISE_ENCRYPT_BIT 0x04@@ -195,6 +196,11 @@ struct fsverity_enable_arg {#define FADVISE_VERITY_BIT 0x40#define FADVISE_TRUNC_BIT 0x80 +/* used for F2FS_USER_FADVISE_NAME */ +enum { +F2FS_XATTR_FADV_LARGEFOLIO , +}; +/* used for F2FS_IOC_IO_PRIO */ enum {F2FS_IOPRIO_WRITE =1 ,/* high write priority */ --
Quoted 3 lines
2.53.0.1213.gd9a14994de-goog
Thanks,
Quoted 5 lines
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 37 lines · On 4/9/26 21:46, Jaegeuk Kim via Linux-f2fs-devel wrote:
[Script]
dd if=/dev/zero of=/mnt/test/test bs=1M count=1024f2fs_iosetxattr user.fadvise 1/mnt/test/testchmod 0400/mnt/test/test
sync -f/mnt/test/test
echo 3 >/proc/sys/vm/drop_cachesf2fs_ioread 1 0 100000 mmap 0 1/mnt/test/testf2fs_ioget_fadvise/mnt/test/test[Output]
1024+0 records in
1024+0 records out
1073741824 bytes (1.1 GB, 1.0 GiB) copied, 0.520712 s, 2.1 GB/s
setxattr/mnt/test/testCREATE: name: user.fadvise, value: 1: ret=0
Read 409600000 bytestotal_time= 106757 us, BW = 4286 MB/s, IO time = 95577 us, mlock time = 11173 us, print 1 bytes:
00000000 : 00
fadvise=0x1,advise_type: largefolioSigned-off-by Jaegeuk Kim <[email protected]>--- tools/f2fs_io/f2fs_io.c | 32 ++++++++++++++++++++++++++++++++ tools/f2fs_io/f2fs_io.h | 6 ++++++ 2 files changed, 38 insertions(+)tools/f2fs_io/f2fs_io.c +1
-0@@ -2084,6 +2084,7 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd)int ret, len;char *value;unsigned char tmp; +unsigned int tmp_u;if (argc !=4 ) {fputs ("Excess arguments\n\n" , stderr);
tools/f2fs_io/f2fs_io.c static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd) · line 2099
Quoted 4 lines
tools/f2fs_io/f2fs_io.c +1
-0@@ -2095,6 +2096,10 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd) tmp =strtoul (argv[2 ],NULL ,0 ); value = (char *)&tmp; len =1 ; + }else if (!strcmp (argv[1 ],F2FS_USER_FADVISE_NAME )) {
Missed to add description in doc?
Quoted 40 lines
tools/f2fs_io/f2fs_io.c +29
-0+ tmp_u =strtoul (argv[2 ],NULL ,0 ); + value = (char *)&tmp_u; + len =sizeof (unsigned int ); }else { value = argv[2 ]; len =strlen (value);@@ -2217,6 +2222,32 @@ static void do_get_advise(int argc, char **argv, const struct cmd_desc *cmd)printf ("\n" ); } +#define get_fadvise_desc "get_fadvise" +#define get_fadvise_help "f2fs_io get_fadvise [file_path]\n\n" + +static void do_get_fadvise (int argc,char **argv,const struct cmd_desc *cmd) +{ +int ret; +unsigned int value; + +if (argc !=2 ) { +fputs ("Excess arguments\n\n" , stderr); +fputs (cmd->cmd_help, stderr); +exit (1 ); + } + + ret =getxattr (argv[1 ],F2FS_USER_FADVISE_NAME , &value,sizeof (value)); +if (ret !=sizeof (value)) { +perror ("getxattr" ); +exit (1 ); + } + +printf ("fadvise=0x%x, advise_type: " , value); +if (value & (1 <<F2FS_XATTR_FADV_LARGEFOLIO )) +printf ("largefolio" ); +printf ("\n" ); +} +#define ftruncate_desc "ftruncate a file"#define ftruncate_help \ "f2fs_io ftruncate [length] [file_path]\n\n" \
tools/f2fs_io/f2fs_io.c const struct cmd_desc cmd_list[] = { · line 2660
Quoted 4 lines
tools/f2fs_io/f2fs_io.c +1
-0@@ -2626,6 +2657,7 @@ const struct cmd_desc cmd_list[] = {CMD (removexattr),CMD (lseek),CMD (get_advise), + CMD(get_fadvise),
Ditto,
Thanks,
Quoted 17 lines
tools/f2fs_io/f2fs_io.c +0
-0CMD (ioprio),CMD (ftruncate), CMD(test_create_perf),tools/f2fs_io/f2fs_io.h +1
-0@@ -186,6 +186,7 @@ struct fsverity_enable_arg {#define F2FS_IOC_FSSETXATTR FS_IOC_FSSETXATTR#define F2FS_SYSTEM_ADVISE_NAME "system.advise" +#define F2FS_USER_FADVISE_NAME "user.fadvise"#define FADVISE_COLD_BIT 0x01#define FADVISE_LOST_PINO_BIT 0x02#define FADVISE_ENCRYPT_BIT 0x04@@ -195,6 +196,11 @@ struct fsverity_enable_arg {#define FADVISE_VERITY_BIT 0x40
tools/f2fs_io/f2fs_io.h struct fsverity_enable_arg { · line 206
Quoted 10 lines
tools/f2fs_io/f2fs_io.h +5
-0#define FADVISE_TRUNC_BIT 0x80 +/* used for F2FS_USER_FADVISE_NAME */ +enum { +F2FS_XATTR_FADV_LARGEFOLIO , +}; +/* used for F2FS_IOC_IO_PRIO */ enum {F2FS_IOPRIO_WRITE =1 ,/* high write priority */
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH 2/2] f2fs_io: user O_RDONLY for fadvise
In reply to Jaegeuk Kim via Linux-f2fs-develQuoted 1 line · On 4/9/26 21:46, Jaegeuk Kim via Linux-f2fs-devel wrote:
We don't need
O_RDONLYfor fadvise.
s/O_RDONLY/O_RDWR according to title & change?
Thanks,
Quoted 11 lines
Signed-off-by Jaegeuk Kim <[email protected]>--- tools/f2fs_io/f2fs_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/f2fs_io/f2fs_io.c +0
-0
tools/f2fs_io/f2fs_io.c static void do_fadvise(int argc, char **argv, const struct cmd_desc *cmd) · line 480
Quoted 8 lines
tools/f2fs_io/f2fs_io.c +1
-1@@ -474,7 +474,7 @@ static void do_fadvise(int argc, char **argv, const struct cmd_desc *cmd)exit (1 ); } - fd =xopen (argv[4 ],O_RDWR ,0 ); + fd =xopen (argv[4 ],O_RDONLY ,0 );if (!strcmp (argv[1 ],"willneed" )) { advice =POSIX_FADV_WILLNEED ;
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH 2/2 v2] f2fs_io: use O_RDONLY for fadvise
In reply to Jaegeuk Kim via Linux-f2fs-develWe don't need O_RDWR for fadvise.
--- tools/f2fs_io/f2fs_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/f2fs_io/f2fs_io.c +1 -1
@@ -474,7 +474,7 @@ static void do_fadvise(int argc, char **argv, const struct cmd_desc *cmd)exit (1 ); } - fd =xopen (argv[4 ],O_RDWR ,0 ); + fd =xopen (argv[4 ],O_RDONLY ,0 );if (!strcmp (argv[1 ],"willneed" )) { advice =POSIX_FADV_WILLNEED ;
Signature · 8 lines
2.54.0.563.g4f69b47b94-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
[Script]
dd if=/dev/zero of=/mnt/test/test bs=1M count=1024 f2fs_io setxattr user.fadvise 1 /mnt/test/test chmod 0400 /mnt/test/test
sync -f /mnt/test/test
echo 3 > /proc/sys/vm/drop_cachesf2fs_io read 1 0 100000 mmap 0 1 /mnt/test/test f2fs_io get_fadvise /mnt/test/test
[Output]
1024+0 records in
1024+0 records out
1073741824 bytes (1.1 GB, 1.0 GiB) copied, 0.520712 s, 2.1 GB/s
setxattr /mnt/test/test CREATE: name: user.fadvise, value: 1: ret=0
Read 409600000 bytes total_time = 106757 us, BW = 4286 MB/s, IO time = 95577 us, mlock time = 11173 us, print 1 bytes:
00000000 : 00
fadvise=0x1, advise_type: largefolio
--- man/f2fs_io.8 | 8 ++++++++ tools/f2fs_io/f2fs_io.c | 32 ++++++++++++++++++++++++++++++++ tools/f2fs_io/f2fs_io.h | 6 ++++++ 3 files changed, 46 insertions(+)
man/f2fs_io.8 +8 -0
@@ -53,10 +53,18 @@ going down with fsck mark \fBpinfile\fR \fI[get|set|unset] [file]\fR Get or set the pinning status on a file. .TP +\fBsetxattr\fR \fI[name] [value] [file]\fR +Call setxattr to the file. The supported +.I name +are system.advise and user.fadvise. +.TP \fBfadvise\fR \fI[advice] [offset] [length] [file]\fR Pass an advice to the specified file. The advice can be willneed, dontneed, noreuse, sequential, random. .TP +\fBget_fadvise\fR \fI[file]\fR +Show the activated fadvise flags. +.TP \fBfallocate\fR \fI[-c] [-i] [-p] [-z] [keep_size] [offset] [length] [file]\fR Request that space be allocated on a file. The .I keep_size
tools/f2fs_io/f2fs_io.c +32 -0
@@ -2084,6 +2084,7 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd)int ret, len;char *value;unsigned char tmp; +unsigned int tmp_u;if (argc !=4 ) {fputs ("Excess arguments\n\n" , stderr);
@@ -2095,6 +2096,10 @@ static void do_setxattr(int argc, char **argv, const struct cmd_desc *cmd) tmp =strtoul (argv[2 ],NULL ,0 ); value = (char *)&tmp; len =1 ; + }else if (!strcmp (argv[1 ],F2FS_USER_FADVISE_NAME )) { + tmp_u =strtoul (argv[2 ],NULL ,0 ); + value = (char *)&tmp_u; + len =sizeof (unsigned int ); }else { value = argv[2 ]; len =strlen (value);
@@ -2217,6 +2222,32 @@ static void do_get_advise(int argc, char **argv, const struct cmd_desc *cmd)printf ("\n" ); } +#define get_fadvise_desc "get_fadvise" +#define get_fadvise_help "f2fs_io get_fadvise [file_path]\n\n" + +static void do_get_fadvise (int argc,char **argv,const struct cmd_desc *cmd) +{ +int ret; +unsigned int value; + +if (argc !=2 ) { +fputs ("Excess arguments\n\n" , stderr); +fputs (cmd->cmd_help, stderr); +exit (1 ); + } + + ret =getxattr (argv[1 ],F2FS_USER_FADVISE_NAME , &value,sizeof (value)); +if (ret !=sizeof (value)) { +perror ("getxattr" ); +exit (1 ); + } + +printf ("fadvise=0x%x, advise_type: " , value); +if (value & (1 <<F2FS_XATTR_FADV_LARGEFOLIO )) +printf ("largefolio" ); +printf ("\n" ); +} +#define ftruncate_desc "ftruncate a file"#define ftruncate_help \ "f2fs_io ftruncate [length] [file_path]\n\n" \
@@ -2626,6 +2657,7 @@ const struct cmd_desc cmd_list[] = {CMD (removexattr),CMD (lseek),CMD (get_advise), +CMD (get_fadvise),CMD (ioprio),CMD (ftruncate), CMD(test_create_perf),
tools/f2fs_io/f2fs_io.h +6 -0
@@ -186,6 +186,7 @@ struct fsverity_enable_arg {#define F2FS_IOC_FSSETXATTR FS_IOC_FSSETXATTR#define F2FS_SYSTEM_ADVISE_NAME "system.advise" +#define F2FS_USER_FADVISE_NAME "user.fadvise"#define FADVISE_COLD_BIT 0x01#define FADVISE_LOST_PINO_BIT 0x02#define FADVISE_ENCRYPT_BIT 0x04
@@ -195,6 +196,11 @@ struct fsverity_enable_arg {#define FADVISE_VERITY_BIT 0x40#define FADVISE_TRUNC_BIT 0x80 +/* used for F2FS_USER_FADVISE_NAME */ +enum { +F2FS_XATTR_FADV_LARGEFOLIO , +}; +/* used for F2FS_IOC_IO_PRIO */ enum {F2FS_IOPRIO_WRITE =1 ,/* high write priority */
Signature · 8 lines
2.54.0.563.g4f69b47b94-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Chao Yu via Linux-f2fs-devel
Reviewed-by Chao YuRe: [f2fs-dev] [PATCH 2/2 v2] f2fs_io: use O_RDONLY for fadvise
In reply to Jaegeuk Kim via Linux-f2fs-develQuoted 3 lines · On 5/9/26 03:12, Jaegeuk Kim via Linux-f2fs-devel wrote:
We don't need
O_RDWRfor fadvise.Signed-off-by Jaegeuk Kim <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Chao Yu via Linux-f2fs-devel
Reviewed-by Chao YuQuoted 18 lines · On 5/9/26 03:23, Jaegeuk Kim via Linux-f2fs-devel wrote:
[Script]
dd if=/dev/zero of=/mnt/test/test bs=1M count=1024f2fs_iosetxattr user.fadvise 1/mnt/test/testchmod 0400/mnt/test/test
sync -f/mnt/test/test
echo 3 >/proc/sys/vm/drop_cachesf2fs_ioread 1 0 100000 mmap 0 1/mnt/test/testf2fs_ioget_fadvise/mnt/test/test[Output]
1024+0 records in
1024+0 records out
1073741824 bytes (1.1 GB, 1.0 GiB) copied, 0.520712 s, 2.1 GB/s
setxattr/mnt/test/testCREATE: name: user.fadvise, value: 1: ret=0
Read 409600000 bytestotal_time= 106757 us, BW = 4286 MB/s, IO time = 95577 us, mlock time = 11173 us, print 1 bytes:
00000000 : 00
fadvise=0x1,advise_type: largefolio
Quoted 2 lines
Reviewed-by Daeho Jeong <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel