staging: rtl8723bs: fix comparison to false
PATCH v2 1/1 staging: rtl8723bs: fix comparison to false
Replace '== false' with '!' operator for boolean test to adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Using comparison to false is error prone
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -2
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)rtw_ht_use_default_setting (padapter); -if (pmlmepriv->htpriv.sgi_20m == false) +if (!pmlmepriv->htpriv.sgi_20m) pht_cap->cap_info &=cpu_to_le16 (~(IEEE80211_HT_CAP_SGI_20 )); -if (pmlmepriv->htpriv.sgi_40m == false) +if (!pmlmepriv->htpriv.sgi_40m) pht_cap->cap_info &=cpu_to_le16 (~(IEEE80211_HT_CAP_SGI_40 ));if (!TEST_FLAG (pmlmepriv->htpriv.ldpc_cap,LDPC_HT_ENABLE_RX ))
Signature · 1 line
2.53.0
Hi Akhil,
I am sorry to inform you, but upon checking, I have discovered that your change was introduced in one patch in the past. You have probably been working on master branch(one from Linus) and not staging-next. Therefore, since patch wasn't merged to mainline yet, you didn't see that your change is already present.
Best regards,
Luka Gejak
Quoted 8 lines · Luka Gejak
Hi Akhil,
I am sorry to inform you, but upon checking, I have discovered that your change was introduced in one patch in the past. You have probably been working on master branch(one from Linus) and not staging-next. Therefore, since patch wasn't merged to mainline yet, you didn't see that your change is already present.
Best regards,
Luka Gejak
Hello Luka,
Thanks for letting me know, I really appreciate it. I just switched to the staging-next branch.
Best Regards,
Akhil
Quoted 9 lines · Akhil
Quoted 8 lines · Luka Gejak
Hi Akhil,
I am sorry to inform you, but upon checking, I have discovered that your change was introduced in one patch in the past. You have probably been working on master branch(one from Linus) and not staging-next. Therefore, since patch wasn't merged to mainline yet, you didn't see that your change is already present.
Best regards,
Luka Gejak
Quoted 5 lines
Hello Luka,
Thanks for letting me know, I really appreciate it. I just switched to the staging-next branch.
Best Regards,
Akhil
No problem, if you need anything else let me know and feel free to cc me for any further patches.
Best regards,
Luka Gejak