Skip to contentSkip to conversation

RDMA/addr: change addr_wq back to unordered workqueue

PATCH Applied Surabhi Gogte 2 participants 2 messages Apr 10 – May 10 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/addr: change addr_wq back to unordered workqueue

Commit 5fff41e1f89d ("IB/core: Fix race condition in resolving IP to MAC") changed the workqueue "addr_wq" to a single-threaded wq. Commit e19c0d237873 ("RDMA/rdma_cm: Remove process_req and timer sorting") eliminated global work and started using per-req work.
Now we no longer have the race, change "addr_wq" back to multi-threaded workqueue to speed up multiple addr resolutions.

Fixes e19c0d237873 ("RDMA/rdma_cm: Remove process_req and timer sorting")
---
 drivers/infiniband/core/addr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/core/addr.c +1 -1
index 866746695712..7ce012f389bd 100644
@@ -848,7 +848,7 @@ static struct notifier_block nb = {
 
 int addr_init(void)
 {
-	addr_wq = alloc_ordered_workqueue("ib_addr", 0);
+	addr_wq = alloc_workqueue("ib_addr", WQ_UNBOUND, 0);
 	if (!addr_wq)
 		return -ENOMEM;
 
Signature · 1 line
2.53.0
#1 lore raw
Quoted 8 lines · Surabhi Gogte

Commit 5fff41e1f89d ("IB/core: Fix race condition in resolving IP to MAC") changed the workqueue "addr_wq" to a single-threaded wq. Commit e19c0d237873 ("RDMA/rdma_cm: Remove process_req and timer sorting") eliminated global work and started using per-req work.
Now we no longer have the race, change "addr_wq" back to multi-threaded workqueue to speed up multiple addr resolutions.

[...]

Applied, thanks!

[1/1] RDMA/addr: change addr_wq back to unordered workqueue

      https://git.kernel.org/rdma/rdma/c/dd2403fe1499bd

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>