include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse) == 512"
kernel test robot
build bottree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9a9c8ce300cd3859cc87b408ef552cd697cc2ab7 commit: deb3ddeb18652118956fb581a39ac299e1ee5623 wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers date: 1 year, 1 month ago config: arm-randconfig-001-20260410 (https://download.01.org/0day-ci/archive/20260410/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260410/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Fixes: deb3ddeb1865 ("wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers")
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
In file included from include/linux/bitfield.h:10,
from include/linux/fortify-string.h:5,
from include/linux/string.h:389,
from include/linux/uuid.h:11,
from include/linux/mod_devicetable.h:14,
from include/linux/usb.h:5,
from drivers/net/wireless/realtek/rtw88/rtw8814a.c:5:
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse) == 512"
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
^~~~~~~~~~~~~~
include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
#define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
^~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/rtw8814a.h:58:1: note: in expansion of macro 'static_assert'
static_assert(sizeof(struct rtw8814a_efuse) == 512);
^~~~~~~~~~~~~
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw88xxa_efuse) == 512"
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
^~~~~~~~~~~~~~
include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
#define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
^~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/rtw88xxa.h:64:1: note: in expansion of macro 'static_assert'
static_assert(sizeof(struct rtw88xxa_efuse) == 512);
^~~~~~~~~~~~~
--
In file included from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/module.h:12,
from drivers/net/wireless/realtek/rtw88/rtw8814ae.c:5:
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse) == 512"
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
^~~~~~~~~~~~~~
include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
#define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
^~~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/rtw8814a.h:58:1: note: in expansion of macro 'static_assert'
static_assert(sizeof(struct rtw8814a_efuse) == 512);
^~~~~~~~~~~~~
--
In file included from include/linux/bitfield.h:10,
from include/linux/fortify-string.h:5,
from include/linux/string.h:389,
from include/linux/uuid.h:11,
from include/linux/mod_devicetable.h:14,
from include/linux/usb.h:5,
from rtw8814a.c:5:
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse) == 512"
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
^~~~~~~~~~~~~~
include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
#define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
^~~~~~~~~~~~~~~
rtw8814a.h:58:1: note: in expansion of macro 'static_assert'
static_assert(sizeof(struct rtw8814a_efuse) == 512);
^~~~~~~~~~~~~
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw88xxa_efuse) == 512"
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
^~~~~~~~~~~~~~
include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
#define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
^~~~~~~~~~~~~~~
rtw88xxa.h:64:1: note: in expansion of macro 'static_assert'
static_assert(sizeof(struct rtw88xxa_efuse) == 512);
^~~~~~~~~~~~~
--
In file included from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/module.h:12,
from rtw8814ae.c:5:
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse) == 512"
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
^~~~~~~~~~~~~~
include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
#define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
^~~~~~~~~~~~~~~
rtw8814a.h:58:1: note: in expansion of macro 'static_assert'
static_assert(sizeof(struct rtw8814a_efuse) == 512);
^~~~~~~~~~~~~vim +78 include/linux/build_bug.h
bc6245e5efd70c Ian Abbott 2017-07-10 60 6bab69c65013be Rasmus Villemoes 2019-03-07 61 /** 6bab69c65013be Rasmus Villemoes 2019-03-07 62 * static_assert - check integer constant expression at build time 6bab69c65013be Rasmus Villemoes 2019-03-07 63 * 6bab69c65013be Rasmus Villemoes 2019-03-07 64 * static_assert() is a wrapper for the C11 _Static_assert, with a 6bab69c65013be Rasmus Villemoes 2019-03-07 65 * little macro magic to make the message optional (defaulting to the 6bab69c65013be Rasmus Villemoes 2019-03-07 66 * stringification of the tested expression). 6bab69c65013be Rasmus Villemoes 2019-03-07 67 * 6bab69c65013be Rasmus Villemoes 2019-03-07 68 * Contrary to BUILD_BUG_ON(), static_assert() can be used at global 6bab69c65013be Rasmus Villemoes 2019-03-07 69 * scope, but requires the expression to be an integer constant 6bab69c65013be Rasmus Villemoes 2019-03-07 70 * expression (i.e., it is not enough that __builtin_constant_p() is 6bab69c65013be Rasmus Villemoes 2019-03-07 71 * true for expr). 6bab69c65013be Rasmus Villemoes 2019-03-07 72 * 6bab69c65013be Rasmus Villemoes 2019-03-07 73 * Also note that BUILD_BUG_ON() fails the build if the condition is 6bab69c65013be Rasmus Villemoes 2019-03-07 74 * true, while static_assert() fails the build if the expression is 6bab69c65013be Rasmus Villemoes 2019-03-07 75 * false. 6bab69c65013be Rasmus Villemoes 2019-03-07 76 */ 6bab69c65013be Rasmus Villemoes 2019-03-07 77 #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
6bab69c65013be Rasmus Villemoes 2019-03-07 @78 #define __static_assert(expr, msg, ...) _Static_assert(expr, msg) 6bab69c65013be Rasmus Villemoes 2019-03-07 7907a368b3f55a79 Maxim Levitsky 2022-10-25 80
:::::: The code at line 78 was first introduced by commit
:::::: 6bab69c65013bed5fce9f101a64a84d0385b3946 build_bug.h: add wrapper for _Static_assert
:::::: TO: Rasmus Villemoes <[email protected]> :::::: CC: Linus Torvalds <[email protected]>
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Quoted 16 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9a9c8ce300cd3859cc87b408ef552cd697cc2ab7 commit: deb3ddeb18652118956fb581a39ac299e1ee5623 wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers date: 1 year, 1 month ago config: arm-randconfig-001-20260410 (https://download.01.org/0day-ci/archive/20260410/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260410/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Fixes: deb3ddeb1865 ("wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers") | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
Quoted 8 lines
In file included from
include/linux/bitfield.h:10,from include/linux/fortify-string.h:5, from include/linux/string.h:389, from include/linux/uuid.h:11, from include/linux/mod_devicetable.h:14, from include/linux/usb.h:5, from drivers/net/wireless/realtek/rtw88/rtw8814a.c:5:Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"
struct rtw_2g_txpwr_idx is missing __packed. Could that be the reason for the error? I don't see what else could be causing it.
Quoted 103 lines
#define __static_assert(expr, msg, ...) _Static_assert(expr, msg) ^~~~~~~~~~~~~~ include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert' #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr) ^~~~~~~~~~~~~~~ drivers/net/wireless/realtek/rtw88/rtw8814a.h:58:1: note: in expansion of macro 'static_assert' static_assert(sizeof(struct rtw8814a_efuse) == 512); ^~~~~~~~~~~~~Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw88xxa_efuse)== 512"#define __static_assert(expr, msg, ...) _Static_assert(expr, msg) ^~~~~~~~~~~~~~ include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert' #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr) ^~~~~~~~~~~~~~~ drivers/net/wireless/realtek/rtw88/rtw88xxa.h:64:1: note: in expansion of macro 'static_assert' static_assert(sizeof(struct rtw88xxa_efuse) == 512); ^~~~~~~~~~~~~ -- In file included from include/linux/container_of.h:5, from include/linux/list.h:5, from include/linux/module.h:12, from drivers/net/wireless/realtek/rtw88/rtw8814ae.c:5:Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"#define __static_assert(expr, msg, ...) _Static_assert(expr, msg) ^~~~~~~~~~~~~~ include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert' #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr) ^~~~~~~~~~~~~~~ drivers/net/wireless/realtek/rtw88/rtw8814a.h:58:1: note: in expansion of macro 'static_assert' static_assert(sizeof(struct rtw8814a_efuse) == 512); ^~~~~~~~~~~~~ -- In file included from include/linux/bitfield.h:10, from include/linux/fortify-string.h:5, from include/linux/string.h:389, from include/linux/uuid.h:11, from include/linux/mod_devicetable.h:14, from include/linux/usb.h:5, from rtw8814a.c:5:Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"#define __static_assert(expr, msg, ...) _Static_assert(expr, msg) ^~~~~~~~~~~~~~ include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert' #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr) ^~~~~~~~~~~~~~~ rtw8814a.h:58:1: note: in expansion of macro 'static_assert' static_assert(sizeof(struct rtw8814a_efuse) == 512); ^~~~~~~~~~~~~Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw88xxa_efuse)== 512"#define __static_assert(expr, msg, ...) _Static_assert(expr, msg) ^~~~~~~~~~~~~~ include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert' #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr) ^~~~~~~~~~~~~~~ rtw88xxa.h:64:1: note: in expansion of macro 'static_assert' static_assert(sizeof(struct rtw88xxa_efuse) == 512); ^~~~~~~~~~~~~ -- In file included from include/linux/container_of.h:5, from include/linux/list.h:5, from include/linux/module.h:12, from rtw8814ae.c:5:Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"#define __static_assert(expr, msg, ...) _Static_assert(expr, msg) ^~~~~~~~~~~~~~ include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert' #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr) ^~~~~~~~~~~~~~~ rtw8814a.h:58:1: note: in expansion of macro 'static_assert' static_assert(sizeof(struct rtw8814a_efuse) == 512); ^~~~~~~~~~~~~vim +78
include/linux/build_bug.hbc6245e5efd70c Ian Abbott 2017-07-10 60 6bab69c65013be Rasmus Villemoes 2019-03-07 61 /** 6bab69c65013be Rasmus Villemoes 2019-03-07 62 * static_assert - check integer constant expression at build time 6bab69c65013be Rasmus Villemoes 2019-03-07 63 * 6bab69c65013be Rasmus Villemoes 2019-03-07 64 * static_assert() is a wrapper for the C11 _Static_assert, with a 6bab69c65013be Rasmus Villemoes 2019-03-07 65 * little macro magic to make the message optional (defaulting to the 6bab69c65013be Rasmus Villemoes 2019-03-07 66 * stringification of the tested expression). 6bab69c65013be Rasmus Villemoes 2019-03-07 67 * 6bab69c65013be Rasmus Villemoes 2019-03-07 68 * Contrary to BUILD_BUG_ON(), static_assert() can be used at global 6bab69c65013be Rasmus Villemoes 2019-03-07 69 * scope, but requires the expression to be an integer constant 6bab69c65013be Rasmus Villemoes 2019-03-07 70 * expression (i.e., it is not enough that __builtin_constant_p() is 6bab69c65013be Rasmus Villemoes 2019-03-07 71 * true for expr). 6bab69c65013be Rasmus Villemoes 2019-03-07 72 * 6bab69c65013be Rasmus Villemoes 2019-03-07 73 * Also note that BUILD_BUG_ON() fails the build if the condition is 6bab69c65013be Rasmus Villemoes 2019-03-07 74 * true, while static_assert() fails the build if the expression is 6bab69c65013be Rasmus Villemoes 2019-03-07 75 * false. 6bab69c65013be Rasmus Villemoes 2019-03-07 76 */ 6bab69c65013be Rasmus Villemoes 2019-03-07 77 #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
6bab69c65013beRasmus Villemoes 2019-03-07 @78 #define__static_assert(expr, msg, ...)_Static_assert(expr, msg)6bab69c65013beRasmus Villemoes 2019-03-07 7907a368b3f55a79Maxim Levitsky 2022-10-25 80:::::: The code at line 78 was first introduced by commit
::::::6bab69c65013bed5fce9f101a64a84d0385b3946build_bug.h: add wrapper for_Static_assert:::::: TO: Rasmus Villemoes <[email protected]> :::::: CC: Linus Torvalds <[email protected]>
Ping-Ke Shih
maintainerQuoted 24 lines · Bitterblue Smith
Quoted 23 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:9a9c8ce300cd3859cc87b408ef552cd697cc2ab7
commit:deb3ddeb18652118956fb581a39ac299e1ee5623wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers date: 1 year, 1 month ago
config: arm-randconfig-001-20260410 (https://download.01.org/0day-ci/archive/20260410/[email protected]/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260410/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Fixes: deb3ddeb1865 ("wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers") | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
In file included from
include/linux/bitfield.h:10,
frominclude/linux/fortify-string.h:5, frominclude/linux/string.h:389,
frominclude/linux/uuid.h:11,
frominclude/linux/mod_devicetable.h:14, frominclude/linux/usb.h:5,
fromdrivers/net/wireless/realtek/rtw88/rtw8814a.c:5:
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"struct
rtw_2g_txpwr_idxis missing__packed. Could that be the reason for the error? I don't see what else could be causing it.
I also found that flaw, but it isn't cause. I download cross compiler to build arm on my x86, and address the cause is:
drivers/net/wireless/realtek/rtw88/rtw8814a.h +1 -1
@@ -51,10 +51,15 @@ struct rtw8814a_efuse {union {struct rtw8814au_efuse u;struct rtw8814ae_efuse e; - }; + } __packed;u8 res5[0x122 ];/* 0xde */ } __packed;
I will send a patch soon.
Ping-Ke
Hi Ping-Ke,
Quoted 39 lines · Ping-Ke Shih
Quoted 24 lines · Bitterblue Smith
Quoted 23 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9a9c8ce300cd3859cc87b408ef552cd697cc2ab7 commit: deb3ddeb18652118956fb581a39ac299e1ee5623 wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers date: 1 year, 1 month ago config: arm-randconfig-001-20260410 (https://download.01.org/0day-ci/archive/20260410/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260410/[email protected]/reproduce)If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Fixes: deb3ddeb1865 ("wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers") | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
In file included from
include/linux/bitfield.h:10,from include/linux/fortify-string.h:5, from include/linux/string.h:389, from include/linux/uuid.h:11, from include/linux/mod_devicetable.h:14, from include/linux/usb.h:5, from drivers/net/wireless/realtek/rtw88/rtw8814a.c:5:Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"struct
rtw_2g_txpwr_idxis missing__packed. Could that be the reason for the error? I don't see what else could be causing it.I also found that flaw, but it isn't cause. I download cross compiler to build arm on my x86, and address the cause is:
drivers/net/wireless/realtek/rtw88/rtw8814a.h +0
-0
drivers/net/wireless/realtek/rtw88/rtw8814a.h struct rtw8814a_efuse { · line 54
Quoted 5 lines
drivers/net/wireless/realtek/rtw88/rtw8814a.h +1
-1@@ -51,10 +51,15 @@ struct rtw8814a_efuse {union {struct rtw8814au_efuse u;struct rtw8814ae_efuse e; - }; + } __packed;
How can that make a difference?
Both rtw8814au_efuse and rtw8814ae_efuse contain just (the same number of) bytes, so __packed on the union should not make any difference? Moreover, rtw8814au_efuse and rtw8814ae_efuse are already tagged with __packed, which should also not make any difference. Someone's been sprinkling too many __packed all over the place?
Quoted 6 lines
drivers/net/wireless/realtek/rtw88/rtw8814a.h +0
-0u8 res5[0x122 ];/* 0xde */ } __packed;I will send a patch soon.
Ping-Ke
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Ping-Ke Shih
maintainerHi Geert,
Quoted 43 lines
Hi Ping-Ke,
Quoted 5 lines · Ping-Ke Shih
Quoted 4 lines · Bitterblue Smith
Quoted 3 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9a9c8ce300cd3859cc87b408ef552cd697cc2ab7 commit: deb3ddeb18652118956fb581a39ac299e1ee5623 wifi: rtw88: Enable the new RTL8814AE/RTL8814AUdrivers
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
date: 1 year, 1 month ago config: arm-randconfig-001-20260410(https://download.01.org/0day-ci/archive/20260410/[email protected]/config)
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build):(https://download.01.org/0day-ci/archive/20260410/[email protected]/reproduce)
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Fixes: deb3ddeb1865 ("wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers") | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
In file included from
include/linux/bitfield.h:10,from include/linux/fortify-string.h:5, from include/linux/string.h:389, from include/linux/uuid.h:11, from include/linux/mod_devicetable.h:14, from include/linux/usb.h:5, from drivers/net/wireless/realtek/rtw88/rtw8814a.c:5:Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"
Review
Quoted 9 lines
Quoted 4 lines
struct
rtw_2g_txpwr_idxis missing__packed. Could that be the reason for the error? I don't see what else could be causing it.I also found that flaw, but it isn't cause. I download cross compiler to build arm on my x86, and address the cause is:
(quoted diff) +0
-0
b/drivers/net/wireless/realtek/rtw88/rtw8814a.h
Quoted 16 lines
drivers/net/wireless/realtek/rtw88/rtw8814a.h struct rtw8814a_efuse { · line 54
Quoted 9 lines
index
c57c7c8f915e..7f2260117487100644drivers/net/wireless/realtek/rtw88/rtw8814a.h +1
-1@@ -51,10 +51,15 @@ struct rtw8814a_efuse {union {struct rtw8814au_efuse u;struct rtw8814ae_efuse e; - }; + } __packed;How can that make a difference?
Bothrtw8814au_efuseandrtw8814ae_efusecontain just (the same number of) bytes, so__packedon the union should not make any difference? Moreover,rtw8814au_efuseandrtw8814ae_efuseare already tagged with__packed, which should also not make any difference. Someone's been sprinkling too many__packedall over the place?
I have similar thought as yours, but arm-linux-gnueabi-gcc compiler seems have special treatment with union. For this case, without __packed the offset of followed field res5 will become 0xe0.
When investing this error, I also found another waning [1].
I don't know why the compiler treats the union so special, and I fix them by experimental results.
[1] https://lore.kernel.org/linux-wireless/[email protected]/T/#u
Quoted 11 lines
Quoted 7 lines
drivers/net/wireless/realtek/rtw88/rtw8814a.h +0
-0u8 res5[0x122 ];/* 0xde */ } __packed;I will send a patch soon.
Ping-Ke
Gr{oetje,eeting}s,
Geert
Ping-Ke
Hi Ping-Ke,
CC Arnd
Quoted 58 lines · Ping-Ke Shih
Quoted 41 lines · Ping-Ke Shih
Quoted 5 lines
Quoted 4 lines · Bitterblue Smith
Quoted 3 lines · kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9a9c8ce300cd3859cc87b408ef552cd697cc2ab7 commit: deb3ddeb18652118956fb581a39ac299e1ee5623 wifi: rtw88: Enable the new RTL8814AE/RTL8814AUdrivers
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
date: 1 year, 1 month ago config: arm-randconfig-001-20260410(https://download.01.org/0day-ci/archive/20260410/[email protected]/config)
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build):(https://download.01.org/0day-ci/archive/20260410/[email protected]/reproduce)
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Fixes: deb3ddeb1865 ("wifi: rtw88: Enable the new RTL8814AE/RTL8814AU drivers") | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/All errors (new ones prefixed by >>):
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
In file included from
include/linux/bitfield.h:10,from include/linux/fortify-string.h:5, from include/linux/string.h:389, from include/linux/uuid.h:11, from include/linux/mod_devicetable.h:14, from include/linux/usb.h:5, from drivers/net/wireless/realtek/rtw88/rtw8814a.c:5:Quoted 1 line
Quoted 1 line
include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct rtw8814a_efuse)== 512"
Review
Quoted 9 lines
Quoted 4 lines
struct
rtw_2g_txpwr_idxis missing__packed. Could that be the reason for the error? I don't see what else could be causing it.I also found that flaw, but it isn't cause. I download cross compiler to build arm on my x86, and address the cause is:
(quoted diff) +0
-0
b/drivers/net/wireless/realtek/rtw88/rtw8814a.hQuoted 16 lines
drivers/net/wireless/realtek/rtw88/rtw8814a.h struct rtw8814a_efuse { · line 54
Quoted 9 lines
index
c57c7c8f915e..7f2260117487100644drivers/net/wireless/realtek/rtw88/rtw8814a.h +1
-1@@ -51,10 +51,15 @@ struct rtw8814a_efuse {union {struct rtw8814au_efuse u;struct rtw8814ae_efuse e; - }; + } __packed;How can that make a difference?
Bothrtw8814au_efuseandrtw8814ae_efusecontain just (the same number of) bytes, so__packedon the union should not make any difference? Moreover,rtw8814au_efuseandrtw8814ae_efuseare already tagged with__packed, which should also not make any difference. Someone's been sprinkling too many__packedall over the place?
Quoted 3 lines
I have similar thought as yours, but arm-linux-gnueabi-gcc compiler seems have special treatment with union. For this case, without
__packedthe offset of followed field res5 will become0xe0.
Hmm, I can confirm the original issue, and that adding __packed does have an impact (it reduces the size of rtw8814a_efuse from 522 to 520), but the actual size is still wrong (should be 512).
drivers/net/wireless/realtek/rtw88/rtw88xxa.h has a similar issue, but adding __packed does not make a difference there.
Removing the __packed from struct rtw8814au_efuse increases its size from 14 to 16 bytes. Looks like that ABI pads every structure to a multiple of 4 bytes?
Quoted 13 lines
When investing this error, I also found another waning [1].
I don't know why the compiler treats the union so special, and I fix them by experimental results.
[1] https://lore.kernel.org/linux-wireless/[email protected]/T/#u
Quoted 5 lines
Quoted 5 lines
drivers/net/wireless/realtek/rtw88/rtw8814a.h +0
-0u8 res5[0x122 ];/* 0xde */ } __packed;I will send a patch soon.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 17 lines · Geert Uytterhoeven
Quoted 11 lines · Ping-Ke Shih
Quoted 7 lines · Ping-Ke Shih
How can that make a difference?
Bothrtw8814au_efuseandrtw8814ae_efusecontain just (the same number of) bytes, so__packedon the union should not make any difference? Moreover,rtw8814au_efuseandrtw8814ae_efuseare already tagged with__packed, which should also not make any difference. Someone's been sprinkling too many__packedall over the place?I have similar thought as yours, but arm-linux-gnueabi-gcc compiler seems have special treatment with union. For this case, without
__packedthe offset of followed field res5 will become0xe0.Hmm, I can confirm the original issue, and that adding
__packeddoes have an impact (it reduces the size ofrtw8814a_efusefrom 522 to 520), but the actual size is still wrong (should be 512).
Quoted 6 lines
drivers/net/wireless/realtek/rtw88/rtw88xxa.hhas a similar issue, but adding__packeddoes not make a difference there.Removing the
__packedfrom structrtw8814au_efuseincreases its size from 14 to 16 bytes. Looks like that ABI pads every structure to a multiple of 4 bytes?
Correct, that is a unique property of the ARM "OABI" legacy ABI, triggered by this defconfig line:
# CONFIG_AEABI is not set
Nobody should be using ARM OABI any more, and I think we should remove it from the kernel once support for the StrongARM CPU gets removed (I have patches for that), as those CPUs were the last ones that regularly used OABI.
Annotating the union as '__packed' is the correct fix for the theoretical users of OABI, and does nothing on other supported targets in Linux.
Arnd
Hi Arnd,
Quoted 10 lines · Arnd Bergmann
Quoted 9 lines · Geert Uytterhoeven
Quoted 8 lines · Ping-Ke Shih
Quoted 7 lines · Ping-Ke Shih
How can that make a difference?
Bothrtw8814au_efuseandrtw8814ae_efusecontain just (the same number of) bytes, so__packedon the union should not make any difference? Moreover,rtw8814au_efuseandrtw8814ae_efuseare already tagged with__packed, which should also not make any difference. Someone's been sprinkling too many__packedall over the place?
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
I have similar thought as yours, but arm-linux-gnueabi-gcc compiler seems have special treatment with union. For this case, without
__packedthe offset of followed field res5 will become0xe0.Hmm, I can confirm the original issue, and that adding
__packeddoes have an impact (it reduces the size ofrtw8814a_efusefrom 522 to 520), but the actual size is still wrong (should be 512).
Aha, rtw_2g_txpwr_idx also needs __packed.
Quoted 13 lines
Quoted 7 lines
drivers/net/wireless/realtek/rtw88/rtw88xxa.hhas a similar issue, but adding__packeddoes not make a difference there.Removing the
__packedfrom structrtw8814au_efuseincreases its size from 14 to 16 bytes. Looks like that ABI pads every structure to a multiple of 4 bytes?Correct, that is a unique property of the ARM "OABI" legacy ABI, triggered by this defconfig line:
#
CONFIG_AEABIis not set
Quoted 8 lines
Nobody should be using ARM OABI any more, and I think we should remove it from the kernel once support for the StrongARM CPU gets removed (I have patches for that), as those CPUs were the last ones that regularly used OABI.
Annotating the union as '
__packed' is the correct fix for the theoretical users of OABI, and does nothing on other supported targets in Linux.
OK, thanks!
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 28 lines · On Mon, 13 Apr 2026 11:30:25 +0200 "Arnd Bergmann" <[email protected]> wrote:
Quoted 17 lines · Geert Uytterhoeven
Quoted 11 lines · Ping-Ke Shih
Quoted 7 lines · Ping-Ke Shih
How can that make a difference?
Bothrtw8814au_efuseandrtw8814ae_efusecontain just (the same number of) bytes, so__packedon the union should not make any difference? Moreover,rtw8814au_efuseandrtw8814ae_efuseare already tagged with__packed, which should also not make any difference. Someone's been sprinkling too many__packedall over the place?I have similar thought as yours, but arm-linux-gnueabi-gcc compiler seems have special treatment with union. For this case, without
__packedthe offset of followed field res5 will become0xe0.Hmm, I can confirm the original issue, and that adding
__packeddoes have an impact (it reduces the size ofrtw8814a_efusefrom 522 to 520), but the actual size is still wrong (should be 512).Quoted 6 lines
drivers/net/wireless/realtek/rtw88/rtw88xxa.hhas a similar issue, but adding__packeddoes not make a difference there.Removing the
__packedfrom structrtw8814au_efuseincreases its size from 14 to 16 bytes. Looks like that ABI pads every structure to a multiple of 4 bytes?Correct, that is a unique property of the ARM "OABI" legacy ABI, triggered by this defconfig line:
Quoted 6 lines
#
CONFIG_AEABIis not setNobody should be using ARM OABI any more, and I think we should remove it from the kernel once support for the StrongARM CPU gets removed (I have patches for that), as those CPUs were the last ones that regularly used OABI.
That would definitely save all the annoyance of the otherwise pointless __packed.
(I've seen it crop up before, but wasn't sure which architecture it was.) Doesn't OABI also have 32bit bool?
Quoted 3 lines
Annotating the union as '
__packed' is the correct fix for the theoretical users of OABI, and does nothing on other supported targets in Linux.
The other option is to ensure the specific drivers aren't ever compiled for !CONFIG_AEABI.
Then it'll all get tidied up when you remove it.
I read that the patches to remove 486 support have been merged. I'm sure it would have made sense to drop everything before P-Pro so that cmov can be used.
David
Quoted 3 lines
Arnd
Quoted 10 lines · David Laight
Quoted 5 lines · On Mon, 13 Apr 2026 11:30:25 +0200 "Arnd Bergmann" <[email protected]> wrote:
On Mon, Apr 13, 2026, at 11:15, Geert Uytterhoeven wrote:
Annotating the union as '
__packed' is the correct fix for the theoretical users of OABI, and does nothing on other supported targets in Linux.The other option is to ensure the specific drivers aren't ever compiled for !CONFIG_AEABI.
Then it'll all get tidied up when you remove it.
That sounds like even more work, for my own testing I have just stopped building OABI configuration altogether, though I'm still testing ARMv4 kernels.
Quoted 3 lines
I read that the patches to remove 486 support have been merged. I'm sure it would have made sense to drop everything before P-Pro so that cmov can be used.
That is an entirely unrelated discussion of course. I don't think there is any need to discontinue support for 586-class processors (Pentium, Pentium MMX, MediaGX/GeodeGX1, AMD K6, Vortex86/DX/MX, Via C3) any earlier than the rest of the x86-32 kernel support: There is no practical difference other than compiler flags, and the Vortex86MX+ is still in production (originally released in 2010 with a projected 10 year support life). This is very different from earlier 486-class CPUs that lack CMPXCHG8B and TSC.
Arnd
Quoted 8 lines · On Mon, 13 Apr 2026 15:46:50 +0200 "Arnd Bergmann" <[email protected]> wrote:
Quoted 7 lines · David Laight
Quoted 5 lines · On Mon, 13 Apr 2026 11:30:25 +0200 "Arnd Bergmann" <[email protected]> wrote:
On Mon, Apr 13, 2026, at 11:15, Geert Uytterhoeven wrote:
Annotating the union as '
__packed' is the correct fix for the theoretical users of OABI, and does nothing on other supported targets in Linux.
Quoted 7 lines
Quoted 3 lines
The other option is to ensure the specific drivers aren't ever compiled for !CONFIG_AEABI.
Then it'll all get tidied up when you remove it.That sounds like even more work, for my own testing I have just stopped building OABI configuration altogether, though I'm still testing ARMv4 kernels.
Is it possible to stop the build robot doing that as well? Might stop us having to worry about obscure build failures on something that is heading to its death bed.
Quoted 5 lines
Quoted 4 lines
I read that the patches to remove 486 support have been merged. I'm sure it would have made sense to drop everything before P-Pro so that cmov can be used.
Quoted 9 lines
That is an entirely unrelated discussion of course. I don't think there is any need to discontinue support for 586-class processors (Pentium, Pentium MMX, MediaGX/GeodeGX1, AMD K6, Vortex86/DX/MX, Via C3) any earlier than the rest of the x86-32 kernel support: There is no practical difference other than compiler flags, and the Vortex86MX+ is still in production (originally released in 2010 with a projected 10 year support life). This is very different from earlier 486-class CPUs that lack CMPXCHG8B and TSC.
That is a lot more recent that the 1995 date of the P6/pro itself.
I was contemplating writing the 'masked user access' code for x86. Mostly just involves generating the address space gap. But the asm is easiest if it uses cmov.
I may need to work out how to use qemu, a userpace consisting of a busybox shell running as pid 1 is probably enough.
David
Quoted 2 lines
Arnd