Skip to contentSkip to conversation

netfilter: nft_set_rbtree: fix memory leak during insertion

PATCH New Florian Westphal 1 participant 1 message Apr 11

Subsystems (2)
lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 netfilter: nft_set_rbtree: fix memory leak during insertion

net/netfilter/nft_set_rbtree.c:399 __nft_rbtree_insert()
warn: 'removed_end' is not an error pointer

Delete this incorrect test, we only want to know if the current element was reaped.

This causes early "return-0", signalling a successful insertion of the element, but no insertion was done.

Fixes 087388278e0f ("netfilter: nf_tables: nft_set_rbtree: fix spurious

insertion failure")

---
 net/netfilter/nft_set_rbtree.c | 3 ---
 1 file changed, 3 deletions(-)
net/netfilter/nft_set_rbtree.c +0 -3
index 737c339decd0..3407109d6a5c 100644
@@ -396,9 +396,6 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set,
 			const struct nft_rbtree_elem *removed_end;
 
 			removed_end = nft_rbtree_gc_elem(set, priv, rbe);
-			if (IS_ERR(removed_end))
-				return PTR_ERR(removed_end);
-
 			if (removed_end == rbe_le || removed_end == rbe_ge)
 				return -EAGAIN;
 
Signature · 1 line
2.53.0