Skip to contentSkip to conversation

hfsplus: remove xattr error message

PATCH In review Colin Ian King 2 participants 4 messages Apr 11 – Apr 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hfsplus: remove xattr error message

When exercising hfsplus with the stress-ng xattr stressor a large quantity of somewhat unhelpful error messages "hfsplus: xattr exists yet" spam the kernel log. Remove these.

---
 fs/hfsplus/xattr.c | 2 --
 1 file changed, 2 deletions(-)
fs/hfsplus/xattr.c +0 -2
index c70bb6f494b2..e10e1d8a5862 100644
@@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
 	if (!strcmp_xattr_finder_info(name)) {
 		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
 			err = -EOPNOTSUPP;
 			goto end_setxattr;
 		}
@@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
 	if (hfsplus_attr_exists(inode, name)) {
 		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
 			err = -EOPNOTSUPP;
 			goto end_setxattr;
 		}
Signature · 1 line
2.53.0
#1 lore raw
Quoted 3 lines · Colin Ian King

When exercising hfsplus with the stress-ng xattr stressor a large quantity of somewhat unhelpful error messages "hfsplus: xattr exists yet" spam the kernel log. Remove these.

We can convert it into hfs_dbg() and to add showing inode ID + name. What do you think?

Also, there are other pr_err() in xattr code that can be converted into hfs_dbg(). Could you please take a look into other ones too?

Thanks,
Slava.

Quoted 26 lines
---
 fs/hfsplus/xattr.c | 2 --
 1 file changed, 2 deletions(-)
fs/hfsplus/xattr.c +0 -2
index c70bb6f494b2..e10e1d8a5862 100644
@@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
 	if (!strcmp_xattr_finder_info(name)) {
 		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
 			err = -EOPNOTSUPP;
 			goto end_setxattr;
 		}
@@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
 	if (hfsplus_attr_exists(inode, name)) {
 		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
 			err = -EOPNOTSUPP;
 			goto end_setxattr;
 		}
#2 lore raw
Quoted 7 lines · Viacheslav Dubeyko
Quoted 3 lines · Colin Ian King

When exercising hfsplus with the stress-ng xattr stressor a large quantity of somewhat unhelpful error messages "hfsplus: xattr exists yet" spam the kernel log. Remove these.

We can convert it into hfs_dbg() and to add showing inode ID + name. What do you think?

Yes, that's a good idea. Perhaps the phrase "xattr exists yet" can be rephrased as the message is not really that clear. Any ideas for an improved message?

Colin

Quoted 34 lines

Also, there are other pr_err() in xattr code that can be converted into hfs_dbg(). Could you please take a look into other ones too?

Thanks,
Slava.

Quoted 26 lines
---
  fs/hfsplus/xattr.c | 2 --
  1 file changed, 2 deletions(-)
fs/hfsplus/xattr.c +0 -2
index c70bb6f494b2..e10e1d8a5862 100644
@@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
  	if (!strcmp_xattr_finder_info(name)) {
  		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
  			err = -EOPNOTSUPP;
  			goto end_setxattr;
  		}
@@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
  	if (hfsplus_attr_exists(inode, name)) {
  		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
  			err = -EOPNOTSUPP;
  			goto end_setxattr;
  		}
#3 lore raw
Quoted 6 lines · Colin King (gmail)
Quoted 5 lines · Viacheslav Dubeyko
Quoted 3 lines · Colin Ian King

When exercising hfsplus with the stress-ng xattr stressor a large quantity of somewhat unhelpful error messages "hfsplus: xattr exists yet" spam the kernel log. Remove these.

Quoted 6 lines
Quoted 2 lines

We can convert it into hfs_dbg() and to add showing inode ID + name. What do you think?

Yes, that's a good idea. Perhaps the phrase "xattr exists yet" can be rephrased as the message is not really that clear. Any ideas for an improved message?

Maybe, "unable to recreate the existing xattr"?

Thanks,
Slava.

Quoted 37 lines

Colin

Quoted 34 lines

Also, there are other pr_err() in xattr code that can be converted into hfs_dbg(). Could you please take a look into other ones too?

Thanks,
Slava.

Quoted 26 lines
---
  fs/hfsplus/xattr.c | 2 --
  1 file changed, 2 deletions(-)
fs/hfsplus/xattr.c +0 -2
index c70bb6f494b2..e10e1d8a5862 100644
@@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
  	if (!strcmp_xattr_finder_info(name)) {
  		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
  			err = -EOPNOTSUPP;
  			goto end_setxattr;
  		}
@@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
  	if (hfsplus_attr_exists(inode, name)) {
  		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
  			err = -EOPNOTSUPP;
  			goto end_setxattr;
  		}