Skip to contentSkip to conversation

Docs/mm/damon/maintainer-profile: add AI review usage guideline

PATCH In review SeongJae Park 2 participants 5 messages Apr 11

Subsystems (4)
lore
Share & tools
lore

SeongJae Park

author maintainer
#0 lore raw

PATCH 1/1 Docs/mm/damon/maintainer-profile: add AI review usage guideline

DAMON is opted-in for DAMON patches scanning [1] and email delivery [2]. Clarify how that could be used on DAMON maintainer profile.

[1] https://github.com/sashiko-dev/sashiko/commit/ad9f4a98f958
[2] https://github.com/sashiko-dev/sashiko/commit/b554c7b6e733

---
 Documentation/mm/damon/maintainer-profile.rst | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
Documentation/mm/damon/maintainer-profile.rst +21 -0
index bcb9798a27a86..5c23b1281c50c 100644
@@ -100,3 +100,24 @@ There is also a public Google `calendar
 <https://calendar.google.com/calendar/u/0?cid=ZDIwOTA4YTMxNjc2MDQ3NTIyMmUzYTM5ZmQyM2U4NDA0ZGIwZjBiYmJlZGQxNDM0MmY4ZTRjOTE0NjdhZDRiY0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t>`_
 that has the events.  Anyone can subscribe to it.  DAMON maintainer will also
 provide periodic reminders to the mailing list ([email protected]).
+
+AI Review
+---------
+
+For patches that are publicly posted to DAMON mailing list
+([email protected]), AI reviews of the patches will be available at
+sashiko.dev.  The reviews could also be sent as mails to the author of the
+patch.
+
+Patch authors are encouraged to check the AI reviews and share their opinions.
+The sharing could be done as a reply to the mail thread.  Consider reducing the
+recipients list for such sharing, since some people are not really interested
+in AI reviews.  As a rule of thumb, drop individuals except DAMON maintainer
+and [email protected] from the recipients list.
+
+`hkml` also provides a `feature
+<https://github.com/sjp38/hackermail/blob/master/USAGE.md#forwarding-sashikodev-statuscomments-to-mailing-list>`_
+for such sharing.  Please feel free to use the feature.
+
+It is only a non-mandastory recommendation.  DAMON maintainer could also ask
+any question about the AI reviews, though.

base-commit: aeaae01df7d17b5742e22b65b06f666ddea76816

Signature · 1 line
2.47.3
reviewer
#1 lore raw
Quoted 29 lines · SeongJae Park

DAMON is opted-in for DAMON patches scanning [1] and email delivery [2]. Clarify how that could be used on DAMON maintainer profile.

[1] https://github.com/sashiko-dev/sashiko/commit/ad9f4a98f958
[2] https://github.com/sashiko-dev/sashiko/commit/b554c7b6e733

---
 Documentation/mm/damon/maintainer-profile.rst | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
Documentation/mm/damon/maintainer-profile.rst +10 -0
index bcb9798a27a86..5c23b1281c50c 100644
@@ -100,3 +100,24 @@ There is also a public Google `calendar
 <https://calendar.google.com/calendar/u/0?cid=ZDIwOTA4YTMxNjc2MDQ3NTIyMmUzYTM5ZmQyM2U4NDA0ZGIwZjBiYmJlZGQxNDM0MmY4ZTRjOTE0NjdhZDRiY0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t>`_
 that has the events.  Anyone can subscribe to it.  DAMON maintainer will also
 provide periodic reminders to the mailing list ([email protected]).
+
+AI Review
+---------
+
+For patches that are publicly posted to DAMON mailing list
+([email protected]), AI reviews of the patches will be available at
+sashiko.dev.  The reviews could also be sent as mails to the author of the
+patch.
+
+Patch authors are encouraged to check the AI reviews and share their opinions.

Documentation/mm/damon/maintainer-profile.rst There is also a public Google `calendar · line 122

Quoted 10 lines
Documentation/mm/damon/maintainer-profile.rst +10 -0
+The sharing could be done as a reply to the mail thread.  Consider reducing the
+recipients list for such sharing, since some people are not really interested
+in AI reviews.  As a rule of thumb, drop individuals except DAMON maintainer
+and [email protected] from the recipients list.
+
+`hkml` also provides a `feature
+<https://github.com/sjp38/hackermail/blob/master/USAGE.md#forwarding-sashikodev-statuscomments-to-mailing-list>`_
+for such sharing.  Please feel free to use the feature.
+
+It is only a non-mandastory recommendation.  DAMON maintainer could also ask

non-mandatory
or maybe
This is an optional recommendation.

Quoted 3 lines
Documentation/mm/damon/maintainer-profile.rst +1 -0
+any question about the AI reviews, though.

base-commit: aeaae01df7d17b5742e22b65b06f666ddea76816

Signature · 1 line
~Randy
author maintainer
#2 lore raw
Quoted 36 lines · On Sat, 11 Apr 2026 11:27:14 -0700 Randy Dunlap <[email protected]> wrote:
Quoted 33 lines · SeongJae Park

DAMON is opted-in for DAMON patches scanning [1] and email delivery [2]. Clarify how that could be used on DAMON maintainer profile.

[1] https://github.com/sashiko-dev/sashiko/commit/ad9f4a98f958
[2] https://github.com/sashiko-dev/sashiko/commit/b554c7b6e733

---
 Documentation/mm/damon/maintainer-profile.rst | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
Documentation/mm/damon/maintainer-profile.rst +14 -0
index bcb9798a27a86..5c23b1281c50c 100644
@@ -100,3 +100,24 @@ There is also a public Google `calendar
 <https://calendar.google.com/calendar/u/0?cid=ZDIwOTA4YTMxNjc2MDQ3NTIyMmUzYTM5ZmQyM2U4NDA0ZGIwZjBiYmJlZGQxNDM0MmY4ZTRjOTE0NjdhZDRiY0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t>`_
 that has the events.  Anyone can subscribe to it.  DAMON maintainer will also
 provide periodic reminders to the mailing list ([email protected]).
+
+AI Review
+---------
+
+For patches that are publicly posted to DAMON mailing list
+([email protected]), AI reviews of the patches will be available at
+sashiko.dev.  The reviews could also be sent as mails to the author of the
+patch.
+
+Patch authors are encouraged to check the AI reviews and share their opinions.
+The sharing could be done as a reply to the mail thread.  Consider reducing the
+recipients list for such sharing, since some people are not really interested
+in AI reviews.  As a rule of thumb, drop individuals except DAMON maintainer
+and [email protected] from the recipients list.
Quoted 8 lines

Documentation/mm/damon/maintainer-profile.rst There is also a public Google `calendar · line 122

Quoted 6 lines
Documentation/mm/damon/maintainer-profile.rst +6 -0
+
+`hkml` also provides a `feature
+<https://github.com/sjp38/hackermail/blob/master/USAGE.md#forwarding-sashikodev-statuscomments-to-mailing-list>`_
+for such sharing.  Please feel free to use the feature.
+
+It is only a non-mandastory recommendation.  DAMON maintainer could also ask

non-mandatory

Good eyes! Thank you, Randy. I use Google doc for typo checks, but seems the use of "-" made Google doc not to complain this.

Quoted 2 lines

or maybe
This is an optional recommendation.

Sounds better, I will respin with this, unless Andrew picks this patch with the change.

Thanks,
SJ

[...]

author maintainer
#3 lore raw

Re: (sashiko review) [PATCH] Docs/mm/damon/maintainer-profile: add AI review usage guideline

In reply to SeongJae Park
# sashiko review suggestions
#
# 1. Consider reducing recipients.  Maybe the author,
#    maintainers, reviewers, and mailing list of the
#    direct subsystem and parent susystem mailing lists
#    could be a starting point.
# 2. Add short summary of your opinion at the beginning.
#    For example:
#
#      TL;DR: sashiko found an issue.  I will respin.
#      TL;DR: sashiko found no issue on this patch.
#
# Please DON'T FORGET removing this comment block before
# sending this!

Forwarding full sashiko review in a reply format with my inline comments below, for sharing details of my view and doing followup discussions via mails if needed.

Quoted 36 lines
# review url: https://sashiko.dev/#/patchset/[email protected]
# start of sashiko.dev inline review
commit eaf13e650de39668ddb68467088d425fa3e8be04
Author: SeongJae Park <[email protected]>

Docs/mm/damon/maintainer-profile: add AI review usage guideline

This commit clarifies how the DAMON maintainer profile uses sashiko.dev for AI patch scanning and email delivery. It adds a new AI Review section explaining how patch authors can check reviews and share their opinions.

Quoted 12 lines
Documentation/mm/damon/maintainer-profile.rst +4 -0
index bcb9798a27a86..5c23b1281c50c 100644
@@ -100,3 +100,24 @@ There is also a public Google `calendar
 <https://calendar.google.com/calendar/u/0?cid=ZDIwOTA4YTMxNjc2MDQ3NTIyMmUzYTM5ZmQyM2U4NDA0ZGIwZjBiYmJlZGQxNDM0MmY4ZTRjOTE0NjdhZDRiY0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t>`_
 that has the events.  Anyone can subscribe to it.  DAMON maintainer will also
 provide periodic reminders to the mailing list ([email protected]).
+
+AI Review
+---------
+

Documentation/mm/damon/maintainer-profile.rst There is also a public Google `calendar · line 116

Quoted 10 lines
Documentation/mm/damon/maintainer-profile.rst +10 -0
+For patches that are publicly posted to DAMON mailing list
+([email protected]), AI reviews of the patches will be available at
+sashiko.dev.  The reviews could also be sent as mails to the author of the
+patch.
+
+Patch authors are encouraged to check the AI reviews and share their opinions.
+The sharing could be done as a reply to the mail thread.  Consider reducing the
+recipients list for such sharing, since some people are not really interested
+in AI reviews.  As a rule of thumb, drop individuals except DAMON maintainer
+and [email protected] from the recipients list.

Is [email protected] the correct mailing list to keep here?

Quoted 3 lines

The stable mailing list is exclusively for stable kernel backports. Sending ongoing patch AI review discussions to that list could result in spamming it. Should this perhaps be [email protected] instead?

I mean, drop individuals except DAMON maintainer, and also drop stable@. I will wordsmith like below:

'''

Documentation/mm/damon/maintainer-profile.rst +2 -2
@@ -112,8 +112,8 @@ patch.
 Patch authors are encouraged to check the AI reviews and share their opinions.
 The sharing could be done as a reply to the mail thread.  Consider reducing the
 recipients list for such sharing, since some people are not really interested
-in AI reviews.  As a rule of thumb, drop individuals except DAMON maintainer
-and [email protected] from the recipients list.
+in AI reviews.  As a rule of thumb, drop [email protected] and individuals
+except DAMON maintainer.
 
 `hkml` also provides a `feature
 <https://github.com/sjp38/hackermail/blob/master/USAGE.md#forwarding-sashikodev-statuscomments-to-mailing-list>`_

'''

Quoted 10 lines

Documentation/mm/damon/maintainer-profile.rst There is also a public Google `calendar · line 122

Quoted 7 lines
Documentation/mm/damon/maintainer-profile.rst +6 -0
+
+`hkml` also provides a `feature
+<https://github.com/sjp38/hackermail/blob/master/USAGE.md#forwarding-sashikodev-statuscomments-to-mailing-list>`_
+for such sharing.  Please feel free to use the feature.
+
+It is only a non-mandastory recommendation.  DAMON maintainer could also ask

This isn't a bug, but there's a typo (non-mandastory) here. It should be non-mandatory.

Good eye. Randy also found [1] this and I already promised to fix. Sashiko is better than google doc [2]!

Quoted 6 lines

Documentation/mm/damon/maintainer-profile.rst There is also a public Google `calendar · line 123

Quoted 2 lines
Documentation/mm/damon/maintainer-profile.rst +1 -0
+any question about the AI reviews, though.
# end of sashiko.dev inline review
# review url: https://sashiko.dev/#/patchset/[email protected]

[1] https://lore.kernel.org/[email protected]
[2] https://lore.kernel.org/[email protected]

Thanks,
SJ

# hkml [1] generated a draft of this mail.  You can regenerate
# this using below command:
#
#     hkml patch sashiko_dev --for_forwarding \
#             [email protected]
#
# [1] https://github.com/sjp38/hackermail
author maintainer
#4 lore raw

Re: (sashiko review) [PATCH] Docs/mm/damon/maintainer-profile: add AI review usage guideline

Quoted 6 lines · On Sat, 11 Apr 2026 11:48:01 -0700 SeongJae Park <[email protected]> wrote:
# sashiko review suggestions
#
# 1. Consider reducing recipients.  Maybe the author,
#    maintainers, reviewers, and mailing list of the
#    direct subsystem and parent susystem mailing lists
#    could be a starting point.
Quoted 8 lines
# 2. Add short summary of your opinion at the beginning.
#    For example:
#
#      TL;DR: sashiko found an issue.  I will respin.
#      TL;DR: sashiko found no issue on this patch.
#
# Please DON'T FORGET removing this comment block before
# sending this!

I forgot following my self guideline above. Sorry for the noise.

TL; DR: sashiko found an issue that better to be fixed. I will respin.

Thanks,
SJ

[...]