Skip to contentSkip to conversation

drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

PATCH Applied Arnd Bergmann 3 participants 4 messages Apr 13 – May 5

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

From: Arnd Bergmann <[email protected]>

Like a number of other panel drivers, this newly merged driver needs DRM_DISPLAY_DSC_HELPER to be enabled:

arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'

Fixes a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/Kconfig +1 -0
index cc8c8a066bb9..ce6098c0343a 100644
@@ -208,6 +208,7 @@ config DRM_PANEL_HIMAX_HX83121A
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DSC_HELPER
 	select DRM_KMS_HELPER
 	help
 	  Say Y here if you want to enable support for Himax HX83121A-based
Signature · 1 line
2.39.5
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Like a number of other panel drivers, this newly merged driver needs DRM_DISPLAY_DSC_HELPER to be enabled:

arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'

Fixes a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
---
  drivers/gpu/drm/panel/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/Kconfig +0 -0
index cc8c8a066bb9..ce6098c0343a 100644

drivers/gpu/drm/panel/Kconfig config DRM_PANEL_HIMAX_HX83121A · line 214

Quoted 7 lines
drivers/gpu/drm/panel/Kconfig +1 -0
@@ -208,6 +208,7 @@ config DRM_PANEL_HIMAX_HX83121A
  	depends on OF
  	depends on DRM_MIPI_DSI
  	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DSC_HELPER
  	select DRM_KMS_HELPER
  	help
  	  Say Y here if you want to enable support for Himax HX83121A-based

Thanks,
Neil

Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 19 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Like a number of other panel drivers, this newly merged driver needs DRM_DISPLAY_DSC_HELPER to be enabled:

arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'

Fixes a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
---
  drivers/gpu/drm/panel/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/Kconfig +0 -0
index cc8c8a066bb9..ce6098c0343a 100644

drivers/gpu/drm/panel/Kconfig config DRM_PANEL_HIMAX_HX83121A · line 214

Quoted 7 lines
drivers/gpu/drm/panel/Kconfig +1 -0
@@ -208,6 +208,7 @@ config DRM_PANEL_HIMAX_HX83121A
  	depends on OF
  	depends on DRM_MIPI_DSI
  	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DSC_HELPER
  	select DRM_KMS_HELPER
  	help
  	  Say Y here if you want to enable support for Himax HX83121A-based
maintainer Applied
#3 lore raw
In reply to Arnd Bergmann

Hi,

Quoted 8 lines · Arnd Bergmann

Like a number of other panel drivers, this newly merged driver needs DRM_DISPLAY_DSC_HELPER to be enabled:

arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'

[...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/defab7b01e0848e004077d7d8dcc04d305ea1a27
Signature · 1 line
Neil