Skip to contentSkip to conversation

perf loongarch: Fix build failure with CONFIG_LIBDW_DWARF_UNWIND

PATCH Applied WANG Rui 3 participants 5 messages Apr 14 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

WANG Rui

author
#0 lore raw

PATCH 1/1 perf loongarch: Fix build failure with CONFIG_LIBDW_DWARF_UNWIND

Building perf for LoongArch fails when CONFIG_LIBDW_DWARF_UNWIND is enabled because unwind-libdw.o is still referenced in arch/loongarch/util/Build.

Fixes e62fae9d9e8 ("perf unwind-libdw: Fix a cross-arch unwinding bug")
---
 tools/perf/arch/loongarch/util/Build | 1 -
 1 file changed, 1 deletion(-)
tools/perf/arch/loongarch/util/Build +0 -1
index 3ad73d0289f3..8d91e78d31c9 100644
@@ -1,4 +1,3 @@
 perf-util-y += header.o
 
 perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
-perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
Signature · 1 line
2.53.0

A message that is not in the archive (sent off-list or not yet received): CANVb8WZXZj1Yqd7foqHBLSHjO73r0Kg62bMbrb--aE8wR3G2hg@mail.gmail.com

author
#2 lore raw
Quoted 22 lines · jiny L
Quoted 18 lines · WANG Rui

Building perf for LoongArch fails when CONFIG_LIBDW_DWARF_UNWIND is enabled because unwind-libdw.o is still referenced in arch/loongarch/util/Build.

Fixes e62fae9d9e8 ("perf unwind-libdw: Fix a cross-arch unwinding bug")
---
 tools/perf/arch/loongarch/util/Build | 1 -
 1 file changed, 1 deletion(-)
tools/perf/arch/loongarch/util/Build +0 -0
index 3ad73d0289f3..8d91e78d31c9 100644
@@ -1,4 +1,3 @@
 perf-util-y += header.o
 
Quoted 8 lines
Quoted 6 lines
tools/perf/arch/loongarch/util/Build +0 -2
 perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
-perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
--

2.53.0

I happened to have the same build issue on linux 7.0 and I found there is already a patch fixing this https://lore.kernel.org/lkml/[email protected]/

Thanks for the reference.
Rui

maintainer
#3 lore raw
Quoted 32 lines · hev
Quoted 22 lines · jiny L
Quoted 18 lines · WANG Rui

Building perf for LoongArch fails when CONFIG_LIBDW_DWARF_UNWIND is enabled because unwind-libdw.o is still referenced in arch/loongarch/util/Build.

Fixes e62fae9d9e8 ("perf unwind-libdw: Fix a cross-arch unwinding bug")
---
 tools/perf/arch/loongarch/util/Build | 1 -
 1 file changed, 1 deletion(-)
tools/perf/arch/loongarch/util/Build +0 -0
index 3ad73d0289f3..8d91e78d31c9 100644
@@ -1,4 +1,3 @@
 perf-util-y += header.o
 
Quoted 8 lines
Quoted 6 lines
tools/perf/arch/loongarch/util/Build +0 -2
 perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
-perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
--

2.53.0

I happened to have the same build issue on linux 7.0 and I found there is already a patch fixing this https://lore.kernel.org/lkml/[email protected]/

Quoted 2 lines

Thanks for the reference.
Rui

As the Ian's series is still under review, I'd pick this one instead.

Thanks,
Namhyung

maintainer Acked-by on v1 1/1
#4 lore raw
In reply to WANG Rui
Quoted 7 lines · WANG Rui

Building perf for LoongArch fails when CONFIG_LIBDW_DWARF_UNWIND is enabled because unwind-libdw.o is still referenced in arch/loongarch/util/Build.

Fixes e62fae9d9e8 ("perf unwind-libdw: Fix a cross-arch unwinding bug")
Quoted 17 lines
---
 tools/perf/arch/loongarch/util/Build | 1 -
 1 file changed, 1 deletion(-)
tools/perf/arch/loongarch/util/Build +0 -2
index 3ad73d0289f3..8d91e78d31c9 100644
@@ -1,4 +1,3 @@
 perf-util-y += header.o
 
 perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
-perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
--

2.53.0

maintainer Applied
#5 lore raw
In reply to WANG Rui
Quoted 5 lines · WANG Rui

Building perf for LoongArch fails when CONFIG_LIBDW_DWARF_UNWIND is enabled because unwind-libdw.o is still referenced in arch/loongarch/util/Build.

Applied to perf-tools-next, thanks!

Best regards,
Namhyung