Skip to contentSkip to conversation

Fix EIC7700 USB reset's issue

PATCH In review [email protected] 2 participants 3 messages Apr 15

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

PATCH v2 1/1 dt-bindings: usb: Fix EIC7700 USB reset's issue

From: Hang Cao <[email protected]>

The EIC7700 USB requires a USB PHY reset operation; otherwise, the USB will not work. The reason why the USB driver that was applied can work properly is that the USB PHY has already been reset in ESWIN's U-Boot.

However, the proper functioning of the USB driver should not be dependent on the bootloader. Therefore, it is necessary to incorporate the USB PHY reset signal into the DT bindings.

This patch does not introduce any backward incompatibility since the dts is not upstream yet. As array of reset operations are used in the driver, no modifications to the USB controller driver are needed.

Fixes c640a4239db5 ("dt-bindings: usb: Add ESWIN EIC7700 USB controller")
---
 .../devicetree/bindings/usb/eswin,eic7700-usb.yaml         | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/usb/eswin,eic7700-usb.yaml +4 -3
index 41c3b1b98991..658260619423 100644
@@ -41,12 +41,13 @@ properties:
       - const: usb_en
 
   resets:
-    maxItems: 2
+    maxItems: 3
 
   reset-names:
     items:
       - const: vaux
       - const: usb_rst
+      - const: usb_phy
 
   eswin,hsp-sp-csr:
     description:
@@ -85,8 +86,8 @@ examples:
         interrupt-parent = <&plic>;
         interrupts = <85>;
         interrupt-names = "peripheral";
-        resets = <&reset 84>, <&hspcrg 2>;
-        reset-names = "vaux", "usb_rst";
+        resets = <&reset 84>, <&hspcrg 2>, <&hspcrg 4>;
+        reset-names = "vaux", "usb_rst", "usb_phy";
         dr_mode = "peripheral";
         maximum-speed = "high-speed";
         phy_type = "utmi";

--
2.34.1

Acked-by on v2 1/1
#2 lore raw

Re: [PATCH v2 1/1] dt-bindings: usb: Fix EIC7700 USB reset's issue

Quoted 10 lines · On Wed, Apr 15, 2026 at 02:42:38PM +0800, [email protected] wrote:

From: Hang Cao <[email protected]>

The EIC7700 USB requires a USB PHY reset operation; otherwise, the USB will not work. The reason why the USB driver that was applied can work properly is that the USB PHY has already been reset in ESWIN's U-Boot.

However, the proper functioning of the USB driver should not be dependent on the bootloader. Therefore, it is necessary to incorporate the USB PHY reset signal into the DT bindings.

Quoted 6 lines

This patch does not introduce any backward incompatibility since the dts is not upstream yet. As array of reset operations are used in the driver, no modifications to the USB controller driver are needed.

Fixes c640a4239db5 ("dt-bindings: usb: Add ESWIN EIC7700 USB controller")