Skip to contentSkip to conversation

sandbox: enable FIT_SIGNATURE

PATCH In review Philippe Reynes 3 participants 3 messages Apr 15 – Apr 17

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sandbox: enable FIT_SIGNATURE

Since commit d09256283f72 ("FIT: Image pre-load signature support must select not depends on FIT_SIGNATURE") FIT_SIGNATURE is disabled on sandbox. But this config is used on many fit signature tests. So FIT_SIGNATURE should be enabled on sandbox.

Fixes d09256283f72 ("FIT: Image pre-load signature support must select not depends on FIT_SIGNATURE")
---
 configs/sandbox_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/sandbox_defconfig +1 -0
index b681b91c3f9..f26295103f1 100644
@@ -21,6 +21,7 @@ CONFIG_EFI_CAPSULE_AUTHENTICATE=y
 CONFIG_EFI_CAPSULE_CRT_FILE="board/sandbox/capsule_pub_key_good.crt"
 CONFIG_BUTTON_CMD=y
 CONFIG_FIT=y
+CONFIG_FIT_SIGNATURE=y
 CONFIG_FIT_CIPHER=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_BOOTMETH_ANDROID=y
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Philippe Reynes

Since commit d09256283f72 ("FIT: Image pre-load signature support must select not depends on FIT_SIGNATURE") FIT_SIGNATURE is disabled on sandbox. But this config is used on many fit signature tests. So FIT_SIGNATURE should be enabled on sandbox.

Quoted 6 lines
Fixes d09256283f72 ("FIT: Image pre-load signature support must select not depends on FIT_SIGNATURE")
---
 configs/sandbox_defconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines
configs/sandbox_defconfig +1 -1
index b681b91c3f9..f26295103f1 100644
@@ -21,6 +21,7 @@ CONFIG_EFI_CAPSULE_AUTHENTICATE=y
 CONFIG_EFI_CAPSULE_CRT_FILE="board/sandbox/capsule_pub_key_good.crt"
 CONFIG_BUTTON_CMD=y
 CONFIG_FIT=y
+CONFIG_FIT_SIGNATURE=y
 CONFIG_FIT_CIPHER=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_BOOTMETH_ANDROID=y
--

2.43.0

#2 lore raw
In reply to Philippe Reynes
Quoted 8 lines · Philippe Reynes

Since commit d09256283f72 ("FIT: Image pre-load signature support must select not depends on FIT_SIGNATURE") FIT_SIGNATURE is disabled on sandbox. But this config is used on many fit signature tests. So FIT_SIGNATURE should be enabled on sandbox.

[...]

Applied to u-boot/master, thanks!

[1/1] sandbox: enable FIT_SIGNATURE

      commit: 30429c8bd2f18d33862cc41fe520f7459fa4bfbd
Signature · 1 line
Tom