Skip to contentSkip to conversation

target/s390x: Prefer MO_128 definition over magic value

PATCH In review Philippe Mathieu-Daudé 5 participants 5 messages Apr 15 – Apr 17

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/s390x: Prefer MO_128 definition over magic value

The MO_128 definition was not existing when commit 6d841663be8 ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the ES_128 definition. It was added 2 years later in commit 4b473e0c60d ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available, replace the magic '4' by the more explicit 'MO_128'.

---
 target/s390x/tcg/translate_vx.c.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target/s390x/tcg/translate_vx.c.inc +1 -1
index b53e9e52639..447641df25c 100644
@@ -50,7 +50,7 @@
 #define ES_16   MO_16
 #define ES_32   MO_32
 #define ES_64   MO_64
-#define ES_128  4
+#define ES_128  MO_128
 
 /* Floating-Point Format */
 #define FPF_SHORT       2
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Philippe Mathieu-Daudé

The MO_128 definition was not existing when commit 6d841663be8 ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the ES_128 definition. It was added 2 years later in commit 4b473e0c60d ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available, replace the magic '4' by the more explicit 'MO_128'.

---
  target/s390x/tcg/translate_vx.c.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by on v1 1/1
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 16 lines · Philippe Mathieu-Daudé

The MO_128 definition was not existing when commit 6d841663be8 ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the ES_128 definition. It was added 2 years later in commit 4b473e0c60d ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available, replace the magic '4' by the more explicit 'MO_128'.

---
  target/s390x/tcg/translate_vx.c.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
target/s390x/tcg/translate_vx.c.inc +0 -0
index b53e9e52639..447641df25c 100644

target/s390x/tcg/translate_vx.c.inc line 56

Quoted 8 lines
target/s390x/tcg/translate_vx.c.inc +1 -1
@@ -50,7 +50,7 @@
  #define ES_16   MO_16
  #define ES_32   MO_32
  #define ES_64   MO_64
-#define ES_128  4
+#define ES_128  MO_128
 
  /* Floating-Point Format */
  #define FPF_SHORT       2

r~

Reviewed-by on v1 1/1
#3 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 7 lines · Philippe Mathieu-Daudé

The MO_128 definition was not existing when commit 6d841663be8 ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the ES_128 definition. It was added 2 years later in commit 4b473e0c60d ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available, replace the magic '4' by the more explicit 'MO_128'.

#4 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 10 lines · Philippe Mathieu-Daudé

The MO_128 definition was not existing when commit 6d841663be8 ("s390x/tcg: Implement VECTOR GATHER ELEMENT") introduced the ES_128 definition. It was added 2 years later in commit 4b473e0c60d ("tcg: Expand MO_SIZE to 3 bits"). Since it is now available, replace the magic '4' by the more explicit 'MO_128'.

---
 target/s390x/tcg/translate_vx.c.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, queued to s390-next.