Skip to contentSkip to conversation

nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export

PATCH In review Jeff Layton 2 participants 2 messages Apr 16

Subsystems (2)
lore
Share & tools
lore

Jeff Layton

author maintainer
#0 lore raw

PATCH 1/1 nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export

Anna was seeing these warnings with a clang W=1 build:

Warning: fs/nfsd/export.c:845 Cannot find identifier on line:

@cd: cache_detail for the svc_export cache,
Warning: fs/nfsd/export.c:846 Cannot find identifier on line:

@attr: nested attribute containing svc-export fields,
Warning: fs/nfsd/export.c:847 Cannot find identifier on line:
*
Warning: fs/nfsd/export.c:848 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst

Fixes 9d2c4bbf7435 ("nfsd: add netlink upcall for the svc_export cache")

---
Trivial doc fix. Feel free to fold into the Fixes patch if you get this before the sending the PR to Linus.

---
 fs/nfsd/export.c | 1 +
 1 file changed, 1 insertion(+)
fs/nfsd/export.c +1 -0
index f562d383439b..99959cecdbbd 100644
@@ -843,6 +843,7 @@ static int check_export(const struct path *path, int *flags,
 			unsigned char *uuid);
 
 /**
+ * nfsd_nl_parse_one_export - parse a svc_export entry from a netlink downcall
  * @cd: cache_detail for the svc_export cache
  * @attr: nested attribute containing svc-export fields
  *

---
base-commit: 07a9f86d6ee1a0dc3bac47e9819ec5269d01a603
change-id: 20260416-nfsd-doc-564f058f6f88

Best regards,

Signature · 1 line
Jeff Layton <[email protected]>
maintainer
#1 lore raw

From: Chuck Lever <[email protected]>

Quoted 8 lines · Jeff Layton

Anna was seeing these warnings with a clang W=1 build:

Warning: fs/nfsd/export.c:845 Cannot find identifier on line:

@cd: cache_detail for the svc_export cache,
Warning: fs/nfsd/export.c:846 Cannot find identifier on line:

[...]

Applied to nfsd-testing, thanks!

[1/1] nfsd: add missing function name to kerneldoc comment for nfsd_nl_parse_one_export
(no commit info)

--
Chuck Lever <[email protected]>