Skip to contentSkip to conversation

drm/bridge/cdns-mhdp8546: Fix incorrect register clear in j721e disable

PATCH In review Udit Kumar 2 participants 2 messages Apr 16 – Apr 22

Subsystems (4)
lore
Share & tools
lore

Udit Kumar

author
#0 lore raw

PATCH 1/1 drm/bridge/cdns-mhdp8546: Fix incorrect register clear in j721e disable

Fix the cdns_mhdp_j721e_disable() function to clear the correct register. The function should clear DPTX_SRC_CFG (video source configuration) instead of DPTX_DSC_CFG (DSC configuration) when disabling the display interface.

Clearing DPTX_SRC_CFG properly resets all video source settings (VIF enable bits and DPI selections) to their default state.

Fixes afba7e6c5fc19 ("drm: bridge: cdns-mhdp8546: Add TI J721E wrapper")
---
 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c +1 -1
index 12d04be4e242..5f92436ffa0a 100644
@@ -62,7 +62,7 @@ static void cdns_mhdp_j721e_enable(struct cdns_mhdp_device *mhdp)
 static void cdns_mhdp_j721e_disable(struct cdns_mhdp_device *mhdp)
 {
 	/* Put everything to defaults  */
-	writel(0, mhdp->j721e_regs + DPTX_DSC_CFG);
+	writel(0, mhdp->j721e_regs + DPTX_SRC_CFG);
 }
 
 const struct mhdp_platform_ops mhdp_ti_j721e_ops = {
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Udit Kumar

Fix the cdns_mhdp_j721e_disable() function to clear the correct register. The function should clear DPTX_SRC_CFG (video source configuration) instead of DPTX_DSC_CFG (DSC configuration) when disabling the display interface.

Clearing DPTX_SRC_CFG properly resets all video source settings (VIF enable bits and DPI selections) to their default state.

Quoted 7 lines
Fixes afba7e6c5fc19 ("drm: bridge: cdns-mhdp8546: Add TI J721E wrapper")
---
 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 2 lines
With best wishes
Dmitry