dt-bindings: Remove the redundant 'type: boolean'
Subsystems (8)
PATCH 1/1 dt-bindings: Remove the redundant 'type: boolean'
From: bui duc phuc <[email protected]>
The 'wakeup-source' property already has its type defined in the core schema. Remove the redundant 'type: boolean' from the binding file to clean up the binding files.
--- Documentation/devicetree/bindings/input/atmel,maxtouch.yaml | 3 +-- Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml | 3 +-- Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/input/atmel,maxtouch.yaml +1 -2
@@ -88,8 +88,7 @@ properties: - 2 # ATMEL_MXT_WAKEUP_GPIO default: 0 - wakeup-source: - type: boolean + wakeup-source: true required: - compatible
Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml +1 -2
@@ -44,8 +44,7 @@ properties: description: Telling whether or not this PMIC is controlling the system power. - wakeup-source: - type: boolean + wakeup-source: true vcc1-supply: description:
Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml +1 -2
@@ -33,8 +33,7 @@ properties: vbus-supply: description: VBUS power supply - wakeup-source: - type: boolean + wakeup-source: true connector: type: object
Signature · 1 line
2.43.0
Quoted 6 lines · On Fri, 17 Apr 2026 09:18:58 +0700, [email protected] wrote:
From: bui duc phuc <[email protected]>
The 'wakeup-source' property already has its type defined in the core schema. Remove the redundant 'type: boolean' from the binding file to clean up the binding files.
Quoted 7 lines
Signed-off-by bui duc phuc <[email protected]>--- Documentation/devicetree/bindings/input/atmel,maxtouch.yaml | 3 +-- Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml | 3 +-- Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-)
Applied, thanks!
Quoted 10 lines · On 17/04/2026 04:18, [email protected] wrote:
From: bui duc phuc <[email protected]>
The 'wakeup-source' property already has its type defined in the core schema. Remove the redundant 'type: boolean' from the binding file to clean up the binding files.
Signed-off-by bui duc phuc <[email protected]>--- Documentation/devicetree/bindings/input/atmel,maxtouch.yaml | 3 +-- Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml | 3 +--
Why did you change one file and ignore the rest?
Why did you not mention previous feedback I gave you on your patches (some time ago), that there are TWO TYPES defined for wakeup-source.
Best regards,
Krzysztof
Hi Krzysztof,
Quoted 1 line
Why did you change one file and ignore the rest?
I'm processing the remaining files with caution. Files without significant descriptions or context will be updated in the upcoming patches.
Those with specific descriptions require deeper review and will be handled in separate patch series later.
Quoted 3 lines
Why did you not mention previous feedback I gave you on your patches
(some time ago), that there are TWO TYPES defined for wakeup-source.
Thanks for mentioning this.
In v2 of the patch, I reviewed the previous discussion between you and Connor regarding the two types for wakeup-source.
https://lore.kernel.org/all/[email protected]/
When moving to v3, I followed Rob’s suggestion to use true. I also sent a follow-up email to confirm this approach,
and since I did not receive further comments, I assumed this direction was acceptable.
https://lore.kernel.org/all/CAABR9nH3hr+Y5ksD0cn3Gd9XUvmb07X7zJw0b4k_yVbnAuz9=w@mail.gmail.com/
Best Regards,
Phuc