Skip to contentSkip to conversation

remoteproc: dead code cleanup in Kconfig for STM32_RPROC

PATCH In review Julian Braha 2 participants 2 messages Apr 17 – Apr 22 Remote processor (remoteproc)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 remoteproc: dead code cleanup in Kconfig for STM32_RPROC

There is already an 'if REMOTEPROC' condition wrapping this config option, making the 'depends on REMOTEPROC' statement a duplicate dependency (dead code).

I propose leaving the outer 'if REMOTEPROC...endif' and removing the individual 'depends on REMOTEPROC' statement.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

---
v2: fix typo in commit message
Link to v1: https://lore.kernel.org/all/[email protected]/

---
 drivers/remoteproc/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/remoteproc/Kconfig +0 -1
index ee54436fea5a..c78e431b7b2d 100644
@@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
 config STM32_RPROC
 	tristate "STM32 remoteproc support"
 	depends on ARCH_STM32 || COMPILE_TEST
-	depends on REMOTEPROC
 	select MAILBOX
 	help
 	  Say y here to support STM32 MCU processors via the
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 9 lines · Julian Braha

There is already an 'if REMOTEPROC' condition wrapping this config option, making the 'depends on REMOTEPROC' statement a duplicate dependency (dead code).

I propose leaving the outer 'if REMOTEPROC...endif' and removing the individual 'depends on REMOTEPROC' statement.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Quoted 8 lines

---
v2: fix typo in commit message
Link to v1: https://lore.kernel.org/all/[email protected]/

---
 drivers/remoteproc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

I have picked-up this patch. It will show up in rproc-next when 7.1-rc1 is released next week.

Thanks,
Mathieu

Quoted 15 lines
drivers/remoteproc/Kconfig +0 -1
index ee54436fea5a..c78e431b7b2d 100644
@@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
 config STM32_RPROC
 	tristate "STM32 remoteproc support"
 	depends on ARCH_STM32 || COMPILE_TEST
-	depends on REMOTEPROC
 	select MAILBOX
 	help
 	  Say y here to support STM32 MCU processors via the
Signature · 1 line
2.53.0